Re: Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review204892 --- Patch looks great! Reviews applied: [67411, 67412, 67413, 67487,

Re: Review Request 67606: Allowed for unbundled libevent cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/#review204891 --- PASS: Mesos patch 67606 was successfully built and tested. Review

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/#review204890 --- PASS: Mesos patch 67601 was successfully built and tested. Review

Re: Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67565/#review204889 --- Patch looks great! Reviews applied: [67563, 67526, 67564, 67565]

Re: Review Request 67606: Allowed for unbundled libevent cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/ --- (Updated June 16, 2018, 2:06 a.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/ --- (Updated 六月 16, 2018, 1:20 a.m.) Review request for mesos and Gilbert Song. C

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/#review204888 --- Patch looks great! Reviews applied: [67606] Passed command: expo

Re: Review Request 62515: Added mpsc_linked_queue and use it as the concurrent event queue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62515/#review204887 --- FAIL: Failed to apply the current review. Failed command: `python

Re: Review Request 67517: Added a test to verify `min_allocatable_resources` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67517/#review204886 --- PASS: Mesos patch 67517 was successfully built and tested. Review

Re: Review Request 67596: Fixed the flakiness in the `NVIDIA_GPU_NvidiaDockerImage` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67596/ --- (Updated June 15, 2018, 11:29 p.m.) Review request for mesos, Jie Yu, Joseph Wu

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/#review204885 --- Fix it, then Ship it! Seems reasonable. Going forward, we shoul

Re: Review Request 67604: Made configured shell script inputs executable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67604/#review204884 --- Ship it! Tested a clean build with CMake + Ninja on Ubunto; all

Re: Review Request 67596: Fixed the flakiness in the `NVIDIA_GPU_NvidiaDockerImage` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67596/#review204883 --- Ship it! Ship It! - Jie Yu On June 14, 2018, 3:47 a.m., Chun

Re: Review Request 67615: Modified `createStrippedScalarQuantity()` to clear all metadata fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67615/#review204882 --- PASS: Mesos patch 67615 was successfully built and tested. Review

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67308/#review204881 --- PASS: Mesos patch 67308 was successfully built and tested. Review

Re: Review Request 67517: Added a test to verify `min_allocatable_resources` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67517/ --- (Updated June 15, 2018, 3:05 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 67513: Added a master flag to configure minimum allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67513/ --- (Updated June 15, 2018, 3:02 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 67614: Removed memcpy from os::Fork::instantiate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67614/#review204876 --- Ship it! Thanks for this cleanup James! Do you know whether we

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/#review204874 --- Patch looks great! Reviews applied: [67502, 67503, 67504, 67505]

Re: Review Request 67614: Removed memcpy from os::Fork::instantiate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67614/#review204871 --- PASS: Mesos patch 67614 was successfully built and tested. Review

Re: Review Request 67616: Added the limitation of the nested container id length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67616/#review204869 --- PASS: Mesos patch 67616 was successfully built and tested. Review

Review Request 67615: Modified `createStrippedScalarQuantity()` to clear all metadata fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67615/ --- Review request for mesos, Benjamin Mahler, Kapil Arya, and Till Toenshoff. Repo

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67308/ --- (Updated June 15, 2018, 1:45 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67597: Fixed an issue where agent may fail to recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67597/#review204865 --- PASS: Mesos patch 67597 was successfully built and tested. Review

Review Request 67616: Added the limitation of the nested container id length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67616/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-7168 https:/

Review Request 67614: Removed memcpy from os::Fork::instantiate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67614/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9002 https://iss

Re: Review Request 67597: Fixed an issue where agent may fail to recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67597/ --- (Updated 六月 15, 2018, 5:44 p.m.) Review request for mesos and Gilbert Song. C

Re: Review Request 67609: Added DaoTan Cui to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67609/#review204854 --- Patch looks great! Reviews applied: [67609] Passed command: expo

Re: Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

> On 六月 14, 2018, 11:18 p.m., Gilbert Song wrote: > > src/slave/containerizer/docker.cpp > > Lines 1386 (patched) > > > > > > one newline below fixed it - CHEN --

Re: Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67585/ --- (Updated 六月 15, 2018, 5:21 p.m.) Review request for mesos and Gilbert Song. B

Re: Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

> On 六月 14, 2018, 11:18 p.m., Gilbert Song wrote: > > src/slave/containerizer/docker.cpp > > Lines 1383-1385 (patched) > > > > > > Please follow this format: > > > > ``` > > if (containers_[containerI

Re: Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review204850 --- PASS: Mesos patch 67488 was successfully built and tested. Review

Re: Review Request 67604: Made configured shell script inputs executable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67604/#review204847 --- Patch looks great! Reviews applied: [67603, 67604] Passed comman

Re: Review Request 67412: Improved coverage with configure and `PYTHON` or `PYTHON_VERSION` set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67412/#review204843 --- Ship it! Ship It! - Kevin Klues On June 1, 2018, 3:14 p.m.,

Re: Review Request 67412: Improved coverage with configure and `PYTHON` or `PYTHON_VERSION` set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67412/#review204842 --- Fix it, then Ship it! Ship It! configure.ac Lines 2276-2277 (

Re: Review Request 67355: Removed `os::getenv()` calls from `MesosProcess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67355/#review204834 --- Fix it, then Ship it! I'll fix the outstanding issues and commi

Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67354/#review204835 --- Fix it, then Ship it! I'll fix the outstanding issues and commi

Re: Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67356/#review204832 --- Fix it, then Ship it! I'll fix the outstanding issues and commi

Re: Review Request 67575: Changed operator API to notify subscribers on every status change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67575/#review204840 --- include/mesos/master/master.proto Lines 605-606 (original), 605-6

Re: Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67565/#review204839 --- PASS: Mesos patch 67565 was successfully built and tested. Review

Re: Review Request 67411: Broadened check for Autotools Python environment variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67411/#review204837 --- Ship it! Ship It! - Kevin Klues On June 15, 2018, 1:16 p.m.,

Re: Review Request 67411: Broadened check for Autotools Python environment variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67411/ --- (Updated June 15, 2018, 1:16 p.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 67398: Changed default executor tests to not use pipes for synchronization.

> On June 12, 2018, 9:47 p.m., Jie Yu wrote: > > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > > Lines 1017-1028 (original), 1012-1028 (patched) > > > > > > Any reason we cannot use a named pipe as

Re: Review Request 67398: Changed default executor tests to not use pipes for synchronization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67398/ --- (Updated June 15, 2018, 3 p.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 67564: Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67564/ --- (Updated June 15, 2018, 7:54 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67565/ --- (Updated June 15, 2018, 7:55 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 67526: Added container-specific cgroup FS mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67526/ --- (Updated June 15, 2018, 7:53 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

> On June 5, 2018, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/http.hpp > > Line 701 (original), 701-702 (patched) > > > > > > Why not using `process::http::Status::string()` > >

Re: Review Request 67597: Fixed an issue where agent may fail to recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67597/#review204824 --- Patch looks great! Reviews applied: [67597] Passed command: expo