Re: Review Request 68053: Call any function in a specified namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68053/ --- (Updated July 31, 2018, 5:34 a.m.) Review request for mesos, Benjamin Mahler, C

Review Request 68122: Fixed couple of typos in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68122/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 68118: Introduced helpers to track agent resources in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68118/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 68123: Avoided unnecessary `Resources::allocations()` call in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68123/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 68119: Introduced a helper `updateSlaveResources` in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68119/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 68120: UI: Pull up the leader URL generation to a top-level function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68120/#review206639 --- PASS: Mesos patch 68120 was successfully built and tested. Review

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68104/#review206637 --- src/slave/http.cpp Lines 1818 (patched)

Re: Review Request 68103: Added an authorizer action for viewing of resource provider information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68103/#review206631 --- include/mesos/authorizer/acls.proto Lines 561 (patched)

Review Request 68120: UI: Pull up the leader URL generation to a top-level function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68120/ --- Review request for mesos, Armand Grillet and Gastón Kleiman. Repository: mesos

Re: Review Request 67187: Tested per-framework task state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ --- (Updated July 31, 2018, 1:53 a.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 68114: Fixed a gRPC compilation issue for Clang.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68114/#review206633 --- FAIL: Mesos binaries failed to build. Reviews applied: `['68091',

Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/#review206629 --- cmake/CompilationConfigure.cmake Lines 538-541 (patched)

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206625 --- src/common/command_utils.cpp Lines 186 (patched)

Re: Review Request 68074: Autotools: Always build gRPC in Mesos.

> On July 30, 2018, 10:16 a.m., Benjamin Bannier wrote: > > cmake/CompilationConfigure.cmake > > Line 80 (original), 80 (patched) > > > > > > If you want to keep separate patches for modifying autotools and cmake, >

Re: Review Request 67187: Tested per-framework task state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ --- (Updated July 31, 2018, 12:22 a.m.) Review request for mesos, Gastón Kleiman an

Re: Review Request 67187: Tested per-framework task state metrics.

> On July 25, 2018, 9:06 p.m., Gastón Kleiman wrote: > > src/tests/master_tests.cpp > > Lines 9113-9117 (patched) > > > > > > Can we use the new helpers here? > > > > ``` > > testing::Sequence taskSeq

Review Request 68114: Fixed a gRPC compilation issue for Clang.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68114/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-8395 https://iss

Re: Review Request 67930: Get tests ready for Windows UCR development.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67930/#review206624 --- Fix it, then Ship it! src/tests/uri_fetcher_tests.cpp Lines 28

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review206622 --- 3rdparty/CMakeLists.txt Lines 721-736 (original), 721-736 (patche

Re: Review Request 68054: Added networking statistics to cni isolator.

> On July 28, 2018, 12:29 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > > Lines 1506-1507 (patched) > > > > > > No need for this temp variable I got the following error witho

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/ --- (Updated July 30, 2018, 3:40 p.m.) Review request for mesos, Akash Gupta, Andre

Re: Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68111/#review206621 --- PASS: Mesos patch 68111 was successfully built and tested. Review

Re: Review Request 68054: Added networking statistics to cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/#review206620 --- PASS: Mesos patch 68054 was successfully built and tested. Review

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

> On July 16, 2018, 12:48 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['67930', '67931', '67932']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > > http:

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

> On July 18, 2018, 3:10 a.m., Mesos Reviewbot Windows wrote: > > Bad review! > > > > Error: > > Circular dependency detected for review 67931. Please fix the 'depends_on' > > field. Did this get fixed? - Andrew --- This is an automat

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

> On July 17, 2018, 11:16 a.m., Andrew Schwartzmeyer wrote: > > include/mesos/docker/spec.hpp > > Lines 124-126 (patched) > > > > > > I think this and the commit before need to be re-ordered, as this > > commit is i

Re: Review Request 67916: Patched Google Test with upstream bugfix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67916/#review206614 --- PASS: Mesos patch 67916 was successfully built and tested. Review

Re: Review Request 68048: Added documentation for per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68048/#review206613 --- Ship it! Ship It! - Gastón Kleiman On July 25, 2018, 4:06 p.

Re: Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68111/ --- (Updated July 30, 2018, 1:38 p.m.) Review request for mesos, Greg Mann and Vino

Re: Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68111/#review206609 --- I believe we should add some more content to explain what MesosCon

Re: Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post.

> On July 30, 2018, 1:16 p.m., Vinod Kone wrote: > > site/source/blog/2018-07-30-mesoscon-2018-cfp-is-now-open.md > > Lines 23 (patched) > > > > > > s/2018/2017/ Good catch! Thanks =). - Gastón --

Re: Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68111/ --- (Updated July 30, 2018, 1:17 p.m.) Review request for mesos, Greg Mann and Vino

Re: Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68111/#review206610 --- Fix it, then Ship it! site/source/blog/2018-07-30-mesoscon-201

Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68111/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos Descrip

Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68088/#review206608 --- PASS: Mesos patch 68088 was successfully built and tested. Review

Re: Review Request 67916: Patched Google Test with upstream bugfix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67916/ --- (Updated July 30, 2018, 11:50 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67916: Patched Google Test with upstream bugfix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67916/ --- (Updated July 30, 2018, 11:02 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 68098: Fixed rapidjson make install directory structure.

> On July 30, 2018, 9:22 a.m., Benno Evers wrote: > > Looks good, except for two typos in the commit message (`no_base` -> > > `nobase`, `strucutre` -> `structure`) > > Benjamin Mahler wrote: > Thanks for catching those! ah I accidentally lost my edits to the commit message typos prior to

Re: Review Request 68098: Fixed rapidjson make install directory structure.

> On July 30, 2018, 9:22 a.m., Benno Evers wrote: > > Looks good, except for two typos in the commit message (`no_base` -> > > `nobase`, `strucutre` -> `structure`) Thanks for catching those! - Benjamin --- This is an automatically gen

Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68088/#review206604 --- Ship it! Ship It! - Jason Lai On July 30, 2018, 5:50 p.m., Z

Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68088/ --- (Updated July 30, 2018, 10:50 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 68092: CMake: Always build gRPC in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68092/#review206593 --- Fix it, then Ship it! 3rdparty/CMakeLists.txt Line 1 (original

Re: Review Request 68074: Autotools: Always build gRPC in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68074/#review206589 --- Fix it, then Ship it! cmake/CompilationConfigure.cmake Line 80

Re: Review Request 68091: Always build gRPC in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68091/#review206594 --- Ship it! Ship It! - Benjamin Bannier On July 27, 2018, 9:07

Re: Review Request 68105: WIP: Bumped bundled zookeeper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68105/#review206591 --- FAIL: Failed to apply the current review. Failed command: `python

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROROVIDER` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68104/#review206590 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 68098: Fixed rapidjson make install directory structure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68098/#review206588 --- Ship it! Looks good, except for two typos in the commit message

Review Request 68105: WIP: Bumped bundled zookeeper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68105/ --- Review request for Mesos Reviewbot and Mesos Reviewbot Windows. Repository: mes

Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROROVIDER` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68104/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-8314

Review Request 68103: Added an authorizer action for viewing of resource provider information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68103/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-8314