Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/ --- (Updated Sept. 6, 2018, 8:29 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

> On Sept. 6, 2018, 3:27 a.m., Benjamin Bannier wrote: > > include/mesos/resources.hpp > > Line 588 (original), 590 (patched) > > > > > > `s/Resource/Resource_/`? `Resource_` is not exposed outside, it is

Re: Review Request 68639: Renamed `Resources::resources` vector and typedef its item type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68639/#review208438 --- PASS: Mesos patch 68639 was successfully built and tested.

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

> On Sept. 6, 2018, 10:27 a.m., Benjamin Bannier wrote: > > src/v1/resources.cpp > > Lines 2117-2118 (original), 2154-2178 (patched) > > > > > > This function looks redundant and identical to `Resources::add(const

Re: Review Request 68134: Avoided reviving on behalf of scheduler after agent reconfiguration.

> On Aug. 6, 2018, 9:49 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 759-768 (original), 757-759 (patched) > > > > > > Probably an explanation to the reader is warranted on

Re: Review Request 68639: Renamed `Resources::resources` vector and typedef its item type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68639/ --- (Updated Sept. 6, 2018, 5:35 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 68134: Avoided reviving on behalf of scheduler after agent reconfiguration.

> On Aug. 6, 2018, 9:49 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 759-768 (original), 757-759 (patched) > > > > > > Probably an explanation to the reader is warranted on

Re: Review Request 68662: Avoided double copying of outgoing messages in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68662/#review208434 --- PASS: Mesos patch 68662 was successfully built and tested.

Re: Review Request 68662: Avoided double copying of outgoing messages in the master.

> On Sept. 7, 2018, midnight, Gastón Kleiman wrote: > > src/master/metrics.hpp > > Lines 243 (patched) > > > > > > This kind message is not sent to v0 schedulers, so we should take it > > out. Chatted with Gastón

Re: Review Request 68662: Avoided double copying of outgoing messages in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68662/#review208432 --- Fix it, then Ship it! src/master/metrics.hpp Lines 231

Re: Review Request 68662: Avoided double copying of outgoing messages in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68662/#review208431 --- Fix it, then Ship it! src/master/metrics.hpp Lines 243

Re: Review Request 68637: Avoided extra copying of Resources in Master::offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68637/#review208430 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68637: Avoided extra copying of Resources in Master::offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68637/#review208429 --- Ship it! Ship It! - Meng Zhu On Sept. 6, 2018, 3:05 p.m.,

Re: Review Request 68660: Disabled SIGCHLD handling in the libev event loop.

> On Sept. 6, 2018, 10:47 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/posix/libev/libev.cpp > > Lines 84-89 (patched) > > > > > > * Let's use sigaction here rather than ::signal? See the portability > >

Re: Review Request 68660: Disabled SIGCHLD handling in the libev event loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68660/#review208427 --- 3rdparty/libprocess/src/posix/libev/libev.cpp Lines 84-89

Review Request 68662: Avoided double copying of outgoing messages in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68662/ --- Review request for mesos, Gastón Kleiman, Gilbert Song, and Greg Mann. Bugs:

Re: Review Request 68637: Avoided extra copying of Resources in Master::offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68637/ --- (Updated Sept. 6, 2018, 10:05 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/ --- (Updated Sept. 6, 2018, 2:56 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 68637: Avoided common-case extra copying of Resources in Master::offer.

> On Sept. 6, 2018, 4:42 a.m., Meng Zhu wrote: > > src/master/master.cpp > > Line 9379 (original), 9378 (patched) > > > > > > `DeleteSubrange` will affect all the elements after `i`, this may cause > > quite some

Re: Review Request 68660: Disabled SIGCHLD handling in the libev event loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68660/#review208423 --- PASS: Mesos patch 68660 was successfully built and tested.

Review Request 68660: Disabled SIGCHLD handling in the libev event loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68660/ --- Review request for mesos, Benjamin Bannier, Till Toenshoff, and Vinod Kone.

Re: Review Request 68644: Closed all file descriptors except `whitelist_fds` in posix/subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68644/#review208417 --- 3rdparty/libprocess/src/posix/subprocess.hpp Lines 195 (patched)

Re: Review Request 68643: Updated `MesosContainerizerLaunch` to call `os::lsof()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68643/#review208412 --- Fix it, then Ship it!

Re: Review Request 68642: Added `lsof()` into stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68642/#review208411 --- We should add a basic test for this, even if it just ensures that

Re: Review Request 65168: Fixed HTTP errors caused by dropped HTTP responses by IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65168/#review208410 --- PASS: Mesos patch 65168 was successfully built and tested.

Re: Review Request 65168: Fixed HTTP errors caused by dropped HTTP responses by IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65168/ --- (Updated Sept. 6, 2018, 3:22 p.m.) Review request for mesos, Alexander

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/#review208406 --- Fix it, then Ship it! src/master/http.cpp Line 2605

Re: Review Request 68236: Fixed `LaunchNestedContainerSessionsInParallel` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68236/#review208405 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 3, 2018,

Re: Review Request 68639: Renamed `Resources::resources` to `noMutationWithoutExclusiveOwnership`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68639/#review208400 --- include/mesos/v1/resources.hpp Lines 695-696 (original), 704-705

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/#review208402 --- include/mesos/resources.hpp Line 588 (original), 590 (patched)

Re: Review Request 68640: Added version check and bundling of libevent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/ --- (Updated Sept. 6, 2018, 10:07 a.m.) Review request for mesos, Benjamin

Re: Review Request 68654: Enabled isort for src/python/lib.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68654/#review208401 --- PASS: Mesos patch 68654 was successfully built and tested.

Re: Review Request 68641: Added version check and bundling of libevent within libprocess.

> On Sept. 6, 2018, 3:23 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Failed to apply the dependent review: 68640. > > > > Failed command: `python.exe .\support\apply-reviews.py -n -r 68640` > > > > All the build artifacts available at: > >

Review Request 68654: Enabled isort for src/python/lib.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68654/ --- Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.

Review Request 68653: Enabled isort for src/python/lib.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68653/ --- Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.