Review Request 68862: Removed unneeded pluginDir field from CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68862/ --- Review request for mesos, Gilbert Song, Qian Zhang, and Sergey Urbanovich.

Review Request 68861: Skipped CNI config load if named network is not enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68861/ --- Review request for mesos, Gilbert Song, Qian Zhang, and Sergey Urbanovich.

Re: Review Request 68808: Avoided dirtying the DRF sorter when an allocation is performed.

> On Sept. 26, 2018, 8:43 p.m., Meng Zhu wrote: > > src/master/allocator/sorter/drf/sorter.cpp > > Lines 365-369 (patched) > > > > > > I think we can just work with iterators. It will be more generic and > >

Review Request 68857: Fixed libevent M4 macro to be fully compatible with older autoconf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68857/ --- Review request for mesos, Benjamin Bannier, Benno Evers, and James Peach.

Review Request 68858: Fixed libevent M4 macro to be fully compatible with older autoconf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68858/ --- Review request for mesos, Benjamin Bannier, Benno Evers, and James Peach.

Re: Review Request 65811: Added Stout `path::normalize` function for POSIX paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/ --- (Updated Sept. 26, 2018, 11:59 p.m.) Review request for mesos, Anish Gupta,

Re: Review Request 68402: Added a test for XFS persistent volume isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68402/#review209058 --- Fix it, then Ship it!

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/#review209057 --- Fix it, then Ship it!

Re: Review Request 68856: Added missing python egg build extensions for libevent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68856/#review209054 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68856: Added missing python egg build extensions for libevent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68856/ --- (Updated Sept. 26, 2018, 10:19 p.m.) Review request for mesos, Benjamin

Re: Review Request 68856: Added missing python egg build extensions for libevent.

> On Sept. 26, 2018, 10:06 p.m., Benjamin Bannier wrote: > > src/python/native_common/ext_modules.py.in > > Lines 121-126 (patched) > > > > > > As discussed offline, I misunderstood part of the intention here. We >

Re: Review Request 68856: Added missing python egg build extensions for libevent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68856/#review209052 --- src/python/native_common/ext_modules.py.in Lines 121-126

Re: Review Request 68856: Added missing python egg build extensions for libevent.

> On Sept. 26, 2018, 9:48 p.m., Benjamin Bannier wrote: > > src/python/native_common/ext_modules.py.in > > Lines 121-126 (patched) > > > > > > This is inconsistent in checking whether files exist, and also > >

Re: Review Request 68839: Disabled flaky LaunchNestedContainerSessionsInParallel test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68839/#review209050 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 25, 2018,

Re: Review Request 68856: Added missing python egg build extensions for libevent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68856/#review209048 --- Fix it, then Ship it! LGTM if this passes CI.

Review Request 68856: Added missing python egg build extensions for libevent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68856/ --- Review request for mesos, Benjamin Bannier, Benno Evers, and James Peach.

Re: Review Request 68808: Avoided dirtying the DRF sorter when an allocation is performed.

> On Sept. 26, 2018, 1:43 p.m., Meng Zhu wrote: > > src/master/allocator/sorter/drf/sorter.cpp > > Lines 365-369 (patched) > > > > > > I think we can just work with iterators. It will be more generic and > >

Re: Review Request 68808: Avoided dirtying the DRF sorter when an allocation is performed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68808/#review209044 --- Ship it! Ship It! - Meng Zhu On Sept. 24, 2018, 7:23 p.m.,

Re: Review Request 68816: Prevented leaking files in some stout tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68816/#review209043 --- PASS: Mesos patch 68816 was successfully built and tested.

Re: Review Request 68808: Avoided dirtying the DRF sorter when an allocation is performed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68808/#review209041 --- src/master/allocator/sorter/drf/sorter.cpp Lines 349-352

Re: Review Request 68813: Added support for `Option` / `Option`.

> On Sept. 23, 2018, 1:31 p.m., Benjamin Bannier wrote: > > I am not convinced we should add this. The alternative of using e.g., an > > `Option` or `Option` seems to not only produce correct > > behavior (even when wrapping a ptr to `const`), but also caution users > > enough that noting

Re: Review Request 68833: Use total cluster resources as framework sorter "total".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68833/#review209039 --- Ship it! Ship It! - Meng Zhu On Sept. 24, 2018, 7:23 p.m.,

Re: Review Request 68810: Removed call to 'setsid()' in command executor if TTY attached.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68810/#review209034 --- src/launcher/executor.cpp Lines 520 (patched)

Re: Review Request 68816: Prevented leaking files in some stout tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68816/ --- (Updated Sept. 26, 2018, 9:11 p.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 68724: Added the ability to launch tasks with a TTY attached to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68724/#review209030 --- Ship it! Ship It! - Jie Yu On Sept. 22, 2018, 12:35 a.m.,

Re: Review Request 68816: Prevented leaking files in some stout tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68816/#review209026 --- Ship it! Ship It! - Till Toenshoff On Sept. 23, 2018, 7:32

Re: Review Request 68816: Prevented leaking files in some stout tests.

> On Sept. 26, 2018, 2:42 p.m., Till Toenshoff wrote: > > Ship It! Modulo CI issues. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68816/#review209026

Re: Review Request 68817: Prevented leaking files in some libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68817/#review209025 --- Ship it! Ship It! - Till Toenshoff On Sept. 23, 2018, 7:32

Re: Review Request 68819: Asserted element exists before accessing it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68819/#review209024 --- Ship it! Ship It! - Till Toenshoff On Sept. 23, 2018, 7:32