Re: Review Request 69216: Added small style fix-ups for libevent unbundling on CMake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69216/#review210209 --- Patch looks great! Reviews applied: [69140, 69216] Passed comman

Re: Review Request 69218: Fixed flaky `CgroupsIsolatorTest.ROOT_CGROUPS_CreateRecursively` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69218/#review210206 --- PASS: Mesos patch 69218 was successfully built and tested. Review

Re: Review Request 69217: Fixed compile errors on clang 3.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69217/#review210204 --- PASS: Mesos patch 69217 was successfully built and tested. Review

Re: Review Request 69210: Used the MS_SILENT mount flag to elide unwanted logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69210/#review210203 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69211/#review210202 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69218: Fixed flaky `CgroupsIsolatorTest.ROOT_CGROUPS_CreateRecursively` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69218/#review210201 --- Ship it! Ship It! - Gilbert Song On Oct. 30, 2018, 3:02 p.m.

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review210200 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69123/#review210194 --- Ship it! Ship It! - Gilbert Song On Oct. 25, 2018, 8:25 p.m.

Re: Review Request 69217: Fixed compile errors on clang 3.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69217/#review210193 --- Ship it! Ship It! - Gilbert Song On Oct. 30, 2018, 2:15 p.m.

Review Request 69218: Fixed flaky `CgroupsIsolatorTest.ROOT_CGROUPS_CreateRecursively` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69218/ --- Review request for mesos, fei long and Gilbert Song. Bugs: MESOS-9362 https

Re: Review Request 69216: Added small style fix-ups for libevent unbundling on CMake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69216/#review210192 --- PASS: Mesos patch 69216 was successfully built and tested. Review

Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69036/#review210147 --- Partial review. I still wonder whether we should mention CSI in t

Re: Review Request 69214: Mounted devpts with `gid=5` by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69214/#review210191 --- Patch looks great! Reviews applied: [69214] Passed command: expo

Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

> On Oct. 23, 2018, 2:51 p.m., James DeFelice wrote: > > include/mesos/mesos.proto > > Lines 2030 (patched) > > > > > > Referring to an implementation artifact like the "disk profile adaptor" > > seems strange in t

Review Request 69217: Fixed compile errors on clang 3.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69217/ --- Review request for mesos, Alexander Rukletsov and Gilbert Song. Repository: mes

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/ --- (Updated Oct. 30, 2018, 9:08 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69085: Stout: Added a sync option for `mkdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69085/ --- (Updated Oct. 30, 2018, 9:07 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69211/ --- (Updated Oct. 30, 2018, 9:03 p.m.) Review request for . Bugs: MESOS-9319

Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69211/ --- (Updated Oct. 30, 2018, 9:04 p.m.) Review request for . Bugs: MESOS-9319

Re: Review Request 69086: Moved container root construction to the isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69086/ --- (Updated Oct. 30, 2018, 9:03 p.m.) Review request for mesos, Gilbert Song, Jaso

Re: Review Request 69210: Used the MS_SILENT mount flag to elide unwanted logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69210/ --- (Updated Oct. 30, 2018, 9:03 p.m.) Review request for mesos, Gilbert Song, Jaso

Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69123/#review210188 --- Ship it! Ship It! - Qian Zhang On Oct. 26, 2018, 11:25 a.m.,

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

> On Oct. 24, 2018, 11:21 a.m., Joseph Wu wrote: > > We could probably do away with some of the double-negatives (i.e. `not > > UNBUNDLED` -> `BUNDLED`) in the new variable names and logic. > > Till Toenshoff wrote: > That one I would prefer to change, if needed, within a new RR as I am >

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review210187 --- Ship it! Ship It! - Joseph Wu On Oct. 30, 2018, 1:20 p.m., T

Re: Review Request 69216: Added small style fix-ups for libevent unbundling on CMake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69216/#review210185 --- Ship it! Ship It! - Joseph Wu On Oct. 30, 2018, 1:19 p.m., T

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

> On Oct. 24, 2018, 6:21 p.m., Joseph Wu wrote: > > We could probably do away with some of the double-negatives (i.e. `not > > UNBUNDLED` -> `BUNDLED`) in the new variable names and logic. That one I would prefer to change, if needed, within a new RR as I am strictly following the logic path e

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

> On Oct. 24, 2018, 6:21 p.m., Joseph Wu wrote: > > 3rdparty/cmake/FindLIBARCHIVE.cmake > > Lines 21-24 (patched) > > > > > > Prefix this with: > > ``` > > # NOTE: If this fails, stderr is ignored, and the out

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/ --- (Updated Oct. 30, 2018, 8:20 p.m.) Review request for mesos, Andrew Schwartzmey

Review Request 69216: Added small style fix-ups for libevent unbundling on CMake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69216/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Repository: mesos D

Re: Review Request 69214: Mounted devpts with `gid=5` by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69214/#review210183 --- PASS: Mesos patch 69214 was successfully built and tested. Review

Re: Review Request 69188: Ensured failed / discarded cgroups OOM notification is logged.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69188/#review210180 --- Ship it! Ship It! - Gilbert Song On Oct. 28, 2018, 9:11 p.m.

Re: Review Request 69205: Fixed FetcherTest.DuplicateFileURI on OSX.

> On Oct. 30, 2018, 11:48 a.m., Benjamin Bannier wrote: > > src/common/type_utils.cpp > > Lines 86 (patched) > > > > > > Not yours, but it would be great to document that we don't want to > > include `cache` explicit

Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier.

> On Oct. 25, 2018, 8:07 a.m., Qian Zhang wrote: > > src/linux/cgroups.cpp > > Lines 1071-1080 (original), 1071-1089 (patched) > > > > > > I see we already have an onAny callback `_listen`, can we close the fd > >

Re: Review Request 69205: Fixed FetcherTest.DuplicateFileURI on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69205/#review210177 --- Fix it, then Ship it! src/common/type_utils.cpp Lines 86 (patc

Re: Review Request 69214: Mounted devpts with `gid=5` by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69214/ --- (Updated Oct. 30, 2018, 6:47 p.m.) Review request for mesos, Gilbert Song, Jaso

Re: Review Request 69214: Mounted devpts with `gid=5` by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69214/ --- (Updated Oct. 30, 2018, 6:39 p.m.) Review request for mesos, Gilbert Song, Jaso

Re: Review Request 69214: Mounted devpts with `gid=5` by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69214/#review210176 --- PASS: Mesos patch 69214 was successfully built and tested. Review

Re: Review Request 69214: Mounted devpts with `gid=5` by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69214/#review210175 --- Ship it! Can you add a comment in the code about this gid=5 dec

Review Request 69214: Mounted devpts with `gid=5` by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69214/ --- Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu. Bu