Re: Review Request 69474: Added tests for agent/executor heartbeating.

2018-11-29 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69474/#review210965 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

2018-11-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69163/#review210962 --- In the final line of the commit message: s/not/no/ src/master/ma

Re: Review Request 68795: Added deduplication for read-only master requests.

2018-11-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68795/#review210960 --- The `PIPE` issue below is currently not a problem, since none of t

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

2018-11-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69162/#review210935 --- Fix it, then Ship it! In commit message: s/This patch add agent

Re: Review Request 69474: Added tests for agent/executor heartbeating.

2018-11-29 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69474/#review210961 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69071: Narrowed interface of `ReadOnlyHandler` members.

2018-11-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69071/#review210959 --- Ship it! LGTM, pending the other parts of the chain. - Joseph

Re: Review Request 69474: Added tests for agent/executor heartbeating.

2018-11-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69474/ --- (Updated Nov. 29, 2018, 4:03 p.m.) Review request for mesos, Benno Evers, Gastó

Re: Review Request 69411: Added new interface for constructing `cluster::Master`.

2018-11-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69411/#review210956 --- I'll summarize a discussion we held offline, between BenM, Benno,

Review Request 69481: Deallocated the shared persistent volume's gid when it is removed.

2018-11-29 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69481/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. Bug

Review Request 69480: Made non-root containers can access shared persistent volume.

2018-11-29 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69480/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. Bug

Re: Review Request 69479: Added the flag `--task_supplementary_groups` to command executor.

2018-11-29 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69479/ --- (Updated Nov. 29, 2018, 5:08 p.m.) Review request for mesos, Gilbert Song, Greg

Review Request 69479: Added the flag `--task_supplementary_groups` to command executor.

2018-11-29 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69479/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. Rep

Re: Review Request 69478: Added `task_supplementary_groups` into `ContainerLaunchInfo`.

2018-11-29 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69478/ --- (Updated Nov. 29, 2018, 5:06 p.m.) Review request for mesos, Gilbert Song, Greg

Re: Review Request 69454: Added the autoconf `tar-pax` option.

2018-11-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69454/#review210944 --- Ship it! Thanks for the patch, James! Could you update the com

Review Request 69478: Added `task_supplementary_groups` into `ContainerLaunchInfo`.

2018-11-29 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69478/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. Bug