Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213582 --- Patch looks great! Reviews applied: [70123, 70171, 70067] Passed

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

> On March 2, 2019, 7:24 a.m., Benjamin Mahler wrote: > > 3rdparty/stout/tests/option_tests.cpp > > Lines 137 (patched) > > > > > > this doesn't test that moving is working correctly? Can we test to > > ensure that

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/ --- (Updated March 8, 2019, 5:56 p.m.) Review request for mesos, Benjamin Bannier a

Review Request 70171: Added `Try` constructors from `_Some`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70171/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Repository: mes

Re: Review Request 70123: Added rvalue overload for `Result::get()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70123/ --- (Updated March 8, 2019, 5:50 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 70169: Refactored SLRP to use `ServiceManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/#review213578 --- Patch looks great! Reviews applied: [70168, 70169] Passed comman

Re: Review Request 70116: Added metrics for offer operation feedback.

> On March 4, 2019, 10:20 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 2261 (patched) > > > > > > Why not use `updateOperationMetrics(OPERATION_ERROR, 1);` here? Why not, indeed. > On March 4, 2019,

Re: Review Request 70117: WIP: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/ --- (Updated March 8, 2019, 11:58 p.m.) Review request for mesos, Gastón Kleiman, G

Re: Review Request 70117: WIP: Add unit tests for offer operation metrics.

> On March 4, 2019, 10:48 p.m., Greg Mann wrote: > > src/tests/agent_operation_feedback_tests.cpp > > Lines 280-283 (patched) > > > > > > I think we probably only need one test which verifies that this > > particula

Re: Review Request 70116: Added metrics for offer operation feedback.

> On March 8, 2019, 12:30 a.m., Gastón Kleiman wrote: > > src/master/master.hpp > > Lines 941-944 (patched) > > > > > > Is this used anywhere? It is not. Removed! > On March 8, 2019, 12:30 a.m., Gastón Kleiman wro

Re: Review Request 70116: Added metrics for offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/ --- (Updated March 8, 2019, 11:48 p.m.) Review request for mesos, Gastón Kleiman, G

Re: Review Request 70156: Added helper to test for metrics values.

> On March 7, 2019, 11:49 p.m., Gastón Kleiman wrote: > > src/tests/utils.hpp > > Lines 39 (patched) > > > > > > Nit: I'd name this `EXPECT_METRIC_EQ`. Fair point, I've used `metricEquals()` now that it isn't a macro

Re: Review Request 70156: Added helper to test for metrics values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70156/ --- (Updated March 8, 2019, 11:46 p.m.) Review request for mesos, Gastón Kleiman, G

Re: Review Request 70168: Added `ServiceManager` to manage CSI plugin container lifecycles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70168/ --- (Updated March 8, 2019, 11:31 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70169: Refactored SLRP to use `ServiceManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/#review213572 --- Patch looks great! Reviews applied: [70168, 70169] Passed comman

Re: Review Request 70166: Added test `VolumeGidManagerTest.ROOT_UNPRIVILEGED_USER_SlaveReboot`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70166/#review213571 --- Ship it! Ship It! - Gilbert Song On March 8, 2019, 6:22 a.m.

Review Request 70169: Refactored SLRP to use `ServiceManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-9632 htt

Review Request 70168: Added `ServiceManager` to manage CSI plugin container lifecycles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70168/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-9632 htt

Re: Review Request 70165: Fixed operator operation handling with resource provider resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70165/#review213570 --- Patch looks great! Reviews applied: [70165] Passed command: expo

Re: Review Request 70061: Added method `fromScalarResources` in `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70061/#review213568 --- Ship it! This seems to make `Resources::createStrippedScalarQua

Re: Review Request 70161: Added validation for `QuotaConfig`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70161/#review213567 --- src/master/quota.cpp Lines 316-334 (patched)

Re: Review Request 70159: Updated `UPDATE_QUOTA` call with a new schema.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70159/#review213566 --- Ship it! Ship It! - Benjamin Mahler On March 8, 2019, 7:21 a

Re: Review Request 70160: Added `<<` operator to `protobuf::Map`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70160/#review213565 --- include/mesos/type_utils.hpp Lines 533-545 (patched)

Re: Review Request 70165: Fixed operator operation handling with resource provider resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70165/#review213564 --- If it's possible that we might want to backport this in the future

Re: Review Request 70166: Added test `VolumeGidManagerTest.ROOT_UNPRIVILEGED_USER_SlaveReboot`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70166/#review213563 --- Patch looks great! Reviews applied: [70166] Passed command: expo

Re: Review Request 70156: Added helper to test for metrics values.

> On March 7, 2019, 6:41 p.m., Joseph Wu wrote: > > Hum... I wonder if it is worthwhile to make this a normal function call > > instead. > > ``` > > > > bool metricsEqual(string metric, T value) { > > JSON::Object metrics = Metrics(); > > if (metrics.count(metric) != 1) { > > return fal

Re: Review Request 70161: Added validation for `QuotaConfig`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70161/#review213561 --- Patch looks great! Reviews applied: [70061, 70062, 70069, 70063,

Re: Review Request 70165: Fixed operator operation handling with resource provider resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70165/#review213560 --- Thanks for fixing this and adding a test! I only did a partial re

Review Request 70166: Added test `VolumeGidManagerTest.ROOT_UNPRIVILEGED_USER_SlaveReboot`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70166/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-8767

Review Request 70165: Fixed operator operation handling with resource provider resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70165/ --- Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao. Bugs: MESOS-961

Re: Review Request 70123: Added rvalue overload for `Result::get()`.

> On March 5, 2019, 11:09 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/result.hpp > > Lines 129 (patched) > > > > > > ``` > > -> decltype(std::forward(self) > > .data > >

Re: Review Request 70158: WIP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70158/#review213556 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70133/#review213555 --- Patch looks great! Reviews applied: [70132, 70133] Passed comman

Re: Review Request 65847: Fixed allocator test `QuotaAbsentFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65847/#review213550 --- Bad review! Reviews applied: [65847, 65845, 65844, 65821, 65820,