Re: Review Request 70346: Removed unused function `Resources::isScalarQuantity`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70346/#review214232 --- PASS: Mesos patch 70346 was successfully built and tested. Review

Re: Review Request 70335: Sent FrameworkInfo to agents when applying operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70335/#review214231 --- PASS: Mesos patch 70335 was successfully built and tested. Review

Re: Review Request 70319: Added a `createQuantitiesMap` method in `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70319/#review214228 --- FAIL: Failed to apply the current review. Failed command: `python

Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/#review214227 --- FAIL: Failed to apply the dependent review: 70225. Failed command

Re: Review Request 70319: Added a `createQuantitiesMap` method in `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70319/#review214225 --- Bad review! Reviews applied: [70319, 70318] Error: 2019-03-29 23

Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI versions.

> On March 28, 2019, 9:23 a.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Line 4139 (original), 4139 (patched) > > > > > > Do you think it would make sense to put the value

Review Request 70346: Removed unused function `Resources::isScalarQuantity`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70346/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 70320: Used `ResourceQuantities` in `__allocate()` when appropriate.

> On March 27, 2019, 7:41 a.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1928 (patched) > > > > > > Rather than adding this additional function, can't `shrinkResoures` > > ta

Re: Review Request 70320: Used `ResourceQuantities` in `__allocate()` when appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70320/ --- (Updated March 29, 2019, 4:22 p.m.) Review request for mesos and Benjamin Mahle

Review Request 70345: Simplified quota chopping logic in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70345/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 70330: Used `ResourceQuantities` in the sorter when appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70330/#review214222 --- Bad review! Reviews applied: [70330, 70329, 70318] Error: 2019-0

Re: Review Request 70318: Added `empty()` method in `class ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70318/ --- (Updated March 29, 2019, 3:33 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/#review214221 --- Bad review! Reviews applied: [70321, 70303, 70302, 70225, 70223,

Re: Review Request 70344: Fixed a bug where disk quota may be under allocated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70344/#review214220 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70344: Fixed a bug where disk quota may be under allocated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70344/#review214218 --- Patch looks great! Reviews applied: [70344] Passed command: expo

Re: Review Request 70331: Updated test `AgentRegisteredWithNewId` for better code coverage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70331/#review214217 --- Ship it! Looks good to me. Like discussed offline, let's not j

Re: Review Request 70344: Fixed a bug where disk quota may be under allocated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70344/ --- (Updated March 29, 2019, 2:28 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 70331: Updated test `AgentRegisteredWithNewId` for better code coverage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70331/ --- (Updated March 29, 2019, 9:19 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70331: Updated test `AgentRegisteredWithNewId` for better code coverage.

> On March 28, 2019, 9:57 a.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1550 (patched) > > > > > > Let's check the range is not empty before dereferencing the iterat

Re: Review Request 70342: Removed use-after-free in operation handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70342/#review214212 --- Patch looks great! Reviews applied: [70342] Passed command: expo

Re: Review Request 70344: Fixed a bug where quota may be under allocated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70344/#review214211 --- Fix it, then Ship it! Could we make the summary/description/tes

Review Request 70344: Fixed a bug where quota may be under allocated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70344/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9692 https://issu

Re: Review Request 70342: Removed use-after-free in operation handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70342/#review214209 --- Ship it! Ship It! - Benjamin Bannier On March 29, 2019, 6:20

Review Request 70342: Removed use-after-free in operation handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70342/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Repository: mesos D

Re: Review Request 70281: Added stream operator overload for OperationStatus messages.

> On March 27, 2019, 3:11 p.m., Benjamin Bannier wrote: > > Looks good. Any testing you'd like to document? Sure, updated the description. - Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/ --- (Updated March 29, 2019, 1:52 p.m.) Review request for mesos, Gastón Kleiman, G

Re: Review Request 70334: Extended the glog LogSink interface to be able to log microseconds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70334/#review214203 --- Ship it! Ship It! - Benno Evers On March 28, 2019, 6:27 p.m.