Re: Review Request 71140: Fixed devolution of 'max_grace_period' field in DRAIN_AGENT call.

2019-07-23 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71140/#review216798 --- Bad review! Reviews applied: [71140] Error: 2019-07-23 09:08:30

Re: Review Request 71139: Removed `quota_info` in the `GET_QUOTA` authorization object.

2019-07-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71139/#review216801 --- Ship it! src/master/quota_handler.cpp Lines 420-423 (original)

Re: Review Request 71131: Refactored allocator test helper `createQuota`.

2019-07-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71131/#review216802 --- Ship it! src/tests/allocator.cpp Lines 31-35 (original), 30-34

Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings.

2019-07-23 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71082/ --- (Updated July 23, 2019, 4:13 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings.

2019-07-23 Thread Andrei Sekretenko
> On July 18, 2019, 5:59 p.m., Benjamin Mahler wrote: > > Looks like I will wait until the egg issue is fixed I haven't managed to find a **simple**, portable and non-racy way to simultaneously build two python eggs which need the same source. Gave up and moved that template specialization int

Re: Review Request 71130: Added a test to ensure allocations are restricted by quota limits.

2019-07-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71130/#review216803 --- Fix it, then Ship it! src/tests/hierarchical_allocator_tests.c

Re: Review Request 71083: Added enchanced multi-role capability support to the python bindings.

2019-07-23 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71083/ --- (Updated July 23, 2019, 4:27 p.m.) Review request for mesos, Benjamin Mahler an

Review Request 71143: Moved default constants for CSI RPC retry to a new header.

2019-07-23 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71143/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9254 https://iss

Review Request 71144: Added `reconciliation_interval_seconds` for storage resource providers.

2019-07-23 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71144/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9254 https://iss

Re: Review Request 71143: Moved default constants for CSI RPC retry to a new header.

2019-07-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71143/#review216810 --- Ship it! Ship It! - Benjamin Bannier On July 23, 2019, 9:53

Re: Review Request 71144: Added `reconciliation_interval_seconds` for storage resource providers.

2019-07-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71144/#review216809 --- Fix it, then Ship it! include/mesos/mesos.proto Lines 1155 (pa

Review Request 71150: Factored out storage provider method to update resources.

2019-07-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71150/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-9254 https://issu

Review Request 71148: Explicitly disabled periodic reconciliation for some provider tests.

2019-07-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71148/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-9254 https://issu

Review Request 71147: Update config factory to set resource provider reconciliation interval.

2019-07-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71147/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-9254 https://issu

Review Request 71146: Clarified a comment in storage local resource provider tests.

2019-07-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71146/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-9254 https://issu

Review Request 71149: Renamed a storage provider function.

2019-07-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71149/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-9254 https://issu

Review Request 71151: Performed periodic storage local provider reconciliations.

2019-07-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-9254 https://issu

Review Request 71145: Fixed signature to pass parameter by const ref instead of value.

2019-07-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71145/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-9254 https://issu

Re: Review Request 71068: Added offer rescind logic for limits enforcement.

2019-07-23 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71068/ --- (Updated July 23, 2019, 1:38 p.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 71084: Added unsuppressing via `updateFramework()` to python example framework.

2019-07-23 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71084/#review216814 --- Patch looks great! Reviews applied: [71082, 71083, 71084] Passed

Re: Review Request 71111: Added offer rescind logic for guarantees enforcement.

2019-07-23 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7/ --- (Updated July 23, 2019, 1:39 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71068: Added offer rescind logic for limits enforcement.

2019-07-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71068/#review216816 --- Fix it, then Ship it! Can you also include the additional cavea

Re: Review Request 71111: Added offer rescind logic for guarantees enforcement.

2019-07-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7/#review216817 --- Fix it, then Ship it! Ditto here, could you add the caveat abou

Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings.

2019-07-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71082/#review216818 --- Fix it, then Ship it! Looks good, I only held off on committing

Re: Review Request 71083: Added enchanced multi-role capability support to the python bindings.

2019-07-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71083/#review216819 --- Ship it! Ship It! - Benjamin Mahler On July 23, 2019, 4:27 p

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-07-23 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review216825 --- Bad patch! Reviews applied: [71143, 71144, 71145, 71146, 71147, 7