Re: Review Request 71882: Added a stout function to compute relative paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71882/#review218986 --- Patch looks great! Reviews applied: [71878, 71879, 71880, 71881,

Re: Review Request 71666: SSL Wrapper: Implemented send/recv and shutdown.

> On Dec. 5, 2019, 10:38 a.m., Greg Mann wrote: > > 3rdparty/libprocess/src/ssl/socket_wrapper.hpp > > Lines 94 (patched) > > > > > > In this case, we don't really need an actor context, since there isn't > > any

Re: Review Request 71666: SSL Wrapper: Implemented send/recv and shutdown.

> On Dec. 5, 2019, 6:38 p.m., Greg Mann wrote: > > 3rdparty/libprocess/src/ssl/socket_wrapper.hpp > > Lines 94 (patched) > > > > > > In this case, we don't really need an actor context, since there isn't > > any

Re: Review Request 71882: Added a stout function to compute relative paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71882/ --- (Updated Dec. 9, 2019, 5:48 p.m.) Review request for mesos and Benno Evers.

Re: Review Request 71882: Added a stout function to compute relative paths.

> On Dec. 9, 2019, 1:09 p.m., Benno Evers wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 21 (patched) > > > > > > This doesn't seem to be necessary anymore? This is required for e.g., `CHECK_EQ` (now).

Re: Review Request 71878: Added iteration support to stout's Path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71878/ --- (Updated Dec. 9, 2019, 5:48 p.m.) Review request for mesos and Benno Evers.

Re: Review Request 71878: Added iteration support to stout's Path.

> On Dec. 9, 2019, 3:34 p.m., Benno Evers wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 388 (patched) > > > > > > This feels a bit more "common" to me: > > > > struct PathComponentIterator

Re: Review Request 71878: Added iteration support to stout's Path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71878/ --- (Updated Dec. 9, 2019, 5:38 p.m.) Review request for mesos and Benno Evers.

Re: Review Request 71833: Created unix domain socket on agent startup.

> On Dec. 5, 2019, 3:12 p.m., Benjamin Bannier wrote: > > src/tests/cluster.cpp > > Lines 630 (patched) > > > > > > There is another, currently unhandled branch where > > `domain_socket_location` exists, but is not

Re: Review Request 71866: Added new chmod() function to stout.

> On Dec. 5, 2019, 12:43 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/chmod.hpp > > Lines 34 (patched) > > > > > > Let's return a `ErrnoError(errno)` here. > > > > Do we need to

Re: Review Request 71878: Added iteration support to stout's Path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71878/#review218978 --- 3rdparty/stout/include/stout/path.hpp Lines 388 (patched)

Re: Review Request 71882: Added a stout function to compute relative paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71882/#review218976 --- Fix it, then Ship it! 3rdparty/stout/include/stout/path.hpp

Re: Review Request 71881: Allowed specifying path separator in a `path::join` overload.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71881/#review218975 --- Ship it! Ship It! - Benno Evers On Dec. 5, 2019, 12:49

Re: Review Request 71880: Renamed stout's path-related absolute functions to is_absolute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71880/#review218974 --- Ship it! Ship It! - Benno Evers On Dec. 5, 2019, 12:48

Re: Review Request 71879: Renamed stout's path-related absolute functions to is_absolute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71879/#review218973 --- Fix it, then Ship it! 3rdparty/stout/include/stout/path.hpp