Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71965/#review219908 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.

> On March 8, 2020, 10:29 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > > Lines 743-748 (original), 758-762 (patched) > > > > > > I think this is for the case: Agent is

Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71965/#review219908 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 72222: Added tests for agent validation of shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7/#review219899 --- Bad patch! Reviews applied: [72161, 72162, 71858, 71884, 71885,

Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.

> On March 10, 2020, 1:06 p.m., Andrei Budnik wrote: > > src/master/validation.cpp > > Lines 1567 (patched) > > > > > > `if (limits.size() > cpuCount + memCount)` might be slightly easier to > > understand. Good

Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72216/ --- (Updated March 11, 2020, 7:10 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.

> On Янв. 13, 2020, 3:21 д.п., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > > Lines 779-785 (original), 797-803 (patched) > > > > > > This logic is correct for root container

[GitHub] [mesos] eLvErDe opened a new pull request #352: Typo in master.md

eLvErDe opened a new pull request #352: Typo in master.md URL: https://github.com/apache/mesos/pull/352 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: Review Request 72222: Added tests for agent validation of shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7/#review219886 --- Bad patch! Reviews applied: [72161, 72162, 71858, 71884, 71885,

Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72041/#review219885 --- Bad review! Reviews applied: [72041, 72040, 72211, 72027, 72022,

Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.

> On March 6, 2020, 4:06 p.m., Greg Mann wrote: > > src/docker/docker.cpp > > Lines 685 (patched) > > > > > > Is it not possible for us to handle infinite limits here? For infinite limits, we actually do not need

Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72022/ --- (Updated March 11, 2020, 5:41 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71944: Set container process's OOM score adjust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71944/ --- (Updated March 11, 2020, 5:40 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71952: Set resource limits when updating executor container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71952/#review219882 --- Fix it, then Ship it! src/slave/slave.hpp Lines 782-784

Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71950/#review219883 --- Could you update the description of this patch with a note that

Re: Review Request 71858: Set resource limits when launching executor container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71858/#review219881 --- Fix it, then Ship it! src/slave/slave.cpp Lines 191 (patched)

Re: Review Request 71951: Added resource limits into the `Task` protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71951/#review219880 --- Ship it! Ship It! - Greg Mann On March 9, 2020, 2:05 p.m.,

Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71943/#review219879 --- Fix it, then Ship it!

Re: Review Request 71955: Added a new parameter `resourceLimits` to the `createTask` methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71955/#review219878 --- src/tests/mesos.hpp Lines 105 (patched)