comment291900>
not is pending seems a safer choice
- Alexander Rukletsov
On Aug. 25, 2018, 10:12 a.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
--
On Aug. 14, 2018, 12:48 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68224/
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68537/#review208060
---
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 28, 2018, 2
19-20 (patched)
<https://reviews.apache.org/r/68473/#comment291803>
No, darling : )
src/master/readonly_handler.cpp
Lines 26-27 (patched)
<https://reviews.apache.org/r/68473/#comment291804>
Nope : )
- Alexander Rukletsov
On Aug. 27, 2018, 5:44 p.m., Benno
), 4043 (patched)
<https://reviews.apache.org/r/68440/#comment291802>
Extra blank line
- Alexander Rukletsov
On Aug. 28, 2018, 10:28 a.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68234/#review208039
---
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 27, 2018, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68235/#review208040
---
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 27, 2018, 2
ng? We can end up calling it twice, but I think it's fine?
- Alexander Rukletsov
On Aug. 24, 2018, 9:54 a.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
(patched)
<https://reviews.apache.org/r/68441/#comment291626>
// NOTE: Requests to this endpoint are batched.
Or maybe even better: group batched endpoints together.
- Alexander Rukletsov
On Aug. 22, 2018, 1:16 p.m., Benno Evers wrote:
>
> -
ests to this endpoint are batched.
- Alexander Rukletsov
On Aug. 22, 2018, 1:16 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/master/http.cpp
Line 3476 (original), 3487 (patched)
<https://reviews.apache.org/r/68321/#comment291623>
`return std::move(OK(...));`
- Alexander Rukletsov
On Aug. 21, 2018, 2:09 p.m., Benno Evers wrote:
>
> ---
NOTE: Requests to this endpoint are batched.
or grouping, see https://reviews.apache.org/r/68441/
- Alexander Rukletsov
On Aug. 22, 2018, 1:16 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail.
r/68473/#comment291648>
remove this line
src/master/readonly_handler.cpp
Lines 40 (patched)
<https://reviews.apache.org/r/68473/#comment291649>
remove this line
src/master/readonly_handler.cpp
Lines 91-92 (patched)
<https://reviews.apache.org/r/68473/#comment291650&g
x it while committing.
- Alexander Rukletsov
On Aug. 24, 2018, 5:38 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
> On Aug. 24, 2018, 7:52 a.m., Alexander Rukletsov wrote:
> > Maybe mention that folks should consider moving away from boost 1.53 in
> > `upgrades.md`?
>
> Benno Evers wrote:
> I dont think so, switching Boost version can be a huge pain, and if we
> get this f
-
On Aug. 23, 2018, 4:25 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68484/
> ---
>
> (Updated Aug. 23, 2018, 4:25 p
ent291410>
Please the same in slave.hpp
- Alexander Rukletsov
On Aug. 23, 2018, 4:25 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67575/#review207655
---
Ship it!
Ship It!
- Alexander Rukletsov
On June 15, 2018
(patched)
<https://reviews.apache.org/r/68321/#comment291086>
How about moving definitions on this class's methods to a separate file,
e.g., "readonly_handlers.cpp"?
- Alexander Rukletsov
On Aug. 17, 2018, 7:03 p.
), 2865 (patched)
<https://reviews.apache.org/r/68296/#comment291085>
I think we don't add a space between the variable name and c-tor
initialization list.
- Alexander Rukletsov
On Aug. 20, 2018, 2:11 p.m., Benno
src/master/master.hpp
Lines 1388-1389 (patched)
<https://reviews.apache.org/r/68343/#comment291083>
We have an unwritten agreement to add a black line between paragraphs in
comments.
- Alexander Rukletsov
On Aug. 2
> On Aug. 17, 2018, 8:37 p.m., Alexander Rukletsov wrote:
> > src/slave/containerizer/mesos/utils.cpp
> > Lines 81-83 (patched)
> > <https://reviews.apache.org/r/68257/diff/2/?file=2072515#file2072515line82>
> >
> > Let's unite `candidate` and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68345/#review207609
---
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 14, 2018, 4
tps://reviews.apache.org/r/68321/#comment291062>
Do you plan to augment this review or pull these additions into separate
review(s)?
- Alexander Rukletsov
On Aug. 17, 2018, 7:03 p.m., Benno Evers wrote:
>
> ---
> This is a
tps://reviews.apache.org/r/68343/#comment291061>
Indentation
- Alexander Rukletsov
On Aug. 17, 2018, 7:06 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
), 3035-3036 (patched)
<https://reviews.apache.org/r/68296/#comment291060>
These will become `const &`.
src/master/master.hpp
Lines 1871 (patched)
<https://reviews.apache.org/r/68296/#comment291059>
Remove this blank line
- Alexander Rukletsov
On Aug. 17, 2018,
che.org/r/68343/#comment291056>
corresponding what?
src/master/master.hpp
Lines 1398 (patched)
<https://reviews.apache.org/r/68343/#comment291058>
On the previous line please.
- Alexander Rukletsov
On Aug. 17, 2018, 7:06
erizer.cpp
Lines 1952 (patched)
<https://reviews.apache.org/r/68348/#comment290943>
s/enter task's/enter the task's
- Alexander Rukletsov
On Aug. 14, 2018, 5:26 p.m., Andrei Budnik wrote:
>
> ---
> This is an
without the subsequent
https://reviews.apache.org/r/68348 patch? If so, can you please update the
"testing done" section saying so?
- Alexander Rukletsov
On Aug. 17, 2018, 12:17 p.m., Andrei Budnik wrote:
>
> ---
> This
g/r/68257/#comment290938>
Let's unite `candidate` and `hasGrandchild` into `Option candidate;`
src/slave/containerizer/mesos/utils.cpp
Line 120 (original), 139 (patched)
<https://reviews.apache.org/r/68257/#comment290939>
This will then become `candidate.getOrElse(parent);`
- Alexa
parameters and less on
the boilerplate code.
Same for the snippet below.
- Alexander Rukletsov
On Aug. 7, 2018, 1:46 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
tps://reviews.apache.org/r/68321/#comment290801>
It can remain const!
- Alexander Rukletsov
On Aug. 13, 2018, 1:46 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
tps://reviews.apache.org/r/68296/#comment290799>
Let's keep associate.
- Alexander Rukletsov
On Aug. 14, 2018, 2:20 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To r
>
> (Updated Aug. 14, 2018, 2:20 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> In preparation for the changes in the subsequent commit,
> the serialization logic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68378/#review207408
---
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 16, 2018
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68342/#review207406
---
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 14, 2018, 2
<https://reviews.apache.org/r/68360/#comment290793>
`const`?
- Alexander Rukletsov
On Aug. 16, 2018, 12:33 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
: https://reviews.apache.org/r/68224/diff/3/
Changes: https://reviews.apache.org/r/68224/diff/2-3/
Testing
---
make check
Thanks,
Alexander Rukletsov
/libprocess/src/tests/statistics_tests.cpp
a2a780bf9de018c823b68aa48977fd9fd1b8a064
Diff: https://reviews.apache.org/r/68225/diff/3/
Changes: https://reviews.apache.org/r/68225/diff/2-3/
Testing
---
https://reviews.apache.org/r/68132/
Thanks,
Alexander Rukletsov
Line 4027 (original), 4091 (patched)
<https://reviews.apache.org/r/67960/#comment290541>
Same here.
3rdparty/libprocess/src/tests/http_tests.cpp
Lines 99-109 (original)
<https://reviews.apache.org/r/67960/#comment290542>
Doesn't it belong to https://reviews.apache.org/r/67
(patched)
<https://reviews.apache.org/r/67957/#comment290539>
Please swap the order.
- Alexander Rukletsov
On July 18, 2018, 1:19 a.m., Benjamin Hindman wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
547s | 373.609ms p25 | 3.262s | 3.588s
p50 | 3.189s | 831.261ms p50 | 5.052s | 4.253s
p75 | 5.346s | 2.215s p75 | 6.846s | 4.510s
p90 | 5.854s | 2.351s p90 | 7.883s | 4.705s
max | 7.237s | 2.444s max | 8.517s | 4.934s
Thanks,
Alexander Rukletsov
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68132/#review206879
---
On Aug. 7, 2018, 12:11 p.m., Alexander Rukletsov wrote:
>
>
as
> > `process::Milliseconds`?
Good idea.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68131/#review206877
---
On
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68224/#review206875
---
On Aug. 9, 2018, 2:20 p.m., Alexander Rukletsov wrote:
: https://reviews.apache.org/r/68224/diff/2/
Changes: https://reviews.apache.org/r/68224/diff/1-2/
Testing
---
make check
Thanks,
Alexander Rukletsov
he renaming?
Good catch!
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68131/#review206962
---
On Aug. 9, 201
/
Changes: https://reviews.apache.org/r/68131/diff/2-3/
Testing
---
See https://reviews.apache.org/r/68132/
Thanks,
Alexander Rukletsov
this patch?
Added a TODO in "libprocess/src/metrics/metrics.cpp".
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68225/#review206891
----
/libprocess/src/tests/statistics_tests.cpp
a2a780bf9de018c823b68aa48977fd9fd1b8a064
Diff: https://reviews.apache.org/r/68225/diff/2/
Changes: https://reviews.apache.org/r/68225/diff/1-2/
Testing
---
https://reviews.apache.org/r/68132/
Thanks,
Alexander Rukletsov
b6d6dc7c1752491e2da854018966374b624d6682
Diff: https://reviews.apache.org/r/68131/diff/2/
Testing
---
See https://reviews.apache.org/r/68132/
Thanks,
Alexander Rukletsov
to measure the responsiveness
of the master actor and not the performance of the '/state' endpoint.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68131/#review206877
--
ter(values), accessor);
return from(values);
}
```
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68224/#review206961
-------
On Aug. 6
rs.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68131/#review206962
---
On Aug. 6, 2018, 10:30 a.m., Alexander Rukletsov w
---
On Aug. 7, 2018, 1:46 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68257/
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68276/#review207016
---
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 9, 2018, 9
| 2.820s
p25 | 1.547s | 373.609ms p25 | 3.262s | 3.588s
p50 | 3.189s | 831.261ms p50 | 5.052s | 4.253s
p75 | 5.346s | 2.215s p75 | 6.846s | 4.510s
p90 | 5.854s | 2.351s p90 | 7.883s | 4.705s
max | 7.237s | 2.444s max | 8.517s | 4.934s
Thanks,
Alexander Rukletsov
| 2.820s
p25 | 1.547s | 373.609ms p25 | 3.262s | 3.588s
p50 | 3.189s | 831.261ms p50 | 5.052s | 4.253s
p75 | 5.346s | 2.215s p75 | 6.846s | 4.510s
p90 | 5.854s | 2.351s p90 | 7.883s | 4.705s
max | 7.237s | 2.444s max | 8.517s | 4.934s
Thanks,
Alexander Rukletsov
3.609ms p25 | 3.262s | 3.588s
p50 | 3.189s | 831.261ms p50 | 5.052s | 4.253s
p75 | 5.346s | 2.215s p75 | 6.846s | 4.510s
p90 | 5.854s | 2.351s p90 | 7.883s | 4.705s
max | 7.237s | 2.444s max | 8.517s | 4.934s
Thanks,
Alexander Rukletsov
orry about, IMO.
* Will do, stay tuned.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68132/#review206711
---
On Aug. 6, 2018, 10:30 a.m., Ale
al
Launching 10 '/state' requests in background
Launching 10 '/flags' requests
'/flags' response on average took 1.973573ms, 10 responses are in [1.221193ms,
2.694713ms]
'/state' response on average took 113.331551ms, 10 responses are in
[102.593397ms, 1
/
Testing
---
make check
Thanks,
Alexander Rukletsov
/
Changes: https://reviews.apache.org/r/68131/diff/1-2/
Testing
---
See https://reviews.apache.org/r/68132/
Thanks,
Alexander Rukletsov
/
Testing
---
https://reviews.apache.org/r/68132/
Thanks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68227/#review206873
---
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 6, 2018, 10
struct instead of copying it?
Not sure I understand which struct you suggest to move.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68132/#review206714
---
the idea is to have them match
> > the path, so "/state" -> Http::state seems ideal as is.
>
> Alexander Rukletsov wrote:
> No : ). I would like readers to understand that this endpoint is somewhat
> different from the rest. Why not reflecting it in the nam
));
> > }
> > process::await(responses).await();
> > ```
> >
> > This lets us keep the response lambda agnostic of batching and we could
> > more cleanly move it up in the future.
The reason I did so was to avoid carrying around a heavy `
.593397ms, 142.028555ms]
Test setup: 1000 agents with a total of 10 running tasks and 10
completed tasks; 10 '/state' and '/flags' requests will be sent with 200ms
interval
Launching 10 '/state' requests in background
Launching 10 '/flags' requests
'/flags' response on average took 1.475842691secs, 10 responses are in
[2.437217ms, 3.815589561secs]
'/state' response on average took 4.742303751secs, 10 responses are in
[4.047655443secs, 6.00752698secs]
```
Thanks,
Alexander Rukletsov
n [1.221193ms,
2.694713ms]
'/state' response on average took 113.331551ms, 10 responses are in
[102.593397ms, 142.028555ms]
Test setup: 1000 agents with a total of 10 running tasks and 10
completed tasks; 10 '/state' and '/flags' requests will be sent with 200ms
interval
Launching 10 '/state' requests in background
Launching 10 '/flags' requests
'/flags' response on average took 1.475842691secs, 10 responses are in
[2.437217ms, 3.815589561secs]
'/state' response on average took 4.742303751secs, 10 responses are in
[4.047655443secs, 6.00752698secs]
```
Thanks,
Alexander Rukletsov
org/r/68141/#comment289878>
Please tabs in Makefile.
- Alexander Rukletsov
On Aug. 2, 2018, 1:23 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/#review206797
---
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 2, 2018, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68166/#review206796
---
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 2, 2018, 12
ter.cpp" to
"framework.cpp"?
- Alexander Rukletsov
On Aug. 2, 2018, 10:26 a.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To
age took 113.331551ms, 10 responses are in
[102.593397ms, 142.028555ms]
Test setup: 1000 agents with a total of 10 running tasks and 10
completed tasks; 10 '/state' and '/flags' requests will be sent with 200ms
interval
Launching 10 '/state' requests in background
Launching 10 '/flags' requests
'/flags' response on average took 1.475842691secs, 10 responses are in
[2.437217ms, 3.815589561secs]
'/state' response on average took 4.742303751secs, 10 responses are in
[4.047655443secs, 6.00752698secs]
```
Thanks,
Alexander Rukletsov
;/state' requests in background
Launching 10 '/flags' requests
'/flags' response on average took 1.973573ms, 10 responses are in [1.221193ms,
2.694713ms]
'/state' response on average took 113.331551ms, 10 responses are in
[102.593397ms, 142.028555ms]
Test setup: 1000 agents with a total of 10 running tasks and 10
completed tasks; 10 '/state' and '/flags' requests will be sent with 200ms
interval
Launching 10 '/state' requests in background
Launching 10 '/flags' requests
'/flags' response on average took 1.475842691secs, 10 responses are in
[2.437217ms, 3.815589561secs]
'/state' response on average took 4.742303751secs, 10 responses are in
[4.047655443secs, 6.00752698secs]
```
Thanks,
Alexander Rukletsov
te' and '/flags' requests will be sent with 200ms
interval
Launching 10 '/state' requests in background
Launching 10 '/flags' requests
'/flags' response on average took 5.439950928secs, 10 responses are in
[3.246906ms, 9.343994388secs]
'/state' response on average took 16.764607823secs, 10 responses are in
[4.980333091secs, 18.461983916secs]
```
Thanks,
Alexander Rukletsov
e sent with 200ms
interval
Launching 10 '/state' requests in background
Launching 10 '/flags' requests
'/flags' response on average took 5.439950928secs, 10 responses are in
[3.246906ms, 9.343994388secs]
'/state' response on average took 16.764607823secs, 10 responses are in
[4.980333091secs, 18.461983916secs]
```
Thanks,
Alexander Rukletsov
/68132/
Thanks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68082/#review206544
---
Ship it!
Ship It!
- Alexander Rukletsov
On July 27, 2018, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68061/#review206507
---
Ship it!
Ship It!
- Alexander Rukletsov
On July 26, 2018
> On July 24, 2018, 5:41 p.m., Alexander Rukletsov wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 37-43 (original), 37-44 (patched)
> > <https://reviews.apache.org/r/67987/diff/3/?file=2063101#file2063101line37>
> >
> > Can you please sort the list?
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67992/#review206415
---
Ship it!
Ship It!
- Alexander Rukletsov
On July 20, 2018, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67993/#review206411
---
Ship it!
Ship It!
- Alexander Rukletsov
On July 20, 2018, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67991/#review206409
---
Ship it!
Ship It!
- Alexander Rukletsov
On July 20, 2018, 3
? It is unfortunate we do
such a change without notifying people on the user and dev lists with enough
time buffer, maybe you can do it right after the chain lands so that folks can
prepare to the 1.7 release?
- Alexander Rukletsov
On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote
g/r/67988/#comment289345>
Do we still want / need a `CHECK` then?
3rdparty/stout/include/stout/jsonify.hpp
Line 375 (original), 282-284 (patched)
<https://reviews.apache.org/r/67988/#comment289346>
ditto
- Alexander Rukletsov
On July 20, 2018, 3:38 a.m., Ben
isit:
> https://reviews.apache.org/r/67987/
> ---
>
> (Updated July 20, 2018, 3:38 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benno Evers, and James Peach.
>
>
> Bugs: MESOS-9092
> https://issues.apache.org/jira/browse/MESOS-9092
>
>
> Repository: me
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67986/#review206397
---
Ship it!
Ship It!
- Alexander Rukletsov
On July 20, 2018, 3
org/r/67985/#comment289330>
Not your fault, but maybe you can fix it before adding more
- Alexander Rukletsov
On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67924/#review206380
---
Ship it!
Ship It!
- Alexander Rukletsov
On July 16, 2018
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67925/#review206379
---
Ship it!
Ship It!
- Alexander Rukletsov
On July 16, 2018
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67903/#review206377
---
Ship it!
Ship It!
- Alexander Rukletsov
On July 13, 2018, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67905/#review206378
---
Ship it!
Ship It!
- Alexander Rukletsov
On July 13, 2018, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67904/#review206376
---
Ship it!
Ship It!
- Alexander Rukletsov
On July 13, 2018, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67998/#review206374
---
Ship it!
Ship It!
- Alexander Rukletsov
On July 20, 2018
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67963/#review206194
---
Ship it!
Ship It!
- Alexander Rukletsov
On July 18, 2018, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67893/#review205999
---
Ship it!
Ship It!
- Alexander Rukletsov
On July 12, 2018, 7
://reviews.apache.org/r/67840/diff/1/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
---
Updated committer candidate guidelines.
Diffs
-
docs/committer-candidate-guidelines.md
bf67473445d135800d5b54587f2fb5513ca6b9e4
Diff: https://reviews.apache.org/r/67841/diff/1/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
101 - 200 of 3026 matches
Mail list logo
