Re: Review Request 57731: Fixed a test in MasterAuthorizationTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57731/#review172738 --- Ship it! Ship It! - Anindya Sinha On March 17, 2017, 3:55

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

3eb7afe3de8e72ffb6502dfe12ef37ccd4ca2125 Diff: https://reviews.apache.org/r/57964/diff/3/ Changes: https://reviews.apache.org/r/57964/diff/2-3/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

Yes, ofcourse. Copy and paste issue. Fixed now. - Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/#review172689 ------- On

Re: Review Request 57963: Metrics for used resources should incorporate shared resources.

: https://reviews.apache.org/r/57963/diff/2-3/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 53840: Metric in the allocator to track latency in running allocations.

t it? Why is a simple > > counter of allocator runs not sufficient? > > Anindya Sinha wrote: > So as to determine how frequently (or infrequently) allocation cycles are > being run by the allocator. The counters provide the current count of > allocation runs. > > James Peach

Re: Review Request 53840: Metric in the allocator to track latency in running allocations.

All tests passed. Thanks, Anindya Sinha

Re: Review Request 53840: Metric in the allocator to track latency between allocation cycles.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53840/#review172526 --- On April 19, 2017, 8:51 p.m., Anindya Sinha wrote: > > --- >

Re: Review Request 58512: Avoid a crash in HTTP decoder.

Thanks, Anindya Sinha

Re: Review Request 58580: Mark decoder as failed when http parsing failed for any reason.

: https://reviews.apache.org/r/58580/diff/2/ Changes: https://reviews.apache.org/r/58580/diff/1-2/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 58580: Mark decoder as failed when http parsing failed for any reason.

--- Mark decoder as failed when http parsing failed for any reason. Diffs - 3rdparty/libprocess/src/decoder.hpp 4c779d42548958e610142438a57529ccb4478053 Diff: https://reviews.apache.org/r/58580/diff/1/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 58512: Avoid a crash in HTTP decoder.

b4478053 3rdparty/libprocess/src/tests/decoder_tests.cpp c0efef571815752cc28e5a0dc7a07adc82bb31d5 Diff: https://reviews.apache.org/r/58512/diff/3/ Changes: https://reviews.apache.org/r/58512/diff/2-3/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 58512: Avoid a crash in HTTP decoder.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58512/#review172504 ------- On April 19, 2017, 4:02 p.m., Anindya Sinha wrote: > > -

Re: Review Request 58487: Fix allocation quantities when shared resources are removed.

see if a re-run of tests is triggered? - Anindya Sinha On April 19, 2017, 2:50 a.m., Anindya Sinha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 58512: Avoid a crash in HTTP decoder.

iews.apache.org/r/58512/#review172304 --- On April 19, 2017, 4:02 p.m., Anindya Sinha wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 58512: Avoid a crash in HTTP decoder.

Thanks, Anindya Sinha

Re: Review Request 58487: Fix allocation quantities when shared resources are removed.

/diff/2/ Changes: https://reviews.apache.org/r/58487/diff/1-2/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 58485: Avoid a corruption while rescinding offers.

/persistent_volume_tests.cpp 3eb7afe3de8e72ffb6502dfe12ef37ccd4ca2125 Diff: https://reviews.apache.org/r/58485/diff/2/ Changes: https://reviews.apache.org/r/58485/diff/1-2/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 58486: Fixed a race in `updateAllocation()` on DESTORY of a shared volume.

://reviews.apache.org/r/58486/diff/2/ Changes: https://reviews.apache.org/r/58486/diff/1-2/ Testing --- Tests passed. Thanks, Anindya Sinha

Review Request 58512: Avoid a crash in HTTP decoder.

Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 58486: Fixed a race in `updateAllocation()` on DESTORY of a shared volume.

passed. Thanks, Anindya Sinha

Review Request 58487: Fix allocation quantities when shared resources are removed.

, Anindya Sinha

Review Request 58485: Avoid a corruption while rescinding offers.

/diff/1/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 57815: Added `suppress` field in SUBSCRIBE.

ty, we suppress for all roles of the framework. Thoughts? - Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57815/#review172115 ----------

Re: Review Request 57817: Suppress offers for frameworks on registration.

7;s not clear to me what is the difference between > > "active" and "offersSuppressed" booleans as far as the allocator is > > concerned. > > > > Thoughts? > > Anindya Sinha wrote: > I agree that the 2 APIs are very similar and I agree we can also

Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

. Thanks, Anindya Sinha

Re: Review Request 57817: Suppress offers for frameworks on registration.

, Anindya Sinha

Re: Review Request 57815: Added `suppress` field in SUBSCRIBE.

/scheduler.proto 00a54eceb435de8e8fea3ccab285f39ed13c6fee Diff: https://reviews.apache.org/r/57815/diff/3/ Changes: https://reviews.apache.org/r/57815/diff/2-3/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57816: Add a scheduler flag `suppress_offers_on_registration`.

/ Changes: https://reviews.apache.org/r/57816/diff/3-4/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57817: Suppress offers for frameworks on registration.

w what you think and I can adapt accordingly. - Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/#review171630 --- O

Re: Review Request 57817: Suppress offers for frameworks on registration.

f0bca1d9e03013ce35215b0ffa6b50b38972dc0c src/tests/slave_recovery_tests.cpp 53f33a2b0411c8158326074ce043c7b1dbeef5b4 Diff: https://reviews.apache.org/r/57817/diff/4/ Changes: https://reviews.apache.org/r/57817/diff/3-4/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

d1828eb42e0aedc9330c3786bbd9bb63aa42a64e src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db Diff: https://reviews.apache.org/r/57818/diff/4/ Changes: https://reviews.apache.org/r/57818/diff/3-4/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57815: Added `suppress_offers` field in SUBSCRIBE.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57815/#review171623 ------- On April 11, 2017, 11:09 p.m., Anindya Sinha wrote: > >

Re: Review Request 57815: Added `suppress_offers` field in SUBSCRIBE.

/diff/2/ Changes: https://reviews.apache.org/r/57815/diff/1-2/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57816: Add a scheduler flag `suppress_offers_on_registration`.

ef73c1dccfd736b79f40a057951f022df7f60644 Diff: https://reviews.apache.org/r/57816/diff/3/ Changes: https://reviews.apache.org/r/57816/diff/2-3/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

d1828eb42e0aedc9330c3786bbd9bb63aa42a64e src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db Diff: https://reviews.apache.org/r/57818/diff/3/ Changes: https://reviews.apache.org/r/57818/diff/2-3/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57817: Suppress offers for frameworks on registration.

eviews.apache.org/r/57817/#review170997 --- On April 4, 2017, 10:37 p.m., Anindya Sinha wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 57817: Suppress offers for frameworks on registration.

, Anindya Sinha

Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

d1828eb42e0aedc9330c3786bbd9bb63aa42a64e src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db Diff: https://reviews.apache.org/r/57818/diff/2/ Changes: https://reviews.apache.org/r/57818/diff/1-2/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57817: Suppress offers for frameworks on registration.

f0bca1d9e03013ce35215b0ffa6b50b38972dc0c src/tests/slave_recovery_tests.cpp 53f33a2b0411c8158326074ce043c7b1dbeef5b4 Diff: https://reviews.apache.org/r/57817/diff/2/ Changes: https://reviews.apache.org/r/57817/diff/1-2/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57816: Add a scheduler flag `offers_suppressed_on_register`.

something > > similar. The flag is for suppressing offers at subscription time, and I > > find `offers_suppressed` a bit too generic and oopen to interpretation. > > Anindya Sinha wrote: > Agreed. How about `offers_originally_suppressed` or > `offers_suppressed_on_register`

Re: Review Request 57816: Add a scheduler flag `offers_suppressed_on_register`.

/r/57816/diff/2/ Changes: https://reviews.apache.org/r/57816/diff/1-2/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57816: Add a scheduler flag `offers_suppressed`.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57816/#review170767 ------- On March 31, 2017, 8:20 p.m., Anindya Sinha wrote: > > ---

Re: Review Request 57963: Metrics for used resources should incorporate shared resources.

Here and below. Sure. Updated. - Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57963/#review170213 --- On March 27, 2017, 10

Re: Review Request 57963: Metrics for used resources should incorporate shared resources.

: https://reviews.apache.org/r/57963/diff/1-2/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

3eb7afe3de8e72ffb6502dfe12ef37ccd4ca2125 Diff: https://reviews.apache.org/r/57964/diff/2/ Changes: https://reviews.apache.org/r/57964/diff/1-2/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 57964: Added a test to verify metrics when shared resources are present.

/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 57963: Metrics for used resources should incorporate shared resources.

/_revocable_used` Diffs - src/master/master.cpp 43e9d26167c1f405329ea05224c22e7b8c65315f src/slave/slave.cpp c8479d7e8eb915284f0ea8cf75f47acd679dee7e Diff: https://reviews.apache.org/r/57963/diff/1/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 57935: Added a check to ensure scalar quantities match in `DRFSorter::update`.

unchanged. Diffs - src/master/allocator/sorter/drf/sorter.cpp ed54680cecb637931fc344fbcf8fd3b14cc24295 Diff: https://reviews.apache.org/r/57935/diff/1/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

65259b47ec1a2094b23ff448370d30122fd218ca Diff: https://reviews.apache.org/r/57818/diff/1/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 57817: Suppress offers for frameworks on registration.

09bfa75dd03fa19fba2c9dee15d29d703ca02f29 Diff: https://reviews.apache.org/r/57817/diff/1/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 57816: Add a scheduler flag `offers_suppressed`.

/flags.hpp d19d20bad7dba48c8792783c73115affa1430cbe src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644 Diff: https://reviews.apache.org/r/57816/diff/1/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 57815: Added `offers_suppressed` field in SUBSCRIBE.

/scheduler/scheduler.proto 00a54eceb435de8e8fea3ccab285f39ed13c6fee Diff: https://reviews.apache.org/r/57815/diff/1/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 57739: Completed frameworks should be tracked based on source.

/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 57712: No need to set `agent_subsystems` for all the slave tests.

/slave_recovery_tests.cpp e6b2bdd4e385208eea7dc513421024242b9efc1c Diff: https://reviews.apache.org/r/57712/diff/1/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57710: Added `register_agents` to authorization.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57710/#review169225 --- Ship it! Ship It! - Anindya Sinha On March 16, 2017, 11:07

Re: Review Request 57535: Applied RegisterAgent ACL to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57535/#review169030 --- Ship it! Ship It! - Anindya Sinha On March 15, 2017, 1:09

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review169029 --- Ship it! Ship It! - Anindya Sinha On March 15, 2017, 12:40

Re: Review Request 57535: Applied RegisterAgent ACL to the master.

r file. s/authorizeSlave/authorizeAgent? src/master/master.cpp Line 5372 (original), 5446 (patched) <https://reviews.apache.org/r/57535/#comment241275> nit: Is there a specific reason for the change here (and in reregisterSlave) from `from` to `pid`? - Anindya Sinha On March 14, 2017,

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

ent241243> `remove_nested_containers` uses 33, so `register_agents` should be 34. - Anindya Sinha On March 14, 2017, 6:17 p.m., Jiang Yan Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710 Diff: https://reviews.apache.org/r/55888/diff/11/ Changes: https://reviews.apache.org/r/55888/diff/10-11/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

say we should consider refactoring it out? Added the TODO in `Slave::_run()`. - Anindya ----------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review168693 -

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

https://reviews.apache.org/r/55887/diff/11/ Changes: https://reviews.apache.org/r/55887/diff/10-11/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710 Diff: https://reviews.apache.org/r/55888/diff/10/ Changes: https://reviews.apache.org/r/55888/diff/9-10/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

https://reviews.apache.org/r/55887/diff/10/ Changes: https://reviews.apache.org/r/55887/diff/9-10/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

a --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review168570 --- On March 10, 2017, 10:15 p.m., Anindya Sinha wrote: >

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

61c44460eb79931dd77c5100eb33a31a182c1710 Diff: https://reviews.apache.org/r/55888/diff/9/ Changes: https://reviews.apache.org/r/55888/diff/8-9/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

iff/9/ Changes: https://reviews.apache.org/r/55887/diff/8-9/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 53840: Metric in the allocator to track latency between allocation cycles.

ache.org/r/53840/diff/3/ Changes: https://reviews.apache.org/r/53840/diff/2-3/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 53842: Add role specific metrics for sorting runs.

/3/ Changes: https://reviews.apache.org/r/53842/diff/2-3/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 53841: Added metrics for sorting of the sorters in the allocator.

--- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710 Diff: https://reviews.apache.org/r/55888/diff/8/ Changes: https://reviews.apache.org/r/55888/diff/7-8/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

e.cpp 4319f841fbdc7ad39eb60eb52ae2a764b133cfbd Diff: https://reviews.apache.org/r/55887/diff/8/ Changes: https://reviews.apache.org/r/55887/diff/7-8/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

; Nevertheless we could check with the @anand and @vinod who last changed > > this. > > Anindya Sinha wrote: > I reinstated the original behavior. We can followup with @anand and > @vinod later. > > Jiang Yan Xu wrote: > So I checked with @anandm on s

Re: Review Request 53840: Added a metric in the allocator to track previous allocation cycle.

- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

vior. We can followup if we need to change the task state in such case separately. - Anindya Sinha On March 3, 2017, 8:08 p.m., Anindya Sinha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710 Diff: https://reviews.apache.org/r/55888/diff/7/ Changes: https://reviews.apache.org/r/55888/diff/6-7/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

org/r/55887/diff/7/ Changes: https://reviews.apache.org/r/55887/diff/6-7/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review167654 --- On March 1, 2017, 4:15 p.m., Anindya Sinha wrote: > >

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

, Anindya Sinha

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review167662 --- On March 2, 2017, 8:36 p.m., Anindya Sinha wrote: > > --- > This i

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

, Anindya Sinha

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

-3/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710 Diff: https://reviews.apache.org/r/55888/diff/6/ Changes: https://reviews.apache.org/r/55888/diff/5-6/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

s.cpp 3731c7607d5e49f3000c4863b1999851fac45705 Diff: https://reviews.apache.org/r/55887/diff/6/ Changes: https://reviews.apache.org/r/55887/diff/5-6/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57012: Added unit tests for SHARE and UNSHARE offer operations.

/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57011: Add support for SHARE and UNSHARE operations.

fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a src/v1/resources.cpp e47c4d49e69b915d37e40a91fef69f75dff52463 Diff: https://reviews.apache.org/r/57011/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 57010: Added protobuf changes for `SHARE` and `UNSHARE` offer operations.

/resources.cpp e47c4d49e69b915d37e40a91fef69f75dff52463 Diff: https://reviews.apache.org/r/57010/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 53666: Refactor cgroups cleanup to allow cleanup to continue on an error.

/containerizer/mesos/linux_launcher.cpp a3409dc64435e002072b9b458a5fda0564214f28 Diff: https://reviews.apache.org/r/53666/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

) - src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710 Diff: https://reviews.apache.org/r/55888/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

https://reviews.apache.org/r/55887/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

> On Feb. 20, 2017, 7:07 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, line 1722 > > <https://reviews.apache.org/r/55887/diff/3/?file=1627222#file1627222line1722> > > > > Why not TASK_ERROR? > > Anindya Sinha wrote: > AFAICT, `TASK_ERROR` i

Re: Review Request 49571: Added a benchmark test for allocations.

allocate() took 1.517221secs to make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

Re: Review Request 53839: Added a metric in the master to track sending of previous offer.

etrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f src/tests/master_tests.cpp 357a9a47ef87be6cbc4256d8afabe63cd41b1ea1 Diff: https://reviews.apache.org/r/53839/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 53840: Added a metric in the allocator to track previous allocation cycle.

7ae87c97b3 src/master/allocator/mesos/metrics.cpp ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1 src/tests/hierarchical_allocator_tests.cpp 5441fa9d1fad1ca7819038db49c6d88e40571e4a Diff: https://reviews.apache.org/r/53840/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 53842: Add role specific metrics for sorting runs.

--- All tests passed. Thanks, Anindya Sinha

Re: Review Request 53841: Added metrics for sorting of the sorters in the allocator.

5441fa9d1fad1ca7819038db49c6d88e40571e4a Diff: https://reviews.apache.org/r/53841/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

) - src/slave/main.cpp a124d2e0cfa3e39e2400183f9523486196b9816d src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a Diff: https://reviews.apache.org/r/53369/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 57011: Add support for SHARE and UNSHARE operations.

e47c4d49e69b915d37e40a91fef69f75dff52463 Diff: https://reviews.apache.org/r/57011/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 57012: Added unit tests for SHARE and UNSHARE offer operations.

45254739e2a62fed7008ceada7a8f64bb9ee4e31 src/tests/mesos.hpp b450a04dfbf3bbeeb6b605fb78097dca390cbdbe src/tests/persistent_volume_tests.cpp 7ac82862363af7a33a52b8570149cf2237b3519b Diff: https://reviews.apache.org/r/57012/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 57010: Added protobuf changes for `SHARE` and `UNSHARE` offer operations.

://reviews.apache.org/r/57010/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

<    1   2   3   4   5   6   7   8   >