e updated version should solve the issues raised.
- Armand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67055/#review202991
-----------
On May 14, 2018, 10:22 a.m., Armand Grillet wrote:
>
> --
ded
congratulations :)
Total errors found: 0
```
As we can see, the number of errors found by cpplint is the same as before.
I have also used cpplint separately by running `python3 support/cpplint` on a
few C++ files to see that it was running as expected.
Thanks,
Armand Grillet
iff, and then
> > when it's given ship-its, we take the finished ported scripts and put them
> > here (trusting they're the same as the reviewed ones).
/r/67101/
- Armand
---
This is an automatically generated e-mai
/
Testing
---
Tested manually by changing my environment variable and seeing the output of
the scripts.
Thanks,
Armand Grillet
uot;)` but detecting all of them requires to use the scripts.
Please do so and create issues.
Thanks,
Armand Grillet
` on a few C++ files to see that it was running as
expected.
Thanks,
Armand Grillet
need to add
`.decode("utf-8")` but detecting all of them requires to use the scripts.
Please do so and create issues.
Thanks,
Armand Grillet
n see, the number of errors found by cpplint is the same as before.
I have also used cpplint separately bu running `python3
support/python3/cpplint` on a few C++ files to see that it was running as
expected.
Thanks,
Armand Grillet
d'.: """
python version compatibility code
"""
Traceback (most recent call last):
File "./support/mesos-style.py", line 517, in
PY_ERRORS = PY_LINTER.main(sys.argv[1:])
File "./support/mesos-style.py", line 443, in main
return super(PyLinter, self).main(modified_files)
File "./support/mesos-style.py", line 207, in main
license_errors = self.check_license_header(filtered_candidates_set)
File "./support/mesos-style.py", line 107, in check_license_header
head = "".join([next(source_file) for _ in xrange(3)])
StopIteration
```
After change:
```
Checking 47 Python files
py27-lint: commands succeeded
congratulations :)
py27-lint: commands succeeded
congratulations :)
```
Thanks,
Armand Grillet
---
Removed pip install requirements-test.in in new CLI bootstrap script.
Diffs
-
src/python/cli_new/bootstrap 87ac3cae790144fe642c9eb86106b05d60a9d14d
Diff: https://reviews.apache.org/r/67032/diff/1/
Testing
---
Thanks,
Armand Grillet
://reviews.apache.org/r/67008/diff/1/
Testing
---
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67004/#review202630
---
Ship it!
Ship It!
- Armand Grillet
On May 8, 2018, 12:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66868/#review202113
---
Ship it!
Ship It!
- Armand Grillet
On April 30, 2018, 9:14
7;
--work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
Also ran `mesos-cli-tests` successfully.
Thanks,
Armand Grillet
Diff: https://reviews.apache.org/r/66657/diff/1/
Testing
---
Removed `~/.mesos/config.toml` and ran `mesos config show`.
Thanks,
Armand Grillet
atch. This will also be done to use PyInstaller.
Diffs (updated)
-
src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a
Diff: https://reviews.apache.org/r/65705/diff/5/
Changes: https://reviews.apache.org/r/65705/diff/4-5/
Testing
---
Tested on internal CI.
Thank
ile
taskInteracts with the tasks running in a Mesos cluster
See 'mesos help ' for more information on a specific command.
```
Thanks,
Armand Grillet
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66554/#review200941
-----------
On April 11, 2018, 3:23 p.m., Armand Grillet wrote:
>
> ---
> Thi
-CREATION
src/webui/index.html 149d765429dc2211875783129da6c6b101f38ecf
support/.eslintrc.js cd23ddebd2b40f795fa297e6decacada356a01f8
Diff: https://reviews.apache.org/r/66554/diff/1/
Testing
---
```
GTEST_FILTER="" make check -j4
```
And tested manually.
Thanks,
Armand Grillet
/static/offers.html
src/webui/master/static/pailer.html 6710b7d4405d66171d07e88112c71bb4a30b29d4
src/webui/master/static/roles.html
Diff: https://reviews.apache.org/r/66553/diff/1/
Testing
---
```
GTEST_FILTER="" make check -j4
```
And tested manually.
Thanks,
Armand Grillet
(patched)
<https://reviews.apache.org/r/64970/#comment281419>
As this is here, the line `pylint==1.6.4` in support/pip-requirements.txt
should be removed.
- Armand Grillet
On March 14, 2018, 3:05 p.m., Eric Chung wrote:
>
> ---
"gru1.hw.ca1.mesosphere.com",
"ip": "192.99.40.208",
"port": 5061
},
"capabilities": [
{
"type": "AGENT_UPDATE"
}
]
},
"elected_time": {
"nanoseconds": 1522078049390997760
}
}
}
```
Thanks,
Armand Grillet
s (updated)
-
src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a
Diff: https://reviews.apache.org/r/65705/diff/3/
Changes: https://reviews.apache.org/r/65705/diff/2-3/
Testing
---
Tested on internal CI.
Thanks,
Armand Grillet
d out of 1
```
Checked that the the CLI tests were run, that the content of the directory
`build/src/cli` was as expected, and that `build/src/mesos` was correctly
running.
Thanks,
Armand Grillet
Interacts with the tasks running in a Mesos cluster
See 'mesos help ' for more information on a specific command.
```
Thanks,
Armand Grillet
---
Added licenses for third party JS libraries used by Web UI.
Diffs
-
LICENSE 17f97049d3a3aeff3d09812e22ebb620bf4ed61c
Diff: https://reviews.apache.org/r/66257/diff/1/
Testing
---
None. No need to add a license for Angular route as it is part of Angular.
Thanks,
Armand
showing any missing source files when
using it.
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65906/#review198992
---
Ship it!
Ship It!
- Armand Grillet
On March 10, 2018, 5:49
kill: https://github.com/middleman/middleman/issues/1097
- Armand Grillet
On March 10, 2018, 5:49 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
/`ruby versions`/`ruby
version` in the second paragraph of the commit message.
- Armand Grillet
On March 10, 2018, 5:49 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
:
```
Fetching gem metadata from https://rubygems.org/
nokogiri-1.8.2 requires ruby version >= 2.1.0, which is incompatible with the
current version, ruby 2.0.0p648
```
The issue does not not exist using `master` and is thus likely introduced by
this patch.
- Armand Grillet
On March 5, 2018
66a4f2955a88fa44c3e5c717e9ce6b680050cc34
Diff: https://reviews.apache.org/r/65928/diff/1/
Testing
---
Manual testing.
Thanks,
Armand Grillet
, visit:
https://reviews.apache.org/r/64211/#review198482
---
On March 2, 2018, 8:12 a.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail. T
d out of 1
```
Checked that the the CLI tests were run, that the content of the directory
`build/src/cli` was as expected, and that `build/src/mesos` was correctly
running.
Thanks,
Armand Grillet
The group columns cannot be ordered as they have sub-columns, this is expected.
Thanks,
Armand Grillet
78616>
Not sure if adding this method is necessary (specially in that patch) but
it does not hurt.
- Armand Grillet
On Feb. 23, 2018, 7:58 a.m., Eric Chung wrote:
>
> ---
> This is an
cannot be ordered as they have sub-columns, this is expected.
Thanks,
Armand Grillet
Armand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65246/#review198345
---
On Feb. 27, 2018, 11:40 p.m., Armand Grillet wrote:
>
log_dir='/tmp/agent1-log'
```
Tested the download and streaming features on the home and agents Web UI
endpoints, from both `http://localhost:5061/` and `http://localhost:5062/`.
New UI (masters):
New UI (agents):
Thanks,
Armand Grillet
(no file extension, too much information in the name).
- Armand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65246/#review197631
---------
):
New UI (agents):
Thanks,
Armand Grillet
d out of 1
```
Checked that the the CLI tests were run, that the content of the directory
`build/src/cli` was as expected, and that `build/src/mesos` was correctly
running.
Thanks,
Armand Grillet
To reply, visit:
https://reviews.apache.org/r/64211/#review197774
-------
On Feb. 21, 2018, 9:58 a.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail.
led out of 1
```
Checked that the the CLI tests were run, that the content of the directory
`build/src/cli` was as expected, and that `build/src/mesos` was correctly
running.
Thanks,
Armand Grillet
Start 4: CLITests
1/1 Test #4: CLITests . Passed3.63 sec
100% tests passed, 0 tests failed out of 1
```
Checked that the the CLI tests were run, that the content of the directory
`build/src/cli` was as expected, and that `build/src/mesos` was correctly
running.
Thank
Testing
---
Tested on internal CI.
Thanks,
Armand Grillet
CLITests
1/1 Test #4: CLITests . Passed3.63 sec
100% tests passed, 0 tests failed out of 1
```
Checked that the the CLI tests were run, that the content of the directory
`build/src/cli` was as expected, and that `build/src/mesos` was correctly
running.
Thank
s with the Mesos agents
config Interacts with the Mesos CLI configuration file
taskInteracts with the tasks running in a Mesos cluster
See 'mesos help ' for more information on a specific command.
```
Thanks,
Armand Grillet
.
Diffs
-
src/python/cli_new/lib/cli/tests/base.py
33c67c1161d9c9fd57aa5f44b04746e3740e1dd9
Diff: https://reviews.apache.org/r/65655/diff/1/
Testing
---
Checked that `mesos-cli-tests` was working as before.
Thanks,
Armand Grillet
d9e83d7c0cf6146f00ce7f1ab11b89880d105984
Diff: https://reviews.apache.org/r/65503/diff/2/
Changes: https://reviews.apache.org/r/65503/diff/1-2/
Testing
---
Tested in the dependent review request /r/65346/
Thanks,
Armand Grillet
libraries in another patch?
- Armand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65503/#review196858
---
On Feb. 11,
tests were run, that the content of the directory
`build/src/cli` was as expected, and that `build/src/mesos/mesos` was correctly
running.
Thanks,
Armand Grillet
Mesos agents
config Interacts with the Mesos CLI configuration file
taskInteracts with the tasks running in a Mesos cluster
See 'mesos help ' for more information on a specific command.
```
Thanks,
Armand Grillet
---
See summary.
Diffs
-
src/python/cli_new/README.md 847141db9a1f9eb5c78b2d50367b599a5c72ce61
Diff: https://reviews.apache.org/r/65584/diff/1/
Testing
---
Thanks,
Armand Grillet
n' to rebuild the virtualenv
without comparing its last modification date with its dependencies.
$ ./bootstrap --clean
```
The virtual environment will then be rebuilt again with this third command.
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64609/#review196984
---
Ship it!
Ship It!
- Armand Grillet
On Jan. 25, 2018, 6:36
62/`.
New UI (masters):
New UI (agents):
Thanks,
Armand Grillet
again with this third command.
Thanks,
Armand Grillet
sable URL containing the data we wish to download.
- Armand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65246/#review196488
-------
1c84ad33a554e078d854e25b4d5ca311c8507f91
Diff: https://reviews.apache.org/r/65346/diff/2/
Changes: https://reviews.apache.org/r/65346/diff/1-2/
Testing (updated)
---
New UI:
The group columns cannot be ordered as they have sub-columns, this is expected.
Thanks,
Armand Grillet
://reviews.apache.org/r/65503/diff/1/
Testing
---
Tested in the dependent review request /r/65346/
Thanks,
Armand Grillet
//localhost:5062/`.
New UI (masters):
New UI (agents):
Thanks,
Armand Grillet
CLI tests were run, that the content of the directory
`build/src/cli` was as expected, and that `build/src/mesos/mesos` was correctly
running.
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61172/#review196638
---
Ship it!
Ship It!
- Armand Grillet
On Jan. 19, 2018, 8:48
so that they can shepherd
this patch?
- Armand Grillet
On Jan. 31, 2018, 6:15 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
imum amount of CPUs/GPUs/Mem/Disk.
- Armand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65346/#review196383
---
On Jan. 27, 2018
e the UI after applying the patch.
- Armand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65351/#review196382
---
On Jan. 26, 2018, 3
r='/tmp/master1-log' --weights="example=42,example/a=2"
--registry=in_memory
```
UI before patch when viewing the roles tab:
UI by default after patch:
Thanks,
Armand Grillet
://i.imgur.com/5mq31Ls.png)
Thanks,
Armand Grillet
lhost:5062/`.
New UI (rev. 1):
New UI (rev. 2):
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65189/#review196231
---
Ship it!
Ship It!
- Armand Grillet
On Jan. 25, 2018, 8:40
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65245/#review195926
---
On Jan. 20, 2018, 4:14 p.m., Armand Grillet wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65197/#review195994
---
Ship it!
Ship It!
- Armand Grillet
On Jan. 22, 2018, 8:45
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65189/#review195911
---
Ship it!
Ship It!
- Armand Grillet
On Jan. 22, 2018, 1:58
tps://reviews.apache.org/r/65189/#comment275222>
Can you rename `message` to something else as we already have `with
open(message_file, 'w') as message:`.
- Armand Grillet
On Jan. 17, 2018, 12:22 p.m., Benjamin Bannier wrote:
>
> --
streaming features on the home and agents Web UI
endpoints, from both `http://localhost:5061/` and `http://localhost:5062/`.
New UI:
Thanks,
Armand Grillet
still working on the home and agents
endpoints.
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65208/#review195826
---
Ship it!
Ship It!
- Armand Grillet
On Jan. 18, 2018, 10:53
f3e1965885406d6d3e49348bee7e7d0df9d5
> > Author: Armand Grillet
> > Date: Mon Feb 6 22:45:43 2017 +0800
> >
> > Optimized the size of the favicon.
> >
> > The favicon now only contains two images: 16x16 and
/slave_tests.cpp 59e3065ad9aadbd90cdfd32e830b433b88d6de86
Diff: https://reviews.apache.org/r/63661/diff/4/
Changes: https://reviews.apache.org/r/63661/diff/3-4/
Testing
---
```
$ make check
```
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65073/#review195213
---
Ship it!
Ship It!
- Armand Grillet
On Jan. 11, 2018, 7:56
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64849/#review195141
---
Ship it!
Ship It!
- Armand Grillet
On Jan. 9, 2018, 3:19
tps://reviews.apache.org/r/65073/#comment274286>
s/`"from {}!"`/`" from {}!"`.
- Armand Grillet
On Jan. 10, 2018, 3:28 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64848/#review195120
---
Ship it!
Ship It!
- Armand Grillet
On Jan. 9, 2018, 3:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64847/#review195037
---
Ship it!
Ship It!
- Armand Grillet
On Jan. 9, 2018, 3:20
uot;We
retry only when it makes sense: either due to a network partition (e.g.
connection errors) or if the request failed due to a server error such as 500s,
timeouts, and so on."
src/python/lib/tests/test_http.py
Lines 239 (patched)
<https://r
a new virtualenv
instead of replacing/removing an existent one.
support/mesos-style.py
Line 150 (original), 150 (patched)
<https://reviews.apache.org/r/64970/#comment273919>
`mesos/support/tox.ini` does not exist and is not added in this patch, is
that normal?
- Armand Grillet
/1/
Testing
---
```
$ ./bootstrap
$ mkdir build
$ cd build
$ ../configure --enable-new-cli --disable-java
$ make check
```
Checked that the the CLI tests were run, that the content of the directory
`build/src/cli`, and that `build/src/mesos/mesos` was running as expected.
Thanks,
Armand
---
```
GTEST_FILTER="" nice make check -j16 V=0
```
Thanks,
Armand Grillet
r/64297/#comment272873>
Even if no dedicated section exists for this module yet, could a one-liner
description be added in this array? Same for the ones at the end of the array.
docs/modules.md
Lines 141 (patched)
<https://reviews.apache.org/r/64297/#comment272866>
s/`implemen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64686/#review194131
---
Ship it!
Ship It!
- Armand Grillet
On Dec. 18, 2017, 7:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64685/#review194089
---
Ship it!
Ship It!
- Armand Grillet
On Dec. 18, 2017, 7:06
the one expected.
Thanks,
Armand Grillet
ot;: "SCALAR",
"scalar": {
"value": 2
}
}
],
"command": {
"value": "sleep 1000"
},
"check": {
"type": "COMMAND",
"command": {
"command": {
"value": "echo \"Bonjour\""
},
"uris": []
}
}
}
]
}
```
And:
```
$ nice make check
```
Thanks,
Armand Grillet
/diff/3/
Changes: https://reviews.apache.org/r/64575/diff/2-3/
Testing
---
```
GTEST_FILTER="" nice make check -j16 V=0
```
Thanks,
Armand Grillet
uot;,
"scalar": {
"value": 2
}
}
],
"command": {
"value": "sleep 1000"
},
"check": {
"type": "COMMAND",
"command": {
"command": {
"value": "echo \"Bonjour\""
},
"uris": []
}
}
}
]
}
```
And:
```
$ nice make check
```
Thanks,
Armand Grillet
Diff: https://reviews.apache.org/r/64575/diff/2/
Changes: https://reviews.apache.org/r/64575/diff/1-2/
Testing
---
```
GTEST_FILTER="" nice make check -j16 V=0
```
Thanks,
Armand Grillet
)
docker rm $(docker ps -a -q)
docker rmi $(docker images -q)
Finally, restart the agent.
```
Thanks,
Armand Grillet
$(docker images -q)
Finally, restart the agent.
```
Thanks,
Armand Grillet
ot;: "SCALAR",
"scalar": {
"value": 2
}
}
],
"command": {
"value": "sleep 1000"
},
"check": {
"type": "COMMAND",
"command": {
"command": {
"value": "echo \"Bonjour\""
},
"uris": []
}
}
}
]
}
```
And:
```
$ nice make check
```
Thanks,
Armand Grillet
201 - 300 of 549 matches
Mail list logo
