Re: Review Request 68640: Added version check and bundling of libevent to autotools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/ --- (Updated Sept. 22, 2018, 7:53 p.m.) Review request for mesos, Benjamin

Re: Review Request 68641: Added version check and bundling of libevent within libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68641/ --- (Updated Sept. 22, 2018, 7:53 p.m.) Review request for mesos, Benjamin

Re: Review Request 68679: Fixed stout `FsTest.Used` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68679/#review208849 --- Ship it! Thanks so much James for staying on this ball. Giving

Re: Review Request 68728: Added rapidjson to RPM spec file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68728/#review208675 --- Ship it! Ship It! - Till Toenshoff On Sept. 17, 2018, 1:28

Re: Review Request 68641: Added version check and bundling of libevent within libprocess.

> On Sept. 11, 2018, 11:25 p.m., James Peach wrote: > > 3rdparty/libprocess/configure.ac > > Lines 805 (patched) > > > > > > Maybe: > > ``` > > test "x$without_bundled_libevent" = "xyes" -o

Re: Review Request 68641: Added version check and bundling of libevent within libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68641/ --- (Updated Sept. 16, 2018, 8:41 p.m.) Review request for mesos, Benjamin

Re: Review Request 68640: Added version check and bundling of libevent to autotools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/ --- (Updated Sept. 16, 2018, 8:40 p.m.) Review request for mesos, Benjamin

Re: Review Request 68640: Added version check and bundling of libevent to autotools.

> On Sept. 11, 2018, 11:25 p.m., James Peach wrote: > > 3rdparty/Makefile.am > > Lines 327 (patched) > > > > > > I think that `JEMALLOC_CONFIGURE_ARGS` is a typo? > > > > It reads more clearly to me if you

Re: Review Request 68686: Added Robin Goegge to contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68686/#review208518 --- Ship it! Ship It! - Till Toenshoff On Sept. 11, 2018, 3:17

Re: Review Request 68679: Fixed stout `FsTest.Used` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68679/#review208511 --- We need to find a different solution...

Re: Review Request 68640: Added version check and bundling of libevent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/ --- (Updated Sept. 6, 2018, 10:07 a.m.) Review request for mesos, Benjamin

Review Request 68640: Added version check and bundling of libevent to autotools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and James Peach.

Review Request 68641: Added version check and bundling of libevent within libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68641/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and James Peach.

Re: Review Request 68627: Brought site dependencies up to date.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68627/#review208344 --- Ship it! Ship It! - Till Toenshoff On Sept. 5, 2018, 8:53

Re: Review Request 68610: Updated libjvm search logic for newer openjdk versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68610/#review208277 --- Ship it! Terriffic, I am really glad this got solved - thanks

Re: Review Request 68611: Fixed maven invocation with proper JAVA_HOME.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68611/#review208276 --- Ship it! Nice catch! - Till Toenshoff On Sept. 3, 2018,

Re: Review Request 68612: Consolidated Java header targets using makefile patterns.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68612/#review208275 --- Fix it, then Ship it! Awesome! src/Makefile.am Line 2003

Re: Review Request 68613: Replaced javah with `javac -c` for newer JDKs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68613/#review208274 --- Ship it! - Till Toenshoff On Sept. 3, 2018, 5:47 p.m., Kapil

Re: Review Request 68613: Replaced javah with `javac -c` for newer JDKs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68613/#review208273 --- Fix it, then Ship it! configure.ac Line 1404 (original),

Re: Review Request 68604: Wrapped syscall initgroups by warning suppression pragma.

> On Sept. 2, 2018, 8:20 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/su.hpp > > Lines 264-266 (original), 270-273 (patched) > > > > > > If I remove this block completely, not stout tests

Review Request 68604: Wrapped syscall initgroups by warning suppression pragma.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68604/ --- Review request for mesos, Benjamin Bannier and Gilbert Song. Bugs: MESOS-8457

Re: Review Request 67730: Made Git normalize all line endings automatically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67730/#review205939 --- Ship it! Ship It! - Till Toenshoff On July 10, 2018, 5:32

Review Request 67859: Updated apply-reviews.py messaging for submitted reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67859/ --- Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-7397

<    1   2   3