Re: Review Request 44379: Use tokens size to parse perf stat format.

://reviews.apache.org/r/44379/diff/ Testing --- 1. {Found and Test} with Serenity, ema filter could get perf event statistics correctly as expected. 2. ./bin/mesos-tests.sh --gtest_filter=PerfEventIsolatorTest* --log_dir=/tmp/mesos/ Thanks, fan du

Re: Review Request 44379: Use tokens size to parse perf stat format.

----- On 四月 11, 2016, 7:01 a.m., fan du wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44379/ > ---

Re: Review Request 44379: Use tokens size to parse perf stat format.

apache.org/r/44379/#review128076 --- On April 11, 2016, 7:01 a.m., fan du wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 44379: Use tokens size to parse perf stat format.

749e676aaf2ce639dd976f2b23e323300c6114c5 Diff: https://reviews.apache.org/r/44379/diff/ Testing --- 1. {Found and Test} with Serenity, ema filter could get perf event statistics correctly as expected. 2. ./bin/mesos-tests.sh --gtest_filter=PerfEventIsolatorTest* --log_dir=/tmp/mesos/ Thanks, fan du

Re: Review Request 44379: Use tokens size to parse perf stat format.

--gtest_filter=PerfEventIsolatorTest* --log_dir=/tmp/mesos/ Thanks, fan du

Re: Review Request 45808: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

k' to reproduce/verify the issue. "master/messages_register_framework": 1.0, "master/messages_reregister_framework": 0.0, Thanks, fan du

Re: Review Request 45808: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

--------- On 四月 6, 2016, 8:59 a.m., fan du wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45808/ > --

Review Request 45808: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

framework": 0.0, Thanks, fan du

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

283/#comment189528> Why did you implement the idea I worked out at https://issues.apache.org/jira/browse/MESOS-4705 by updating your orignal approach at the condition you are in the MESOS-4705 converstaion as well, and you know well I'm working on the same issue? - fan du On April 1,

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

;: 1 },"reservation":{"principal": "XiaoHaHa"}} ]' -X POST ipdc02-kvm-guest2:5050/master/reserve HTTP/1.1 200 OK Date: Fri, 26 Feb 2016 19:59:01 GMT Content-Length: 0 # curl http://ipdc02-kvm-guest2:5050/metrics/snapshot | python -mjson.tool | grep reserve "master/messages_reserve_resource": 1.0, "master/messages_unreserve_resource": 0.0, Thanks, fan du

Re: Review Request 45097: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

eck GTEST_FILTER="AuthenticationTest*" [--] 21 tests from AuthenticationTest (7019 ms total) [--] Global test environment tear-down [==] 21 tests from 1 test case ran. (7140 ms total) [ PASSED ] 21 tests. Thanks, fan du

Re: Review Request 45096: Introduce 'minus' operator for class Counter.

y/libprocess/include/process/metrics/counter.hpp a13cc7e18c8b23eae83c326d63874d9d2aaedc0d Diff: https://reviews.apache.org/r/45096/diff/ Testing ------- Thanks, fan du

Review Request 45096: Introduce 'minus' operator for class Counter.

Testing --- Thanks, fan du

Review Request 45097: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

ssages_register_framework": 1.0, "master/messages_reregister_framework": 0.0, Thanks, fan du

Review Request 45095: Introduce 'minus' operator for class Counter.

Testing --- Thanks, fan du

Review Request 45094: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

es_register_framework": 1.0, "master/messages_reregister_framework": 0.0, "master/messages_unregister_framework": 1.0, Thanks, fan du

Re: Review Request 44379: Correctly parse perf stat format for non-vanilla 3.10 kernel.

To reply, visit: https://reviews.apache.org/r/44379/#review123962 ------- On 三月 10, 2016, 3:26 a.m., fan du wrote: > > --- > This is an automatical

Re: Review Request 44881: Generize perf event parsing to match PerfStatistics filed name for "perf stat"

mple: Failed to parse perf sample: Unexpected event 'intel_cqm/llc_occupancy/' in perf output at line: 0.00,Bytes,intel_cqm/llc_occupancy/,mesos/fad99e5c-5ef2-4908-83de-3b5d7c2bb71f,9795836,100.00 After this modificaiton, I could intel_cqm/llc_occupancy statistics. Thanks, fan du

Review Request 44881: Provide generic perf event parsing.

his modificaiton, I could intel_cqm/llc_occupancy statistics. Thanks, fan du

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

cs/snapshot | python -mjson.tool | grep reserve "master/messages_reserve_resource": 1.0, "master/messages_unreserve_resource": 0.0, Thanks, fan du

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

for the point, and pls review the updated RR. I will create another JIRA to track other metrics issue, and discuss with you later. - fan --- This is an automatically generated e-mail. To reply, visit: https://re

Re: Review Request 44379: Correctly parse perf stat format for non-vanilla 3.10 kernel.

t* --log_dir=/tmp/mesos/ Thanks, fan du

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

#x27;authorizeXXX' function. Can you do that in the callers of authorizeXXX > > function instead? > > fan du wrote: > Thanks for the reviewing :) > It intended to reduce code duplication, do the statistics counting here > in the common path from both http endpoint

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

ttp://ipdc02-kvm-guest2:5050/metrics/snapshot | python -mjson.tool | grep reserve "master/messages_reserve_resource": 1.0, "master/messages_unreserve_resource": 0.0, Thanks, fan du

Re: Review Request 44379: Correctly parse perf stat format for 3.10 kernel.

rmat: value,unit,event,cgroup,running,ratio May I know which kernel version do you use? thanks - fan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review122455 -

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

If you insist, I'm willing to do it seprately. - fan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review122396 -----------

Review Request 44379: Correctly parse perf stat format for 3.10 kernel.

could get perf event statistics correctly as expected. Thanks, fan du

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

ot;;. squash the commits together should also works ok :) Thanks for your kindness. - fan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review121705 --- On 三月 3, 2016, 5:40

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

quot;principal": "XiaoHaHa"}} ]' -X POST ipdc02-kvm-guest2:5050/master/reserve HTTP/1.1 200 OK Date: Fri, 26 Feb 2016 19:59:01 GMT Content-Length: 0 # curl http://ipdc02-kvm-guest2:5050/metrics/snapshot | python -mjson.tool | grep reserve "master/messages_reserve_resource": 1.0, "master/messages_unreserve_resource": 0.0, Thanks, fan du

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

Liu, haosdent huang, and Jie Yu. Changes --- add tiny changelog Bugs: MESOS-4492 https://issues.apache.org/jira/browse/MESOS-4492 Repository: mesos Description --- Signed-off-by: Fan Du Diffs - docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 src/master

Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

. Bugs: MESOS-4492 https://issues.apache.org/jira/browse/MESOS-4492 Repository: mesos Description --- Signed-off-by: Fan Du Diffs (updated) - docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 src/master/master.cpp 8d6d3c6468c6b85fe09c33cf9747cc3d1f515ab9 src

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

huang, and Jie Yu. Summary (updated) - Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation Bugs: MESOS-4492 https://issues.apache.org/jira/browse/MESOS-4492 Repository: mesos Description (updated) --- Signed-off-by: Fan Du Diffs (updated

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

b/mesos-reviewbot/11661/console Already rebased by rewriting commit message. Sorry for the noise. - fan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44058/#review12

Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

# curl http://ipdc02-kvm-guest2:5050/metrics/snapshot | python -mjson.tool | grep reserve "master/messages_reserve_resource": 1.0, "master/messages_unreserve_resource": 0.0, Thanks, fan du