Re: Review Request 67187: Tested per-framework task state metrics.

2018-07-31 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ --- (Updated July 31, 2018, 11:25 p.m.) Review request for mesos, Gastón Kleiman an

Re: Review Request 67187: Tested per-framework task state metrics.

2018-07-31 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/#review206701 --- Fix it, then Ship it! src/tests/master_tests.cpp Lines 9117 (p

Re: Review Request 67187: Tested per-framework task state metrics.

2018-07-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ --- (Updated July 31, 2018, 1:53 a.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 67187: Tested per-framework task state metrics.

2018-07-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ --- (Updated July 31, 2018, 12:22 a.m.) Review request for mesos, Gastón Kleiman an

Re: Review Request 67187: Tested per-framework task state metrics.

2018-07-30 Thread Greg Mann
> On July 25, 2018, 9:06 p.m., Gastón Kleiman wrote: > > src/tests/master_tests.cpp > > Lines 9113-9117 (patched) > > > > > > Can we use the new helpers here? > > > > ``` > > testing::Sequence taskSeq

Re: Review Request 67187: Tested per-framework task state metrics.

2018-07-27 Thread Greg Mann
> On July 25, 2018, 9:06 p.m., Gastón Kleiman wrote: > > src/tests/master_tests.cpp > > Lines 9107 (patched) > > > > > > Do we have to specify the resources? I think the defaults should be > > good. But the resour

Re: Review Request 67187: Tested per-framework task state metrics.

2018-07-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ --- (Updated July 27, 2018, 4:23 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 67187: Tested per-framework task state metrics.

2018-07-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ --- (Updated July 27, 2018, 4:16 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 67187: Tested per-framework task state metrics.

2018-07-25 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/#review206468 --- src/tests/master_tests.cpp Lines 9185 (patched)

Re: Review Request 67187: Tested per-framework task state metrics.

2018-07-25 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/#review206466 --- src/tests/master_tests.cpp Lines 9107 (patched)

Re: Review Request 67187: Tested per-framework task state metrics.

2018-07-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/#review206467 --- src/tests/master_tests.cpp Lines 9175-9181 (patched)

Re: Review Request 67187: Tested per-framework task state metrics.

2018-07-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ --- (Updated July 18, 2018, 1:46 a.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 67187: Tested per-framework task state metrics.

2018-07-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ --- (Updated July 10, 2018, 9:25 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 67187: Tested per-framework task state metrics.

2018-07-03 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ --- (Updated July 3, 2018, 9:40 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 67187: Tested per-framework task state metrics.

2018-05-18 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/#review203404 --- Patch looks great! Reviews applied: [66882, 66819, 66820, 66822,

Re: Review Request 67187: Tested per-framework task state metrics.

2018-05-17 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/#review203361 --- FAIL: Some of the unit tests failed. Please check the relevant log