Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review95410 --- Ship it! Ship It! - Bernd Mathiske On Aug. 13, 2015, 9:19 a.m.,

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review95277 --- Patch looks great! Reviews applied: [36847] All tests passed. - M

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated Aug. 13, 2015, 4:19 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 36847: Added HTTP Delete Method.

> On Aug. 6, 2015, 9:56 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 754 > > > > > > I'm rather late to the party, but AFAIK Mesos appreciates consistency > > over doing some t

Re: Review Request 36847: Added HTTP Delete Method.

> On Aug. 6, 2015, 9:56 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 754 > > > > > > I'm rather late to the party, but AFAIK Mesos appreciates consistency > > over doing some t

Re: Review Request 36847: Added HTTP Delete Method.

> On Aug. 6, 2015, 2:56 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 754 > > > > > > I'm rather late to the party, but AFAIK Mesos appreciates consistency > > over doing some t

Re: Review Request 36847: Added HTTP Delete Method.

> On Aug. 6, 2015, 2:56 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 754 > > > > > > I'm rather late to the party, but AFAIK Mesos appreciates consistency > > over doing some t

Re: Review Request 36847: Added HTTP Delete Method.

> On Aug. 6, 2015, 9:56 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 754 > > > > > > I'm rather late to the party, but AFAIK Mesos appreciates consistency > > over doing some t

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review94388 --- 3rdparty/libprocess/include/process/http.hpp (line 754)

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review94067 --- Patch looks great! Reviews applied: [36847] All tests passed. - M

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated Aug. 4, 2015, 10:57 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated Aug. 4, 2015, 10:54 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review94040 --- 3rdparty/libprocess/include/process/http.hpp (line 747)

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93998 --- Patch looks great! Reviews applied: [36847] All tests passed. - M

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated Aug. 3, 2015, 6:45 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 36847: Added HTTP Delete Method.

> On Aug. 3, 2015, 5:47 p.m., Marco Massenzio wrote: > > 3rdparty/libprocess/src/http.cpp, lines 927-929 > > > > > > I would add a statement in the (javadoc?) method's documentation, to > > the effect that a query o

Re: Review Request 36847: Added HTTP Delete Method.

> On Aug. 3, 2015, 5:47 p.m., Marco Massenzio wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 736 > > > > > > please don't use abbreviations. > > `delete()` is the HTTP method name. > > > >

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93923 --- 3rdparty/libprocess/include/process/http.hpp (line 736)

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93880 --- 3rdparty/libprocess/include/process/http.hpp (line 736)

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93326 --- Patch looks great! Reviews applied: [36847] All tests passed. - M

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated July 28, 2015, 4:45 p.m.) Review request for mesos and Alexander Rukle

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93307 --- Ship it! Ship It! - Alexander Rukletsov On July 28, 2015, 4:26 p

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated July 28, 2015, 4:26 p.m.) Review request for mesos and Alexander Rukle

Re: Review Request 36847: Added HTTP Delete Method.

> On July 28, 2015, 8:43 a.m., Alexander Rukletsov wrote: > > Also, I think we need a doppelgänger for the method in the `streaming` > > namespace. > > Joerg Schad wrote: > Are you sure? For delete we are not streaming any data... I think we do it implicitly anyway (see `StreamingResponseD

Re: Review Request 36847: Added HTTP Delete Method.

> On July 28, 2015, 8:43 a.m., Alexander Rukletsov wrote: > > Also, I think we need a doppelgänger for the method in the `streaming` > > namespace. Are you sure? For delete we are not streaming any data... - Joerg --- This is an automa

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93271 --- Patch looks great! Reviews applied: [36847] All tests passed. - M

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated July 28, 2015, 9:49 a.m.) Review request for mesos and Alexander Rukle

Re: Review Request 36847: Added HTTP Delete Method.

> On July 27, 2015, 8:13 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/http.cpp, line 927 > > > > > > This todo looks inconsistent with the way `GET` handler is written. > > Let's create a clean-up JI