Review Request 37382: Introduced provisioner Backend interface.

2015-08-11 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/ --- Review request for mesos, Lily Chen, Ian Downes, Jie Yu, and Timothy Chen. Bugs

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95065 --- Patch looks great! Reviews applied: [37382] All tests passed. - M

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95069 --- Ship it! Ship It! src/slave/containerizer/provisioners/backend.hp

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-12 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95113 --- src/slave/containerizer/provisioners/backend.hpp (line 52)

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-14 Thread Jiang Yan Xu
> On Aug. 12, 2015, 1:45 a.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/backend.hpp, line 48 > > > > > > Should we just use Path here? Path is still hard to use in an interface particularly when i

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-14 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/ --- (Updated Aug. 14, 2015, 10:51 a.m.) Review request for mesos, Lily Chen, Ian Do

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95455 --- src/slave/containerizer/provisioners/backend.hpp (line 49)

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95471 --- Patch looks great! Reviews applied: [37382] All tests passed. - M

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-14 Thread Jiang Yan Xu
> On Aug. 14, 2015, 11:15 a.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/backend.hpp, lines 55-57 > > > > > > Hum, what do yo mean here? > > > > I think the backend should be container aware. I.

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-14 Thread Jie Yu
> On Aug. 14, 2015, 6:15 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/backend.hpp, lines 55-57 > > > > > > Hum, what do yo mean here? > > > > I think the backend should be container aware. I.e

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-14 Thread Jiang Yan Xu
> On Aug. 14, 2015, 11:15 a.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/backend.hpp, lines 55-57 > > > > > > Hum, what do yo mean here? > > > > I think the backend should be container aware. I.

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-18 Thread Timothy Chen
> On Aug. 14, 2015, 6:15 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/backend.hpp, lines 55-57 > > > > > > Hum, what do yo mean here? > > > > I think the backend should be container aware. I.e

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-18 Thread Jiang Yan Xu
> On Aug. 14, 2015, 11:15 a.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/backend.hpp, lines 55-57 > > > > > > Hum, what do yo mean here? > > > > I think the backend should be container aware. I.

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-19 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/ --- (Updated Aug. 19, 2015, 3:32 p.m.) Review request for mesos, Lily Chen, Ian Dow

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95886 --- Ship it! Ship It! - Jie Yu On Aug. 19, 2015, 10:32 p.m., Jiang Y