Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-12-14 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/#review110325 --- Ship it! Let's use snake_case in stout. 3rdparty/libprocess/3rdp

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-12-12 Thread Alex Clemmer
> On Dec. 10, 2015, 2:48 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp, lines 27-29 > > > > > > Let's move this into `` Per discussion we actually move the error type

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-12-12 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/ --- (Updated Dec. 12, 2015, 11:08 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-12-12 Thread Alex Clemmer
> On Dec. 10, 2015, 2:48 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp, line 21 > > > > > > Maybe we can drop the `Try` specific part of this comment. This c

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-12-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/#review109665 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-12-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/ --- (Updated Dec. 10, 2015, 2:14 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-11-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/ --- (Updated Nov. 16, 2015, 9:13 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/#review104770 --- Ship it! Double-checked build on non-Windows. - Joseph Wu On Oc

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-10-29 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/ --- (Updated Oct. 30, 2015, 5:55 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-10-27 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/ --- (Updated Oct. 27, 2015, 8:17 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-10-23 Thread Alex Clemmer
> On Oct. 23, 2015, 9:15 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp, line 34 > > > > > > This doesn't use any instance data so could probably be either `const`

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-10-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/#review103746 --- 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp

Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-10-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu