Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review114875 ---

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 16, 2016, 8:44 p.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 15, 2016, 7:29 p.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review114562 --- Ship it! snake_case

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

> On Dec. 15, 2015, 3:54 a.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 51 > > > > > > Calling FindClose on an invalid handle is not the best idea. At

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 7, 2016, 8:29 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review112953 --- Ship it! Ship It! - Yi Sun On Jan. 5, 2016, 11:04 p.m., Alex

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 5, 2016, 11:04 p.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review112618 --- Ship it! Ship It! - Alex Naparu On Jan. 4, 2016, 12:02 p.m.,

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 4, 2016, 12:02 p.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 4, 2016, 11:59 a.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 4, 2016, 11:18 a.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review112667 ---

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

> On Jan. 4, 2016, 10:33 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 94 > > > > > > Can you use _rmdir() instead to avoid another deprecation

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review112669 --- Ship it! Ship It! - Daniel Pravat On Jan. 4, 2016, 12:02 p.m.,

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 4, 2016, 11:26 p.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review112717 ---

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

> On Dec. 10, 2015, 4:12 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 109 > > > > > > Can you explain / comment why here (as well as on L139)

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

> On Dec. 15, 2015, 3:55 a.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 62 > > > > > > Nit: You're not reusing these, so might as well inline the calls.

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

> On Dec. 15, 2015, 3:54 a.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 39 > > > > > > What if the path ends with multiple '\' chars to begin with? Good

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review111775 --- Bad patch! Reviews applied: [39621, 39620, 39583, 39584] Failed

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

> On Dec. 15, 2015, 3:54 a.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 51 > > > > > > Calling FindClose on an invalid handle is not the best idea. At

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

> On Dec. 10, 2015, 4:12 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 109 > > > > > > Can you explain / comment why here (as well as on L139)

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review110391 ---

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review110385 ---

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review109681 ---

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Nov. 16, 2015, 9:13 a.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review104771 --- Ship it! Double-checked non-Windows builds. - Joseph Wu On

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Oct. 30, 2015, 6:11 a.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Oct. 27, 2015, 8:30 a.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Oct. 27, 2015, 8:23 a.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Oct. 27, 2015, 8:33 a.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

> On Oct. 26, 2015, 8:43 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 42 > > > > > > `X:\blah*` isn't clear. Did you mean `currentPath` + `*`? I

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review104156 ---

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

> On Oct. 26, 2015, 1:43 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, > > lines 35-40 > > > > > > Use `strings::endsWith`. > > > > And you might also

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review104054 ---

Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review103749 --- Bad patch! Reviews applied: [39537, 39538, 39539, 39540, 39541,

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Oct. 23, 2015, 4:30 p.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review103858 --- Patch looks great! Reviews applied: [39537, 39538, 39539, 39540,