Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

2016-03-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/#review123857 --- Committed with the following formatting fixes.

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

2016-03-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/#review123728 --- Ship it! Ship It! - Michael Park On March 4, 2016, 11:43

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

2016-03-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/ --- (Updated March 4, 2016, 3:43 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

2016-03-04 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/#review122067 --- Fix it, then Ship it! src/tests/mesos.hpp (line 190)

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

2016-03-03 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/#review121855 --- LGTM, pending dependencies. - Bernd Mathiske On March 2, 2016,

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

2016-03-02 Thread Joseph Wu
> On March 2, 2016, 7:28 a.m., Bernd Mathiske wrote: > > src/tests/mesos.hpp, line 135 > > > > > > So this injection is allowed to be a shared_ptr and the others are not? > > This makes me wonder if it would not be

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

2016-03-02 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/#review121656 --- src/tests/mesos.hpp (line 133)