Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review123214 --- Ship it! Ship It! - Vinod Kone On March 11, 2016, 3:57

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 11, 2016, 4:57 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review123143 --- Patch looks great! Reviews applied: [44318, 44319, 44320, 44322]

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 11, 2016, 2:54 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review122991 --- include/mesos/authorizer/authorizer.hpp (line 43)

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review122937 --- Patch looks great! Reviews applied: [44318, 44319, 44320, 44322]

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 10, 2016, 3:15 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 10, 2016, 3:10 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review122905 --- Patch looks great! Reviews applied: [44318, 44319, 44320, 44322]

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 10, 2016, 8:34 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

> On March 9, 2016, 10:18 a.m., Adam B wrote: > > src/master/master.cpp, line 2837 > > > > > > When would this ever be empty? Shouldn't we have validated somewhere > > prior that the Reserve operation is reserving

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review122729 --- Patch looks great! Reviews applied: [44318, 44319, 44320, 44322]

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 9, 2016, 3:10 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

> On March 9, 2016, 10:18 a.m., Adam B wrote: > > src/master/master.cpp, line 2801 > > > > > > Someday we may want to return something besides a bool, so that the > > client can get back a more meaningful error

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review122699 --- A couple of quick thoughts on your WIP so far. Also, I committed

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review122700 --- Bad patch! Reviews applied: [44322, 44320, 44319, 44318] Failed

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 9, 2016, 6:07 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 8, 2016, 5:50 p.m.) Review request for mesos, Adam B, Joerg