Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/#review125934 --- Ship it! Looks great, thanks! I'll just touch up some minor typ

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-14 Thread Klaus Ma
> On March 6, 2016, 8:51 a.m., Klaus Ma wrote: > > support/install-nvidia-gdk.sh, lines 3-13 > > > > > > Are we going to provide documents about those vars? e.g. which version > > are we going to support? > > Kevin K

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/ --- (Updated March 14, 2016, 7:35 a.m.) Review request for mesos, Ben Mahler, Rob T

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-13 Thread Kevin Klues
> On March 8, 2016, 7:15 p.m., Ben Mahler wrote: > > Looks good, main thing is just to add some context to the installer script > > so that others understand why it exists. > > Ben Mahler wrote: > Could you update the testing done so that others can tell how you tested > this? Done. > O

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-13 Thread Kevin Klues
> On March 6, 2016, 12:51 a.m., Klaus Ma wrote: > > support/install-nvidia-gdk.sh, lines 3-13 > > > > > > Are we going to provide documents about those vars? e.g. which version > > are we going to support? >From talk

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/ --- (Updated March 14, 2016, 12:25 a.m.) Review request for mesos, Ben Mahler, Rob

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-08 Thread Ben Mahler
> On March 8, 2016, 7:15 p.m., Ben Mahler wrote: > > Looks good, main thing is just to add some context to the installer script > > so that others understand why it exists. Could you update the testing done so that others can tell how you tested this? - Ben -

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/#review122572 --- Looks good, main thing is just to add some context to the installe

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-05 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/#review122216 --- support/install-nvidia-gdk.sh (lines 3 - 13)

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-03 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/ --- (Updated March 4, 2016, 1:21 a.m.) Review request for mesos, Ben Mahler and Rob

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-03 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/#review121978 --- CHANGELOG (line 12)

Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-03 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/ --- Review request for mesos, Ben Mahler and Rob Todd. Bugs: MESOS-4860 https:/