Re: Review Request 44531: Fixed parsing network ip address with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review141573 --- Closing this review due to inactivity. Please see our [guidelines

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On March 10, 2016, 11:09 p.m., Jie Yu wrote: > > src/docker/docker.cpp, lines 336-341 > > > > > > To be consistent, maybe just do `if (!ipAddressValue.isSome())` here as > > well? For now I think I'll leave it as

Re: Review Request 44531: Fixed parsing network ip address with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review123025 --- Fix it, then Ship it! src/docker/docker.cpp (lines 306 - 307)

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On 三月 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue` would be

Re: Review Request 44531: Fixed parsing network ip address with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review122860 --- Ship it! Ship It! - Travis Hegner On March 8, 2016, 10:54 p.

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On March 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue` would

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On 三月 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue` would be

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On 三月 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue` would be

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On March 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue` would

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On March 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue` would

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On March 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue` would

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On March 8, 2016, 11:51 p.m., Dan Osborne wrote: > > Ship It! I ran a test cluster and found no regression for launching containers networked with bridge and host. - Dan --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On March 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue` would

Re: Review Request 44531: Fixed parsing network ip address with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review122687 --- Patch looks great! Reviews applied: [44531] Passed command: expo

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On 三月 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue` would be

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On March 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue` would

Re: Review Request 44531: Fixed parsing network ip address with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review122657 --- src/docker/docker.cpp (lines 306 - 307)

Re: Review Request 44531: Fixed parsing network ip address with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review122637 --- Ship it! Ship It! - Dan Osborne On March 8, 2016, 10:54 p.m.

Re: Review Request 44531: Fixed parsing network ip address with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/ --- (Updated March 8, 2016, 9:58 p.m.) Review request for mesos, Jie Yu and Travis

Review Request 44531: Fixed parsing network ip address with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/ --- Review request for mesos, Jie Yu and Travis Hegner. Repository: mesos Descrip

Re: Review Request 44531: Fixed parsing network ip address with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/ --- (Updated March 8, 2016, 9:58 p.m.) Review request for mesos, Jie Yu and Travis