Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs: ME

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review122714 --- Patch looks great! Reviews applied: [44004, 44200, 44549, 44555]

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123154 --- src/slave/containerizer/mesos/isolators/network/cni.cpp (line 133

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123162 --- Ship it! Ship It! - Avinash sridharan On March 9, 2016, 6:01

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123164 --- Ship it! - Avinash sridharan On March 9, 2016, 6:01 a.m., Qia

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123163 --- Ship it! Ship It! - Avinash sridharan On March 9, 2016, 6:01

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123192 --- src/slave/containerizer/mesos/isolators/network/cni.hpp (lines 81

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

> On March 12, 2016, 3:28 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 48 > > > > > > Let's remove this 'empty' check here since you hae the os::exists check > > below. They

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

> On March 11, 2016, 7:28 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 73-77 > > > > > > I think the CNI plugin should also support the case where the user does > > not speci

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

> On March 12, 2016, 3:28 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 73-77 > > > > > > I think the CNI plugin should also support the case where the user does > > not speci

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

> On March 11, 2016, 7:28 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 73-77 > > > > > > I think the CNI plugin should also support the case where the user does > > not speci

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

> On March 12, 2016, 3:28 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 73-77 > > > > > > I think the CNI plugin should also support the case where the user does > > not speci

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/ --- (Updated March 15, 2016, 11:02 p.m.) Review request for mesos, Avinash sridhara

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

> On March 12, 2016, 3:28 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 177-181 > > > > > > Again, this check should be removed to support containers that do not > > specify

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

> On March 11, 2016, 7:28 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 73-77 > > > > > > I think the CNI plugin should also support the case where the user does > > not speci

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

> On March 11, 2016, 7:28 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 48 > > > > > > Let's remove this 'empty' check here since you hae the os::exists check > > below. > > Q

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

> On March 11, 2016, 7:28 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 177-181 > > > > > > Again, this check should be removed to support containers that do not > > specify

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

> On March 12, 2016, 3:28 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 48 > > > > > > Let's remove this 'empty' check here since you hae the os::exists check > > below. > > Q

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/ --- (Updated March 16, 2016, 3:25 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/ --- (Updated March 17, 2016, 5:47 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123975 --- Fix it, then Ship it! Ship It! src/slave/containerizer/mesos/

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123973 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/