Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 7, 2016, 9:50 p.m.) Review request for mesos, Jie Yu and Jiang Y

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review127567 --- Ship it! Ship It! - Jiang Yan Xu On April 6, 2016, 3:36 p.m.

Re: Review Request 44948: Add XFS disk resource isolator.

> On April 6, 2016, 9:07 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp, line 407 > > > > > > Should we assume that freeProjectId already doesn't include > > `info->projectId`?

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 6, 2016, 10:36 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review127367 --- Mostly LGTM. Just a few additional comments. src/slave/container

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 6, 2016, 6:43 p.m.) Review request for mesos, Jie Yu and Jiang Y

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 5, 2016, 11:41 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 5, 2016, 11:15 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 5, 2016, 10:59 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

> On April 5, 2016, 4:52 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp, line 33 > > > > > > Doesn't look like the utils header is used in this header? > > > > Otherwise a

Re: Review Request 44948: Add XFS disk resource isolator.

> On March 24, 2016, 9:54 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, line 568 > > > > > > It seems that we don't need to modify `totalProjectIds` (which can be a > > const) h

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review126845 --- src/slave/containerizer/mesos/isolators/xfs/disk.hpp (line 33)

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 4, 2016, 5:28 p.m.) Review request for mesos, Jie Yu and Jiang Y

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review126613 --- src/slave/containerizer/mesos/isolators/disk/xfs.cpp (lines 501 -

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 1, 2016, 12:01 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 30, 2016, 10:19 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

> On March 24, 2016, 4:54 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, line 95 > > > > > > This method aborts early when a error occurs, I think it's useful to > > note this. >

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 29, 2016, 8:54 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

> On March 24, 2016, 4:54 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, lines 156-157 > > > > > > How does `openat` facilitate DFS better? If we used ``openat(2)`` we would not

Re: Review Request 44948: Add XFS disk resource isolator.

> On March 24, 2016, 4:54 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 217 > > > > > > IMO "xfs/disk" is probably better than "disk/xfs" (compared with > > "posix/disk") and "x

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review124983 --- src/slave/containerizer/mesos/containerizer.cpp (line 217)

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 22, 2016, 11:24 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 22, 2016, 1:21 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

> On March 21, 2016, 3:51 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, line 320 > > > > > > I am wondering if it's possible to distinguish the Error case from the > > case where ther

Re: Review Request 44948: Add XFS disk resource isolator.

> On March 21, 2016, 3:51 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, lines 172-173 > > > > > > Any reason this is not in xfs.hpp|cpp? I thought about that. If I make that change, t

Re: Review Request 44948: Add XFS disk resource isolator.

> On March 21, 2016, 3:51 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, lines 302-303 > > > > > > We typically store the 'flags' directory in case yo u need other > > parameters in th

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 21, 2016, 9:47 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 21, 2016, 6:21 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review124486 --- Overall, looks good to me! src/slave/containerizer/mesos/isolato

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 21, 2016, 2 a.m.) Review request for mesos, Jie Yu and Jiang Yan

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 17, 2016, 10:42 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 18, 2016, 3:47 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review124129 --- Fix it, then Ship it! This is just a flyby review. Was looking

Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOs-4828 https:/

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review124097 --- src/slave/containerizer/mesos/isolators/disk/xfs.cpp (line 220) <