Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-23 Thread Ashwin Murthy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/ --- (Updated March 24, 2016, 2:19 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-23 Thread Ashwin Murthy
> On March 20, 2016, 11:43 p.m., Vinod Kone wrote: > > Can you confirm that you did a manual test of this (using curl and multiple > > masters w/ ZK)? Vinod, validated the fix. Here is the o/p from testing with 3 local mesos masters and zookeeper $ curl -v -X POST -H "Content-Type: applicatio

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-21 Thread Ben Whitehead
> On March 18, 2016, 6:24 p.m., Ben Whitehead wrote: > > src/master/http.cpp, line 959 > > > > > > According to the rules defined in > > https://tools.ietf.org/html/rfc3986#section-5 we should be fine to use a > >

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review124472 --- Can you confirm that you did a manual test of this (using curl and

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review124470 --- Patch looks great! Reviews applied: [44985, 45000] Passed comman

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-20 Thread Ashwin Murthy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/ --- (Updated March 20, 2016, 11:03 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-20 Thread Ashwin Murthy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/ --- (Updated March 20, 2016, 10:07 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-20 Thread Ashwin Murthy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/ --- (Updated March 20, 2016, 9:57 p.m.) Review request for mesos and Vinod Kone.

Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-19 Thread Ashwin Murthy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-19 Thread Ashwin Murthy
> On March 19, 2016, 1:24 a.m., Ben Whitehead wrote: > > src/master/http.cpp, line 959 > > > > > > According to the rules defined in > > https://tools.ietf.org/html/rfc3986#section-5 we should be fine to use a > >

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review124399 --- Patch looks great! Reviews applied: [44985, 45000] Passed comman

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-19 Thread Ben Whitehead
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review124350 --- src/master/http.cpp (line 958)

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-19 Thread Vinod Kone
> On March 19, 2016, 1:24 a.m., Ben Whitehead wrote: > > src/master/http.cpp, line 959 > > > > > > According to the rules defined in > > https://tools.ietf.org/html/rfc3986#section-5 we should be fine to use a > >

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review124316 --- src/master/http.cpp (line 958)