Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/ --- (Updated June 17, 2016, 1:27 a.m.) Review request for mesos, Joseph Wu and Vino

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 13, 2016, 2:31 p.m., Joseph Wu wrote: > > src/master/http.cpp, line 2901 > > > > > > Do we want to standardize this return code (200 -> 202)? From the > > design doc, it seemed like empty responses shoul

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 13, 2016, 9:31 p.m., Joseph Wu wrote: > > src/master/http.cpp, line 2901 > > > > > > Do we want to standardize this return code (200 -> 202)? From the > > design doc, it seemed like empty responses shoul

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 13, 2016, 9:31 p.m., Joseph Wu wrote: > > src/master/http.cpp, line 2901 > > > > > > Do we want to standardize this return code (200 -> 202)? From the > > design doc, it seemed like empty responses shoul

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/#review137383 --- Fix it, then Ship it! LGTM! src/master/http.cpp (line 2864) <

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/ --- (Updated June 12, 2016, 5:46 p.m.) Review request for mesos, Joseph Wu and Vino

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/ --- (Updated June 11, 2016, 9:24 a.m.) Review request for mesos, Joseph Wu and Vino

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/#review136905 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 5:49 p.m., h

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 6, 2016, 9:06 p.m., Joseph Wu wrote: > > src/master/http.cpp, line 678 > > > > > > Depending on what the final return type ends up being (for > > `_updateMaintenanceSchedule`), is this missing a `.then(ser

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 6, 2016, 4:30 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 2773 > > > > > > this should return `v1::master::Response`. see below comment. > > Vinod Kone wrote: > sorry this should return Futu

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/ --- (Updated June 9, 2016, 5:31 p.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/#review136346 --- src/master/http.cpp (line 678)

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 6, 2016, 9:30 a.m., Vinod Kone wrote: > > src/master/http.cpp, line 2951 > > > > > > why want this function to return `v1::master::Response` instead of > > `http::Response` to be consistent with how we di

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 6, 2016, 4:30 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 2951 > > > > > > why want this function to return `v1::master::Response` instead of > > `http::Response` to be consistent with how we di

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 6, 2016, 4:30 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 2951 > > > > > > why want this function to return `v1::master::Response` instead of > > `http::Response` to be consistent with how we di

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 6, 2016, 4:30 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 2773 > > > > > > this should return `v1::master::Response`. see below comment. sorry this should return Future - Vinod -

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 6, 2016, 4:30 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 2951 > > > > > > why want this function to return `v1::master::Response` instead of > > `http::Response` to be consistent with how we di

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/#review136286 --- src/master/http.cpp (line 2773)

Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5505 https://issues.ap