Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review143822 --- Ship it! I fixed a few style nits while committing. src/slave

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

> On July 26, 2016, 10:03 p.m., Jie Yu wrote: > > Thanks a lot for your review, let me apply your comments in the other patches of this chain as well. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://r

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 27, 2016, 6:21 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review143618 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 26, 2016, 5:10 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 24, 2016, 12:55 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review143328 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 21, 2016, 7:05 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

> On July 18, 2016, 2:24 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 307 > > > > > > I think here you need to call `onAny()` rather than `then()`. You can > > take a

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

> On July 18, 2016, 2:24 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 307 > > > > > > I think here you need to call `onAny()` rather than `then()`. You can > > take a

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

> On July 18, 2016, 2:24 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 307 > > > > > > I think here you need to call `onAny()` rather than `then()`. You can > > take a

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 20, 2016, 6:37 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review142528 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review142510 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp (line

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 15, 2016, 3:32 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 15, 2016, 3 a.m.) Review request for mesos, Gilbert Song, Jie Yu,

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review142325 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 14, 2016, 5:15 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 13, 2016, 6:45 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review141613 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review141586 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 9, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song, Jie

Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository: mes