Re: Review Request 57952: Added 'config' plugin to the new CLI.

2017-05-02 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/#review173666 --- As part of this patch , I expected `main.py` to be updated to expl

Re: Review Request 57952: Added 'config' plugin to the new CLI.

2017-04-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/#review171976 --- Ship it! LGTM. src/cli_new/lib/cli/plugins/config/main.py Lin

Re: Review Request 57952: Added 'config' plugin to the new CLI.

2017-04-12 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/ --- (Updated April 12, 2017, 9:19 a.m.) Review request for mesos, Joseph Wu and Kev

Re: Review Request 57952: Added 'config' plugin to the new CLI.

2017-04-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/#review171650 --- src/cli_new/lib/cli/plugins/config/main.py Lines 54-62 (patched)

Re: Review Request 57952: Added 'config' plugin to the new CLI.

2017-04-11 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/ --- (Updated April 11, 2017, 2:52 p.m.) Review request for mesos, Joseph Wu and Kev

Re: Review Request 57952: Added 'config' plugin to the new CLI.

2017-04-09 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/ --- (Updated April 10, 2017, 6:37 a.m.) Review request for mesos, Joseph Wu and Kev

Re: Review Request 57952: Added 'config' plugin to the new CLI.

2017-04-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/#review171299 --- src/cli_new/lib/mesos/plugins/config/main.py Lines 77-90 (patched

Re: Review Request 57952: Added 'config' plugin to the new CLI.

2017-04-06 Thread Joseph Wu
> On April 5, 2017, 5:10 p.m., Kevin Klues wrote: > > src/cli_new/lib/mesos/plugins/config/main.py > > Lines 96-102 (patched) > > > > > > I would actually leverage the Table abstraction to print th eplugins > > here.

Re: Review Request 57952: Added 'config' plugin to the new CLI.

2017-04-05 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/#review171180 --- src/cli_new/lib/mesos/plugins/config/main.py Lines 96-102 (patche

Re: Review Request 57952: Added 'config' plugin to the new CLI.

2017-03-31 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/#review170794 --- Patch looks great! Reviews applied: [57896, 57951, 57952] Passed

Re: Review Request 57952: Added 'config' plugin to the new CLI.

2017-03-27 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/#review170237 --- I think we should strip everything out of this commit except the p

Re: Review Request 57952: Added 'config' plugin to the new CLI.

2017-03-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/#review170166 --- Patch looks great! Reviews applied: [57896, 57951, 57952] Passed

Re: Review Request 57952: Added 'config' plugin to the new CLI.

2017-03-27 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/ --- (Updated March 27, 2017, noon) Review request for mesos and Kevin Klues. Bugs

Review Request 57952: Added 'config' plugin to the new CLI.

2017-03-27 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/ --- Review request for mesos. Repository: mesos Description --- Used to show