Re: Review Request 61798: Added _EXIT as alternative to ABORT.

2017-08-30 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61798/#review184130 --- 3rdparty/stout/include/stout/exit.hpp Lines 42 (patched)

Re: Review Request 61798: Added _EXIT as alternative to ABORT.

2017-08-29 Thread Andrei Budnik
> On Aug. 29, 2017, 2:47 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/exit.hpp > > Lines 37 (patched) > > > > > > What do you think about re-declaring `google::RawLog__` here with the > > [format > >

Re: Review Request 61798: Added _EXIT as alternative to ABORT.

2017-08-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61798/#review184054 --- Fix it, then Ship it! 3rdparty/stout/include/stout/exit.hpp

Re: Review Request 61798: Added _EXIT as alternative to ABORT.

2017-08-25 Thread Andrei Budnik
> On Aug. 24, 2017, 10:59 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/exit.hpp > > Lines 39 (patched) > > > > > > Move this comment to the `_EXIT()` macro. Done. > On Aug. 24, 2017, 10:59 p.m., James

Re: Review Request 61798: Added _EXIT as alternative to ABORT.

2017-08-24 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61798/#review183755 --- 3rdparty/stout/include/stout/exit.hpp Lines 39 (patched)

Re: Review Request 61798: Added _EXIT as alternative to ABORT.

2017-08-23 Thread Andrei Budnik
> On Aug. 22, 2017, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/stout/include/stout/exit.hpp > > Lines 42 (patched) > > > > > > Shouldn't we use `CRLF` on Windows? I can't find a new line macro. BTW, `ABORT`

Re: Review Request 61798: Added _EXIT as alternative to ABORT.

2017-08-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61798/#review183462 --- 3rdparty/stout/include/stout/exit.hpp Lines 42 (patched)

Review Request 61798: Added _EXIT as alternative to ABORT.

2017-08-21 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61798/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin