Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/ --- (Updated Feb. 22, 2018, 1:44 a.m.) Review request for mesos, Alexander

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/#review197852 --- Fix it, then Ship it! src/checks/checker.cpp Lines 41

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/#review197817 --- Ship it! Ship It! - Joseph Wu On Feb. 8, 2018, 9:49 a.m.,

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/#review197366 --- I like what I see. Just a few little things to discuss.

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/#review197338 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 8, 2018,

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

> On Feb. 8, 2018, 2:49 p.m., Gaston Kleiman wrote: > > src/checks/checker_process.cpp > > Lines 333-339 (patched) > > > > > > In my opinion the following is easier to understand: > > > > ``` > > #ifdef

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

> On Feb. 8, 2018, 10:49 p.m., Gaston Kleiman wrote: > > src/checks/checker_process.cpp > > Lines 333-339 (patched) > > > > > > In my opinion the following is easier to understand: > > > > ``` > >

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

> On Feb. 7, 2018, 1:35 p.m., Alexander Rukletsov wrote: > > src/checks/checker.cpp > > Line 86 (original), 89 (patched) > > > > > > please no abbreviations like this, it is unclear what this function > > does. Is

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/#review197123 --- src/checks/checker_process.cpp Lines 97-100 (original), 100-103

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/#review197118 --- Thanks for this refactoring, the code looks much better and is

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

> On Feb. 7, 2018, 1:35 p.m., Alexander Rukletsov wrote: > > src/checks/checker.cpp > > Line 86 (original), 89 (patched) > > > > > > please no abbreviations like this, it is unclear what this function > > does. Is

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

> On Feb. 2, 2018, 9:27 p.m., Andrew Schwartzmeyer wrote: > > src/checks/checker_process.hpp > > Lines 143-148 (original) > > > > > > Leaving a note to make sure this comment was kept around. thanks for catching

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/ --- (Updated Feb. 8, 2018, 5:49 p.m.) Review request for mesos, Alexander

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

> On Feb. 7, 2018, 1:35 p.m., Alexander Rukletsov wrote: > > src/checks/checker.cpp > > Line 86 (original), 89 (patched) > > > > > > please no abbreviations like this, it is unclear what this function > > does. Is

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/#review196987 --- src/checks/checker.hpp Lines 120-122 (original), 87-89 (patched)

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/#review196728 --- src/checks/checker.hpp Lines 92-93 (original), 62-63 (patched)

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/ --- (Updated Jan. 30, 2018, 10:06 a.m.) Review request for mesos, Alexander

Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/ --- Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston