Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

> On Oct. 24, 2018, 11:21 a.m., Joseph Wu wrote: > > We could probably do away with some of the double-negatives (i.e. `not > > UNBUNDLED` -> `BUNDLED`) in the new variable names and logic. > > Till Toenshoff wrote: > That one I would prefer to change, if needed, within a new RR as I am >

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review210187 --- Ship it! Ship It! - Joseph Wu On Oct. 30, 2018, 1:20 p.m.,

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

> On Oct. 24, 2018, 6:21 p.m., Joseph Wu wrote: > > We could probably do away with some of the double-negatives (i.e. `not > > UNBUNDLED` -> `BUNDLED`) in the new variable names and logic. That one I would prefer to change, if needed, within a new RR as I am strictly following the logic path

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

> On Oct. 24, 2018, 6:21 p.m., Joseph Wu wrote: > > 3rdparty/cmake/FindLIBARCHIVE.cmake > > Lines 21-24 (patched) > > > > > > Prefix this with: > > ``` > > # NOTE: If this fails, stderr is ignored, and the

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/ --- (Updated Oct. 30, 2018, 8:20 p.m.) Review request for mesos, Andrew

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review209976 --- We could probably do away with some of the double-negatives (i.e.

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review209962 --- PASS: Mesos patch 69140 was successfully built and tested.

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review209956 --- 3rdparty/cmake/FindLIBARCHIVE.cmake Lines 19 (patched)

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review209953 --- 3rdparty/CMakeLists.txt Line 998 (original), 998 (patched)

Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, James Peach,