Re: Review Request 69157: Fixed handling for offer operation updates.

2018-11-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/#review210932 --- Ship it! Ship It! - Greg Mann On Nov. 27, 2018, 5:59 p.m., B

Re: Review Request 69157: Fixed handling for offer operation updates.

2018-11-27 Thread Greg Mann
> On Nov. 27, 2018, 11:40 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Line 8037 (original), 8037 (patched) > > > > > > Hmm it looks like Chun-Hung's comment was resolved, but this line still > > uses `update

Re: Review Request 69157: Fixed handling for offer operation updates.

2018-11-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/#review210897 --- src/slave/slave.cpp Lines 8016-8037 (original), 8016-8037 (patche

Re: Review Request 69157: Fixed handling for offer operation updates.

2018-11-27 Thread Benjamin Bannier
> On Nov. 20, 2018, 8:05 p.m., Chun-Hung Hsiao wrote: > > Could you update the commit message accordingly? Do you have a suggestion? - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 69157: Fixed handling for offer operation updates.

2018-11-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/ --- (Updated Nov. 27, 2018, 6:59 p.m.) Review request for mesos, Chun-Hung Hsiao an

Re: Review Request 69157: Fixed handling for offer operation updates.

2018-11-20 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/#review210737 --- Fix it, then Ship it! Could you update the commit message accor

Re: Review Request 69157: Fixed handling for offer operation updates.

2018-11-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/ --- (Updated Nov. 20, 2018, 6:50 p.m.) Review request for mesos, Chun-Hung Hsiao an

Re: Review Request 69157: Fixed handling for offer operation updates.

2018-11-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/#review210692 --- src/slave/slave.cpp Line 8017 (original), 8017 (patched)

Re: Review Request 69157: Fixed handling for offer operation updates.

2018-11-14 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/#review210540 --- Ship it! Ship It! - Jan Schlicht On Nov. 13, 2018, 10:10 p.m

Re: Review Request 69157: Fixed handling for offer operation updates.

2018-11-13 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/ --- (Updated Nov. 13, 2018, 10:10 p.m.) Review request for mesos, Chun-Hung Hsiao a

Review Request 69157: Fixed handling for offer operation updates.

2018-10-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-8403