Review Request 70216: Implemented the recovery logic for v0 `VolumeManager`.

2019-03-14 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70216/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Re: Review Request 70216: Implemented the recovery logic for v0 `VolumeManager`.

2019-03-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70216/#review213840 --- Let's squash the corresponding changes from https://reviews.apache

Re: Review Request 70216: Implemented the recovery logic for v0 `VolumeManager`.

2019-03-21 Thread Chun-Hung Hsiao
> On March 20, 2019, 3:13 p.m., Benjamin Bannier wrote: > > src/csi/v0_volume_manager.cpp > > Lines 440 (patched) > > > > > > Should we have used an `Option` for this member? I'm relying on the fact that the default

Re: Review Request 70216: Implemented the recovery logic for v0 `VolumeManager`.

2019-03-21 Thread Chun-Hung Hsiao
> On March 20, 2019, 3:13 p.m., Benjamin Bannier wrote: > > src/csi/v0_volume_manager_process.hpp > > Lines 176 (patched) > > > > > > Can or should this be `const`? Although this can, it has a side effect that's not