Re: Review Request 72221: Added agent validation for shared cgroups.

> On March 20, 2020, 7:07 a.m., Qian Zhang wrote: > > src/slave/validation.cpp > > Lines 492 (patched) > > > > > > Why do we need this line? To backward compatible with how standalone > > containers are launched

Re: Review Request 72221: Added agent validation for shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72221/#review220030 --- Fix it, then Ship it! src/slave/validation.cpp Lines 492

Re: Review Request 72221: Added agent validation for shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72221/ --- (Updated March 20, 2020, 12:36 a.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72221: Added agent validation for shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72221/ --- (Updated March 19, 2020, 9:08 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72221: Added agent validation for shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72221/#review220001 --- src/slave/validation.cpp Line 285 (original), 298-299 (patched)

Re: Review Request 72221: Added agent validation for shared cgroups.

> On March 15, 2020, 2:05 p.m., Qian Zhang wrote: > > src/slave/validation.cpp > > Lines 460-465 (patched) > > > > > > Why do we need this check? I removed this. > On March 15, 2020, 2:05 p.m., Qian Zhang wrote:

Re: Review Request 72221: Added agent validation for shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72221/ --- (Updated March 19, 2020, 2:11 a.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72221: Added agent validation for shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72221/#review219940 --- src/slave/validation.cpp Line 395 (original), 406 (patched)

Re: Review Request 72221: Added agent validation for shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72221/#review219935 --- src/slave/validation.cpp Lines 460 (patched)

Re: Review Request 72221: Added agent validation for shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72221/ --- (Updated March 12, 2020, 4:12 p.m.) Review request for mesos, Andrei Budnik

Review Request 72221: Added agent validation for shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72221/ --- Review request for mesos, Andrei Budnik and Qian Zhang. Bugs: MESOS-10045