> On Dec. 3, 2017, 10:53 p.m., Zhitao Li wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp
> > Lines 465 (patched)
> > <https://reviews.apache.org/r/64271/diff/1/?file=1906562#file1906562line465>
> >
> > Why do we need a master?
Never min
>
> (Updated Dec. 2, 2017, 1:10 a.m.)
>
>
> Review request for mesos, Jie Yu, Qian Zhang, Vinod Kone, and Zhitao Li.
>
>
> Bugs: MESOS-8294
> https://issues.apache.org/jira/browse/MESOS-8294
>
>
> Reposit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64264/#review193026
---
Ship it!
Ship It!
- Zhitao Li
On Dec. 6, 2017, 6:52 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64265/#review193027
---
Ship it!
Ship It!
- Zhitao Li
On Dec. 6, 2017, 7:07 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64266/#review193028
---
Ship it!
Ship It!
- Zhitao Li
On Dec. 6, 2017, 7:09 p.m
(original), 6231 (patched)
<https://reviews.apache.org/r/64267/#comment271521>
I feel that an early return makes the code more readable.
- Zhitao Li
On Dec. 6, 2017, 7:13 p.m., Gilbert Song wrote:
>
> ---
> This is a
/64558/diff/1/
Testing
---
make
Thanks,
Zhitao Li
/quota_handler.cpp 6590519d8440f352f5bf00fda805414a5aad725c
src/tests/master_quota_tests.cpp 9ce7e2e481706c74f080d54b6f58d57874a27e64
Diff: https://reviews.apache.org/r/47222/diff/
Testing
---
Adding tests in MasterQuotaTest.
Thanks,
Zhitao Li
tps://reviews.apache.org/r/47222/#comment196868>
Please advise if we should define "/quota" as a member const of
`QuotaHandler` class.
- Zhitao Li
On May 11, 2016, 6:14 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically g
9ce7e2e481706c74f080d54b6f58d57874a27e64
Diff: https://reviews.apache.org/r/47274/diff/
Testing
---
Unit test.
Thanks,
Zhitao Li
MasterQuotaTest.
Thanks,
Zhitao Li
by using vector::const_iterator to loop in it. It
should be no difference interface wise.
- Zhitao Li
On May 12, 2016, 12:48 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
3e55114ee7866e06513071e86e15608099dae052
src/master/quota_handler.cpp 6590519d8440f352f5bf00fda805414a5aad725c
src/tests/master_quota_tests.cpp 9ce7e2e481706c74f080d54b6f58d57874a27e64
Diff: https://reviews.apache.org/r/47274/diff/
Testing
---
Unit test.
Thanks,
Zhitao Li
3e55114ee7866e06513071e86e15608099dae052
src/master/quota_handler.cpp 6590519d8440f352f5bf00fda805414a5aad725c
src/tests/master_quota_tests.cpp 9ce7e2e481706c74f080d54b6f58d57874a27e64
Diff: https://reviews.apache.org/r/47274/diff/
Testing
---
Unit test.
Thanks,
Zhitao Li
6590519d8440f352f5bf00fda805414a5aad725c
src/tests/authorization_tests.cpp f50ac69c32d0551a63391d97f31559ff4f414011
src/tests/master_quota_tests.cpp 9ce7e2e481706c74f080d54b6f58d57874a27e64
Diff: https://reviews.apache.org/r/47399/diff/
Testing
---
Unit tests.
Thanks,
Zhitao Li
/quota.md 797e134605381ae576d9aa93875e0314889ab047
docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9
Diff: https://reviews.apache.org/r/47400/diff/
Testing
---
Thanks,
Zhitao Li
/
Testing
---
Unit test.
Thanks,
Zhitao Li
tps://reviews.apache.org/r/47274/#comment197960>
It'll be great if we can either catch this in linter/commit hook during
`git commit`, or publish .vimrc/etc so contributors don't need to remember this.
- Zhitao Li
On May 17, 2016, 5:06 a.m.,
---
On May 17, 2016, 5:06 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47274/
>
testing using local authorizer.
Thanks,
Zhitao Li
Should be get_quotas.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47399/#review133537
---
On May 17,
://reviews.apache.org/r/47399/diff/
Testing
---
Unit tests.
Thanks,
Zhitao Li
6
Diff: https://reviews.apache.org/r/47399/diff/
Testing
---
Unit tests.
Thanks,
Zhitao Li
://reviews.apache.org/r/47400/diff/
Testing
---
Thanks,
Zhitao Li
mail. To reply, visit:
https://reviews.apache.org/r/47399/#review133615
---
On May 17, 2016, 6:26 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. T
/diff/
Testing (updated)
---
1. Unit tests;
2. Manually tested cases: authorized and forbidden under both deprecated
set_quotas/remove_quotas and new update_quotas, as well as the case that
specifying both triggers master crash.
Thanks,
Zhitao Li
/diff/
Testing
---
Thanks,
Zhitao Li
an anchor before ones without.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133865
---
On May 18, 2016,
/47400/diff/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/48751/diff/
Testing
---
New test in MasterAPITest.
Thanks,
Zhitao Li
cpp db625f0d656f207a89fcc14b18ae2fc31d30e673
src/master/master.hpp a0944ddccd3a4b33458cd2489bb5fcdbbdc55720
src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0
Diff: https://reviews.apache.org/r/48751/diff/
Testing
---
New test in MasterAPITest.
Thanks,
Zhitao Li
in
src/internal/evolve.hpp, since it's pretty common that we need to promote
`Task` to `v1::Task`.
- Zhitao Li
On June 17, 2016, 8:17 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. T
tps://reviews.apache.org/r/48877/#comment203478>
Move this line next to `v1::master::Response` so it's easy to find?
- Zhitao Li
On June 17, 2016, 8:17 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-m
g/r/48879/#comment203482>
How will the `devolve()` handle the enum value that's not declared in its
own enum?
This switch/case block is strange anyway in that enum values could belong
to different namespaces...
- Zhitao Li
On June 17, 2016, 8:16 p.m., Anand Maz
.
- Zhitao Li
On June 17, 2016, 8:17 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
://reviews.apache.org/r/48902/diff/
Testing (updated)
---
run `make` on Mac.
Thanks,
Zhitao Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48875/#review138602
---
Ship it!
Ship It!
- Zhitao Li
On June 17, 2016, 8:17 p.m
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48928/
> ---
>
> (Updated June 19, 2016, 7:30 p.m.)
>
>
> Rev
--
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48879/
> ---
>
> (Updated June 17, 2016, 8:52 p.m.)
>
>
> Review requ
-----------
On June 18, 2016, 6:36 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48902/
> ---
gt; > allocator is the master-only component.
>
> Zhitao Li wrote:
> Alexander, so what's your recommendation here? Given that there is only
> one public visible message `InverseOfferStatus` in this protobuf at the
> moment, I'd like to have a quick fix to make sure
in MasterAPITest.
Thanks,
Zhitao Li
.
Sounds good for top level in this file. Will do.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48751/#review138723
-------
On June 21, 2016, 9:37 p.m., Zhitao Li wrote:
>
>
patch, so
I don't feel it's this patch's job to solve.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48751/#review138950
---------
7daaf12a4086635bbc5aba5e3375c95e8899ac6e
src/master/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4
src/tests/api_tests.cpp bf1a294f1fc3c8659c31115beee3876d4d0a45e2
Diff: https://reviews.apache.org/r/48751/diff/
Testing
---
New test in MasterAPITest.
Thanks,
Zhitao Li
tps://reviews.apache.org/r/48751/#comment204229>
Agreed. I think changing `required` mentioned in this patch to `optional`
is good since the API here is still progressing.
@vinodkone, what's your opinion?
- Zhitao Li
On June 22, 2016, 6:13 a.m., Zhit
is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48751/#review139019
-------
On June 22, 2016, 6:13 a.m., Zhitao Li wrote:
>
> ---
> This
7daaf12a4086635bbc5aba5e3375c95e8899ac6e
src/master/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4
src/tests/api_tests.cpp bf1a294f1fc3c8659c31115beee3876d4d0a45e2
Diff: https://reviews.apache.org/r/48751/diff/
Testing
---
New test in MasterAPITest.
Thanks,
Zhitao Li
d66186217c1319d4497640614ed4beee28602c38
src/Makefile.am 23cac95a805e46d216e9479fea09f2c1619c45a5
Diff: https://reviews.apache.org/r/48902/diff/
Testing
---
run `make` on Mac.
Thanks,
Zhitao Li
://reviews.apache.org/r/48902/#review138709
-------
On June 22, 2016, 6:19 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. T
/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9
src/tests/reservation_tests.cpp 2cc352d230f5ba8ca15698b09a44377c6af53913
Diff: https://reviews.apache.org/r/49118/diff/
Testing
---
`make && make check` on mac.
Thanks,
Zhitao Li
11dfab318eb073908a9e302afa33b274fec63a16
src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e
src/tests/api_tests.cpp bf1a294f1fc3c8659c31115beee3876d4d0a45e2
Diff: https://reviews.apache.org/r/49129/diff/
Testing
---
make check
Thanks,
Zhitao Li
Diff: https://reviews.apache.org/r/49130/diff/
Testing
---
make check
Thanks,
Zhitao Li
collect(approvers);
> }
> ```
Created https://reviews.apache.org/r/49130 to fix in separate patch.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
/master.proto 11dfab318eb073908a9e302afa33b274fec63a16
src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e
src/tests/api_tests.cpp bf1a294f1fc3c8659c31115beee3876d4d0a45e2
Diff: https://reviews.apache.org/r/49129/diff/
Testing
---
make check
Thanks,
Zhitao Li
an you take a look at new messages defined at
https://reviews.apache.org/r/48751/ and comment on what additions or changes we
need for them?
- Zhitao Li
On June 23, 2016, 3:15 p.m., Jay Guo wrote:
>
> ---
> This is an automatica
il we have consensus
about what to do with agents.
What do you think?
- Zhitao Li
On June 22, 2016, 5 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. T
g/r/49166/#comment204495>
This shouldn't be here
- Zhitao Li
On June 23, 2016, 8:07 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
: https://reviews.apache.org/r/49118/diff/
Testing
---
`make && make check` on mac.
Thanks,
Zhitao Li
tps://reviews.apache.org/r/49136/#comment204580>
Given current conversations with Vinod and Anand, we still want to keep
fileds that always have a value as `required`, and the leave the task of
upgrading to proto3 in a separate sweeping epic.
This also has the benefit of clear API.
- Zhi
fo`), three resources fiels split by use cases,
- Zhitao Li
On June 23, 2016, 5:13 a.m., zhou xing wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
/r/48902/diff/
Testing
---
run `make` on Mac.
Thanks,
Zhitao Li
://reviews.apache.org/r/49118/diff/
Testing
---
`make && make check` on mac.
Thanks,
Zhitao Li
to unblock me for GetState. Thanks.
include/mesos/v1/master/master.proto (line 296)
<https://reviews.apache.org/r/49136/#comment204841>
Should this be required? I guess that's the case for any custom executor
type, but I'm not sure about CommandExecutor.
- Zhitao Li
On Jun
tps://reviews.apache.org/r/48841/#comment204844>
Should we use `VersionInfo` for `version`?
- Zhitao Li
On June 27, 2016, 9:01 a.m., zhou xing wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
> On June 27, 2016, 4:36 p.m., Zhitao Li wrote:
> > include/mesos/v1/master/master.proto, line 287
> > <https://reviews.apache.org/r/48841/diff/5/?file=1430819#file1430819line287>
> >
> > Should we use `VersionInfo` for `version`?
>
> Vinod
681ea1e638777059a6bf792435cbe526bc252f7a
Diff: https://reviews.apache.org/r/49321/diff/
Testing
---
`make` on Mac
Thanks,
Zhitao Li
/master/master.proto 681ea1e638777059a6bf792435cbe526bc252f7a
Diff: https://reviews.apache.org/r/49321/diff/
Testing
---
`make` on Mac
Thanks,
Zhitao Li
add that, to be consistent with other
calls?
include/mesos/v1/master/master.proto (line 283)
<https://reviews.apache.org/r/49321/#comment205235>
See comments above.
- Zhitao Li
On June 28, 2016, 3:07 p.m., Zhitao Li wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49418/#review140105
---
Ship it!
- Zhitao Li
On June 30, 2016, 1:33 a.m., Vinod Kone
completed task instead?
Alternatively, a TODO for verifying completed_tasks is good. I can help
write the patch later.
- Zhitao Li
On June 30, 2016, 1:35 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e
tps://reviews.apache.org/r/49420/#comment205407>
Just for discussion: we will refactor this function into a helper function
returning a `Future` when we get to
reuse it for `GetState`.
- Zhitao Li
On June 30, 2016, 2:09 a.m., Vinod Kone
.
include/mesos/master/master.proto (line 364)
<https://reviews.apache.org/r/49464/#comment205608>
same, sequence number should be 1
include/mesos/v1/master/master.proto (line 365)
<https://reviews.apache.org/r/49464/#comment205607>
The sequence number should be 1
- Zh
tps://reviews.apache.org/r/49465/#comment205611>
FYI, I will refactor the primary body of this function into a
`_getExecutors` which returns a
`Future`, then reuse it with `GetState`.
No action is needed from your side.
- Zhitao Li
On June 30, 2016, 7:04 p.m., haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49465/#review140259
---
Ship it!
Looks good for building GetState on top.
- Zhitao Li
tps://reviews.apache.org/r/49464/#comment205662>
I think this also does not apply cleanly on master anymore after
Task/Framework patch. Can you rebase?
- Zhitao Li
On June 30, 2016, 7:04 p.m., haosdent huang wrote:
>
> ---
> This is a
g/r/47973/#comment205668>
This should also be guarded by `#ifdef __linux__`
- Zhitao Li
On June 23, 2016, 5:32 p.m., Megha Sharma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
7388a3e7f3a0c9f0a2a286a8c8107210971b654a
Diff: https://reviews.apache.org/r/49487/diff/
Testing
---
make check
Thanks,
Zhitao Li
/49488/diff/
Testing
---
Thanks,
Zhitao Li
Diff: https://reviews.apache.org/r/49488/diff/
Testing (updated)
---
make check
Thanks,
Zhitao Li
528f01f2e00ddbd15da1cc4fca27b5347c9fc798
src/master/master.hpp 7388a3e7f3a0c9f0a2a286a8c8107210971b654a
Diff: https://reviews.apache.org/r/49488/diff/
Testing
---
make check
Thanks,
Zhitao Li
/49489/diff/
Testing
---
make check
Thanks,
Zhitao Li
-
src/master/http.cpp 528f01f2e00ddbd15da1cc4fca27b5347c9fc798
src/master/master.hpp 7388a3e7f3a0c9f0a2a286a8c8107210971b654a
Diff: https://reviews.apache.org/r/49487/diff/
Testing
---
make check
Thanks,
Zhitao Li
-
src/master/http.cpp 528f01f2e00ddbd15da1cc4fca27b5347c9fc798
src/master/master.hpp 7388a3e7f3a0c9f0a2a286a8c8107210971b654a
Diff: https://reviews.apache.org/r/49487/diff/
Testing
---
make check
Thanks,
Zhitao Li
,
Zhitao Li
be reused for `GetState`.
Diffs
-
src/master/http.cpp 528f01f2e00ddbd15da1cc4fca27b5347c9fc798
src/master/master.hpp 7388a3e7f3a0c9f0a2a286a8c8107210971b654a
Diff: https://reviews.apache.org/r/49487/diff/
Testing
---
make check
Thanks,
Zhitao Li
`GET_STATE` calls.
Diffs (updated)
-
src/master/http.cpp 528f01f2e00ddbd15da1cc4fca27b5347c9fc798
src/master/master.hpp 7388a3e7f3a0c9f0a2a286a8c8107210971b654a
Diff: https://reviews.apache.org/r/49489/diff/
Testing
---
make check
Thanks,
Zhitao Li
/master.hpp 7388a3e7f3a0c9f0a2a286a8c8107210971b654a
Diff: https://reviews.apache.org/r/49489/diff/
Testing
---
make check
Thanks,
Zhitao Li
,
Zhitao Li
/mesos/v1/master/master.proto f6155dfacfbd98efaf72b337b73cc950c0f3b7c3
Diff: https://reviews.apache.org/r/49509/diff/
Testing
---
make check
Thanks,
Zhitao Li
7388a3e7f3a0c9f0a2a286a8c8107210971b654a
Diff: https://reviews.apache.org/r/49516/diff/
Testing
---
make check
Thanks,
Zhitao Li
7388a3e7f3a0c9f0a2a286a8c8107210971b654a
src/tests/api_tests.cpp a7f075172f870bcd3ac7fb9c7a69b70ac5cb73c5
Diff: https://reviews.apache.org/r/49517/diff/
Testing
---
make check
Thanks,
Zhitao Li
f6155dfacfbd98efaf72b337b73cc950c0f3b7c3
src/master/http.cpp 528f01f2e00ddbd15da1cc4fca27b5347c9fc798
src/tests/api_tests.cpp a7f075172f870bcd3ac7fb9c7a69b70ac5cb73c5
Diff: https://reviews.apache.org/r/49518/diff/
Testing
---
Updated test and make check.
Thanks,
Zhitao Li
also be reused for `GetState`.
Diffs (updated)
-
src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe
src/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1
Diff: https://reviews.apache.org/r/49487/diff/
Testing
---
make check
Thanks,
Zhitao Li
(updated)
-
src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe
src/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1
Diff: https://reviews.apache.org/r/49488/diff/
Testing
---
make check
Thanks,
Zhitao Li
/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1
Diff: https://reviews.apache.org/r/49489/diff/
Testing
---
make check
Thanks,
Zhitao Li
GetState response.
Diffs (updated)
-
include/mesos/master/master.proto d06258e9fd39c7eefd8ecd394e3bdfb888479b1e
include/mesos/v1/master/master.proto b7cb6fdf2e4f34a11d326ac3ad3ec26525f8f343
Diff: https://reviews.apache.org/r/49509/diff/
Testing
---
make check
Thanks,
Zhitao Li
;
> > ditto. move this to GetLeadingMaster
Ditto.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49509/#review140409
-------
7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe
src/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1
Diff: https://reviews.apache.org/r/49516/diff/
Testing
---
make check
Thanks,
Zhitao Li
7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe
src/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1
src/tests/api_tests.cpp e2d8bf591667ec9d8c609e55a424b55561892b5f
Diff: https://reviews.apache.org/r/49517/diff/
Testing
---
make check
Thanks,
Zhitao Li
501 - 600 of 929 matches
Mail list logo
