[GitHub] spark pull request: [SPARK-3994] Use standard Aggregator code path...

2014-10-20 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2839#issuecomment-59813859 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-3736] Workers reconnect when disassocia...

2014-10-20 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/2828#issuecomment-59814026 sure, I created the JIRA: https://issues.apache.org/jira/browse/SPARK-4011 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-3994] Use standard Aggregator code path...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2839#issuecomment-59814936 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21925/consoleFull) for PR 2839 at commit [`d6fdb2a`](https://github.com/ap

[GitHub] spark pull request: [SPARK-3736] Workers reconnect when disassocia...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2828#issuecomment-59814881 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21926/consoleFull) for PR 2828 at commit [`83f8bc9`](https://github.com/ap

[GitHub] spark pull request: [SPARK-3736] Workers reconnect when disassocia...

2014-10-20 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2828#issuecomment-59815368 This looks good to me. Thanks! I'm going to merge this into `master`. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-4009][SQL]HiveTableScan should use make...

2014-10-20 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2857#issuecomment-59816505 This isn't a valid change since different partitions of a table can have different serializers. As a result I think we should close this issue. --- If your project is

[GitHub] spark pull request: [SPARK-3207][MLLIB]Choose splits for continuou...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2780#issuecomment-59816513 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/404/consoleFull) for PR 2780 at commit [`18d0301`](https://github.com/a

[GitHub] spark pull request: [SPARK-4003] [SQL] add 3 types for java SQL co...

2014-10-20 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2850#issuecomment-59816592 Can you add some tests too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3207][MLLIB]Choose splits for continuou...

2014-10-20 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/2780#issuecomment-59816923 @chouqin Thanks for the update! LGTM once the tests pass. @manishamde At some point, I hope the histogram functionality can be part of mllib/statistics/ espe

[GitHub] spark pull request: Initial time estimator with new column for rem...

2014-10-20 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2837#issuecomment-59817009 @devldevelopment Yeah, let's close that JIRA. If you're looking for some small tasks to start with, check out the issues labeled 'starter': https://is

[GitHub] spark pull request: [SPARK-3986][SQL] Fix package names to fit the...

2014-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2835 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-3736] Workers reconnect when disassocia...

2014-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2828 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-4006] Block Manager - Double Register C...

2014-10-20 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2854#issuecomment-59819006 Hey @tsliwowicz thanks for fixing this inconsistency. Since this is an issue affecting the most recent version of Spark as well, would you mind opening a PR against th

[GitHub] spark pull request: [SPARK-4006] Block Manager - Double Register C...

2014-10-20 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/2854#discussion_r19104791 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala --- @@ -223,18 +231,24 @@ class BlockManagerMasterActor(val isLocal: B

[GitHub] spark pull request: [SPARK-4006] Block Manager - Double Register C...

2014-10-20 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/2854#discussion_r19104882 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala --- @@ -223,18 +231,24 @@ class BlockManagerMasterActor(val isLocal: B

[GitHub] spark pull request: [SPARK-4006] Block Manager - Double Register C...

2014-10-20 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/2854#discussion_r19105067 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala --- @@ -160,6 +165,8 @@ class BlockManagerMasterActor(val isLocal: Boo

[GitHub] spark pull request: [SPARK-3984] [SPARK-3983] Improve UI task metr...

2014-10-20 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2832#issuecomment-59820203 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-3967] don’t redundantly overwrite exe...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2848#issuecomment-59820947 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21924/consoleFull) for PR 2848 at commit [`5f1a6f1`](https://github.com/a

[GitHub] spark pull request: [SPARK-3967] don’t redundantly overwrite exe...

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2848#issuecomment-59820962 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: [SPARK-3984] [SPARK-3983] Improve UI task metr...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2832#issuecomment-59821191 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21927/consoleFull) for PR 2832 at commit [`81fb86b`](https://github.com/ap

[GitHub] spark pull request: [SPARK-3984] [SPARK-3983] Improve UI task metr...

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2832#issuecomment-59821363 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: [SPARK-3984] [SPARK-3983] Improve UI task metr...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2832#issuecomment-59821358 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21927/consoleFull) for PR 2832 at commit [`81fb86b`](https://github.com/a

[GitHub] spark pull request: [WIP][SPARK-3822] Executor scaling mechanism f...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2840#issuecomment-59821936 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21928/consoleFull) for PR 2840 at commit [`572f5c5`](https://github.com/ap

[GitHub] spark pull request: [SPARK-3994] Use standard Aggregator code path...

2014-10-20 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/2839#issuecomment-59822350 LGTM provided it passes tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-3994] Use standard Aggregator code path...

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2839#issuecomment-59822749 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: [SPARK-3994] Use standard Aggregator code path...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2839#issuecomment-59822742 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21925/consoleFull) for PR 2839 at commit [`d6fdb2a`](https://github.com/a

[GitHub] spark pull request: [SPARK-3736] Workers reconnect when disassocia...

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2828#issuecomment-59823491 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: [SPARK-3736] Workers reconnect when disassocia...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2828#issuecomment-59823485 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21926/consoleFull) for PR 2828 at commit [`83f8bc9`](https://github.com/a

[GitHub] spark pull request: [SPARK-3736] Workers reconnect when disassocia...

2014-10-20 Thread mccheah
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/2828#issuecomment-59824518 The PR doesn't seem to be related to the unit tests that failed. How shall we tackle this issue? --- If your project is set up for it, you can reply to this email and ha

[GitHub] spark pull request: [SPARK-3984] [SPARK-3983] Improve UI task metr...

2014-10-20 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/2832#issuecomment-59824830 @kayousterhout - This is failing scalastyle checks -- Could you run style check locally ? --- If your project is set up for it, you can reply to this email and have you

[GitHub] spark pull request: [SPARK-3207][MLLIB]Choose splits for continuou...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2780#issuecomment-59826477 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/404/consoleFull) for PR 2780 at commit [`18d0301`](https://github.com/

[GitHub] spark pull request: [WIP][SPARK-3822] Executor scaling mechanism f...

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2840#issuecomment-59829310 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: [WIP][SPARK-3822] Executor scaling mechanism f...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2840#issuecomment-59829303 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21928/consoleFull) for PR 2840 at commit [`572f5c5`](https://github.com/a

[GitHub] spark pull request: replace awaitTransformation with awaitTerminat...

2014-10-20 Thread holdenk
GitHub user holdenk opened a pull request: https://github.com/apache/spark/pull/2861 replace awaitTransformation with awaitTermination in scaladoc/javadoc You can merge this pull request into a Git repository by running: $ git pull https://github.com/holdenk/spark SPARK-4015-

[GitHub] spark pull request: replace awaitTransformation with awaitTerminat...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2861#issuecomment-59831331 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21929/consoleFull) for PR 2861 at commit [`0e03863`](https://github.com/ap

[GitHub] spark pull request: [SPARK-3720][SQL]initial support ORC in spark ...

2014-10-20 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2576#issuecomment-59831796 Have addressed the comments and made changes as follows: 1 reuse code of TableReader for table scan 2 support all data types 3 move ```saveAsOrcFile``` and ```Writ

[GitHub] spark pull request: [SPARK-3207][MLLIB]Choose splits for continuou...

2014-10-20 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2780#issuecomment-59831875 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-2759][CORE] Generic Binary File Support...

2014-10-20 Thread kmader
Github user kmader commented on the pull request: https://github.com/apache/spark/pull/1658#issuecomment-59832070 So I made the requested changes and added a few more tests, but the tests appear to have not run for a strange reason: https://amplab.cs.berkeley.edu/jenkins/job/SparkPull

[GitHub] spark pull request: [SPARK-3207][MLLIB]Choose splits for continuou...

2014-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2780 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-3736] Workers reconnect when disassocia...

2014-10-20 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2828#issuecomment-59833561 Don't worry about it. This test is a little flaky and will be fixed shortly. I highly doubt that the test failure is caused by this PR. --- If your project is set up

[GitHub] spark pull request: [SPARK-3720][SQL]initial support ORC in spark ...

2014-10-20 Thread zhzhan
Github user zhzhan commented on the pull request: https://github.com/apache/spark/pull/2576#issuecomment-59836769 @scwf Thanks for consolidating the work. I will pull your latest branch, and see what I can do further. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-20 Thread zhzhan
Github user zhzhan commented on the pull request: https://github.com/apache/spark/pull/2241#issuecomment-59837979 @scwf I did some basic functionality testing with you thrift patch, and it looks ok to me. By the way, because the 0.13.1 customized package is not available now, so I rev

[GitHub] spark pull request: SPARK-2621. Update task InputMetrics increment...

2014-10-20 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/2087#discussion_r19113109 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -121,6 +125,31 @@ class SparkHadoopUtil extends Logging { UserGroupI

[GitHub] spark pull request: [SPARK-3994] Use standard Aggregator code path...

2014-10-20 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/2839#issuecomment-59838812 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-20 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2241#issuecomment-59839556 Thanks, if you have any comment, let me know:) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: replace awaitTransformation with awaitTerminat...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2861#issuecomment-59841647 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21929/consoleFull) for PR 2861 at commit [`0e03863`](https://github.com/a

[GitHub] spark pull request: replace awaitTransformation with awaitTerminat...

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2861#issuecomment-59841654 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: [SQL]redundant methods for broadcast

2014-10-20 Thread scwf
GitHub user scwf opened a pull request: https://github.com/apache/spark/pull/2862 [SQL]redundant methods for broadcast You can merge this pull request into a Git repository by running: $ git pull https://github.com/scwf/spark TableReader Alternatively you can review and apply

[GitHub] spark pull request: [SQL]redundant methods for broadcast

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2862#issuecomment-59843301 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SQL]redundant methods for broadcast

2014-10-20 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2862#issuecomment-59843643 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SQL]redundant methods for broadcast

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2862#issuecomment-59844288 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21930/consoleFull) for PR 2862 at commit [`414cc24`](https://github.com/ap

[GitHub] spark pull request: [SQL]redundant methods for broadcast

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2862#issuecomment-59844712 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21930/consoleFull) for PR 2862 at commit [`414cc24`](https://github.com/a

[GitHub] spark pull request: [SQL]redundant methods for broadcast

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2862#issuecomment-59844713 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: [SQL]redundant methods for broadcast

2014-10-20 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2862#issuecomment-59845867 @JoshRosen test failed in streaming, compile error? it's very confusing, can you retest this? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] spark pull request: [SPARK-4013] Do not create multiple actor syst...

2014-10-20 Thread andrewor14
GitHub user andrewor14 opened a pull request: https://github.com/apache/spark/pull/2863 [SPARK-4013] Do not create multiple actor systems on each executor In the existing code, each coarse-grained executor has two concurrently running actor systems. This causes many more error messa

[GitHub] spark pull request: [WIP][SPARK-3822] Executor scaling mechanism f...

2014-10-20 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2840#issuecomment-59846348 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-4013] Do not create multiple actor syst...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2863#issuecomment-59846868 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21931/consoleFull) for PR 2863 at commit [`44ce2e0`](https://github.com/ap

[GitHub] spark pull request: [WIP][SPARK-3822] Executor scaling mechanism f...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2840#issuecomment-59846877 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21932/consoleFull) for PR 2840 at commit [`572f5c5`](https://github.com/ap

[GitHub] spark pull request: [SPARK-4013] Do not create multiple actor syst...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2863#issuecomment-59847264 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21931/consoleFull) for PR 2863 at commit [`44ce2e0`](https://github.com/a

[GitHub] spark pull request: [SPARK-4013] Do not create multiple actor syst...

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2863#issuecomment-59847267 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: [WIP][SPARK-3822] Executor scaling mechanism f...

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2840#issuecomment-59847294 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: [WIP][SPARK-3822] Executor scaling mechanism f...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2840#issuecomment-59847291 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21932/consoleFull) for PR 2840 at commit [`572f5c5`](https://github.com/a

[GitHub] spark pull request: [SPARK-3888] [PySpark] limit the memory used b...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2743#issuecomment-59848756 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21933/consoleFull) for PR 2743 at commit [`b500ebb`](https://github.com/ap

[GitHub] spark pull request: [SPARK-3902] [SPARK-3590] Stabilize AsynRDDAct...

2014-10-20 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2760#issuecomment-59848896 Reviewed again after the fact. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3888] [PySpark] limit the memory used b...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2743#issuecomment-59849187 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21933/consoleFull) for PR 2743 at commit [`b500ebb`](https://github.com/a

[GitHub] spark pull request: fix broken links in README.md

2014-10-20 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/2859#issuecomment-59849213 So there's an Old page (`building-with-maven`) and a New page (`building-spark`). Old redirects to New, and `README.md` links to New -- in `master`. But of course only Old

[GitHub] spark pull request: [SPARK-3888] [PySpark] limit the memory used b...

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2743#issuecomment-59849192 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: [SQL] Refactors data type pattern matching

2014-10-20 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/2764#discussion_r19118466 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -107,20 +107,20 @@ trait HiveTypeCoercion {

[GitHub] spark pull request: [SQL] Refactors data type pattern matching

2014-10-20 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/2764#discussion_r19118592 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala --- @@ -319,10 +315,8 @@ case object ByteType extends IntegralType

[GitHub] spark pull request: [SPARK-3958] TorrentBroadcast cleanup / debugg...

2014-10-20 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/2844#discussion_r19118588 --- Diff: core/src/test/scala/org/apache/spark/broadcast/BroadcastSuite.scala --- @@ -17,13 +17,18 @@ package org.apache.spark.broadcast +im

[GitHub] spark pull request: [SPARK-3906][SQL] Adds multiple join support f...

2014-10-20 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2767#issuecomment-59850744 Thanks, merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: SPARK-4012: call tryOrExit instead of logUncau...

2014-10-20 Thread CodingCat
GitHub user CodingCat opened a pull request: https://github.com/apache/spark/pull/2864 SPARK-4012: call tryOrExit instead of logUncaughtExceptions in ContextCleaner When running an "might-be-memory-intensive" application locally, I received the following exception ```

[GitHub] spark pull request: [SPARK-3958] TorrentBroadcast cleanup / debugg...

2014-10-20 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/2844#discussion_r19118825 --- Diff: core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala --- @@ -227,6 +217,7 @@ private object TorrentBroadcast extends Logging {

[GitHub] spark pull request: [ SPARK-1812] Adjust build system and tests to...

2014-10-20 Thread retronym
Github user retronym commented on the pull request: https://github.com/apache/spark/pull/2615#issuecomment-59850925 Was any other design other than a wholesale copy/paste of the REPL considered? The commit message doesn't reveal much. We'd be happy to help out over in scala-in

[GitHub] spark pull request: [SPARK-3906][SQL] Adds multiple join support f...

2014-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2767 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-3958] TorrentBroadcast cleanup / debugg...

2014-10-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/2844#discussion_r19118878 --- Diff: core/src/test/scala/org/apache/spark/broadcast/BroadcastSuite.scala --- @@ -17,13 +17,18 @@ package org.apache.spark.broadcast

[GitHub] spark pull request: [SPARK-3800][SQL] Clean aliases from grouping ...

2014-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2658 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-3888] [PySpark] limit the memory used b...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2743#issuecomment-59851108 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21934/consoleFull) for PR 2743 at commit [`c10229e`](https://github.com/ap

[GitHub] spark pull request: [SPARK-3984] [SPARK-3983] Improve UI task metr...

2014-10-20 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/2832#issuecomment-59851411 I'm holding off on this until I finish https://issues.apache.org/jira/browse/SPARK-4016 due to the concern that otherwise these new metrics will add confusion for t

[GitHub] spark pull request: [SPARK-3958] TorrentBroadcast cleanup / debugg...

2014-10-20 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/2844#discussion_r19119141 --- Diff: core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala --- @@ -104,29 +112,23 @@ private[spark] class TorrentBroadcast[T: ClassTag](

[GitHub] spark pull request: SPARK-4012: call tryOrExit instead of logUncau...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2864#issuecomment-59851664 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21935/consoleFull) for PR 2864 at commit [`287bd07`](https://github.com/ap

[GitHub] spark pull request: [SPARK-3958] TorrentBroadcast cleanup / debugg...

2014-10-20 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/2844#discussion_r19119178 --- Diff: core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala --- @@ -104,29 +112,23 @@ private[spark] class TorrentBroadcast[T: ClassTag](

[GitHub] spark pull request: [SPARK-3888] [PySpark] limit the memory used b...

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2743#issuecomment-59851768 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: [SPARK-3958] TorrentBroadcast cleanup / debugg...

2014-10-20 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/2844#discussion_r19119195 --- Diff: core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala --- @@ -62,6 +59,20 @@ private[spark] class TorrentBroadcast[T: ClassTag](

[GitHub] spark pull request: [SPARK-3888] [PySpark] limit the memory used b...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2743#issuecomment-59851763 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21934/consoleFull) for PR 2743 at commit [`c10229e`](https://github.com/a

[GitHub] spark pull request: SPARK-4012: call tryOrExit instead of logUncau...

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2864#issuecomment-59852140 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: SPARK-4012: call tryOrExit instead of logUncau...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2864#issuecomment-59852133 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21935/consoleFull) for PR 2864 at commit [`287bd07`](https://github.com/a

[GitHub] spark pull request: [SPARK-3888] [PySpark] limit the memory used b...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2743#issuecomment-59852579 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/406/consoleFull) for PR 2743 at commit [`c10229e`](https://github.com/a

[GitHub] spark pull request: [SPARK-3483][SQL] Special chars in column name...

2014-10-20 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2804#issuecomment-59852990 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-3888] [PySpark] limit the memory used b...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2743#issuecomment-59852935 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/406/consoleFull) for PR 2743 at commit [`c10229e`](https://github.com/

[GitHub] spark pull request: [SPARK-3958] TorrentBroadcast cleanup / debugg...

2014-10-20 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/2844#discussion_r19119727 --- Diff: core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala --- @@ -104,29 +112,23 @@ private[spark] class TorrentBroadcast[T: ClassTag](

[GitHub] spark pull request: [SPARK-3958] TorrentBroadcast cleanup / debugg...

2014-10-20 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/2844#discussion_r19119774 --- Diff: core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala --- @@ -227,6 +217,7 @@ private object TorrentBroadcast extends Logging {

[GitHub] spark pull request: [SPARK-3966][SQL] Fix nullabilities of Cast re...

2014-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2820 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [WIP][SPARK-3795] Heuristics for dynamically s...

2014-10-20 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/2746#issuecomment-59853416 Everything sounds good except for a couple specific callouts below: > we shouldn't wait for the new ones to register before asking for more. This is still worryi

[GitHub] spark pull request: [SPARK-3483][SQL] Special chars in column name...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2804#issuecomment-59853437 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21936/consoleFull) for PR 2804 at commit [`477e883`](https://github.com/ap

[GitHub] spark pull request: [SPARK-3966][SQL] Fix nullabilities of Cast re...

2014-10-20 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2820#issuecomment-59853602 Thanks, I've merged this to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: SPARK-4012: call tryOrExit instead of logUncau...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2864#issuecomment-59853916 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21937/consoleFull) for PR 2864 at commit [`55cafc8`](https://github.com/ap

[GitHub] spark pull request: [SPARK-3939][SQL] NPE caused by SessionState.o...

2014-10-20 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/2812#discussion_r19120144 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala --- @@ -69,6 +71,10 @@ object HiveThriftServer

[GitHub] spark pull request: [SPARK-3483][SQL] Special chars in column name...

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2804#issuecomment-59853984 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: [SPARK-3483][SQL] Special chars in column name...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2804#issuecomment-59853981 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21936/consoleFull) for PR 2804 at commit [`477e883`](https://github.com/a

<    1   2   3   4   5   >