[GitHub] spark pull request: [SPARK-8492] [SQL] support binaryType in Unsaf...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6911#issuecomment-113718050 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8492] [SQL] support binaryType in Unsaf...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6911#issuecomment-113718007 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8492] [SQL] support binaryType in Unsaf...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6911#issuecomment-113718122 [Test build #35359 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35359/consoleFull) for PR 6911 at commit [`180b49d`](https://gith

[GitHub] spark pull request: [SPARK-8482] Added M4 instances to the list.

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6899#issuecomment-113718198 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8482] Added M4 instances to the list.

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6899#issuecomment-113718188 [Test build #35354 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35354/console) for PR 6899 at commit [`4f4ea79`](https://github.

[GitHub] spark pull request: [SPARK-7104][MLlib] Support model save/load in...

2015-06-20 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/6821#issuecomment-113718211 @jkbradley Could you review it when you have time? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-8492] [SQL] support binaryType in Unsaf...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6911#issuecomment-113720758 [Test build #35357 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35357/console) for PR 6911 at commit [`22e4c0a`](https://github.

[GitHub] spark pull request: [SPARK-8492] [SQL] support binaryType in Unsaf...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6911#issuecomment-113720790 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8492] [SQL] support binaryType in Unsaf...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6911#issuecomment-113722728 [Test build #943 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/943/consoleFull) for PR 6911 at commit [`180b49d`](https://githu

[GitHub] spark pull request: [SPARK-8496] [Tests] Do not run slow tests for...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6917#issuecomment-113722910 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8496] [Tests] Do not run slow tests for...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6917#issuecomment-113722822 [Test build #35356 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35356/console) for PR 6917 at commit [`9bb1f19`](https://github.

[GitHub] spark pull request: [SPARK-8422] [BUILD] [PROJECT INFRA] Add a mod...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6866#issuecomment-113726022 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8422] [BUILD] [PROJECT INFRA] Add a mod...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6866#issuecomment-113725948 [Test build #35355 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35355/console) for PR 6866 at commit [`75de450`](https://github.

[GitHub] spark pull request: [SPARK-8498][TUNGSTEN] fix npe in errorhandlin...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6918#issuecomment-113726353 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8498][TUNGSTEN] fix npe in errorhandlin...

2015-06-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/6918#discussion_r32883234 --- Diff: core/src/main/java/org/apache/spark/shuffle/unsafe/UnsafeShuffleWriter.java --- @@ -139,17 +139,22 @@ public void write(Iterator> records) throws

[GitHub] spark pull request: [SPARK-8498][TUNGSTEN] fix npe in errorhandlin...

2015-06-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/6918#discussion_r32883231 --- Diff: core/src/test/java/org/apache/spark/shuffle/unsafe/UnsafeShuffleWriterSuite.java --- @@ -253,6 +253,23 @@ public void doNotNeedToCallWriteBefore

[GitHub] spark pull request: [SPARK-8498][TUNGSTEN] fix npe in errorhandlin...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6918#issuecomment-113727278 [Test build #35360 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35360/consoleFull) for PR 6918 at commit [`e503b8c`](https://gith

[GitHub] spark pull request: [SPARK-8498][TUNGSTEN] fix npe in errorhandlin...

2015-06-20 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/6918#issuecomment-113727568 Thanks for fixing this; the test looks good to me, but I think we might want to preserve the old behavior of also performing error cleanup when Throwables are thrown (

[GitHub] spark pull request: [SPARK-8498][TUNGSTEN] fix npe in errorhandlin...

2015-06-20 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/6918#issuecomment-113727924 Sounds like a good plan. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-8422] [BUILD] [PROJECT INFRA] Add a mod...

2015-06-20 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/6866#issuecomment-113727956 Yay, this still passes tests! I've updated this to move the test build profile selection logic into the module system, which I think makes things a bit easier to unde

[GitHub] spark pull request: [SPARK-8406] [SQL] Adding UUID to output file ...

2015-06-20 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/6864#issuecomment-113728195 @lianhuiwang Yeah, thanks for reminding. We are also working on this issue. It will be addressed in another PR. At first, appending jobs with output committers like `D

[GitHub] spark pull request: [SPARK-8498][TUNGSTEN] fix npe in errorhandlin...

2015-06-20 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/6918#issuecomment-113728593 Would it not make more sense to just catch/rethrow throwables? (That way if fail during cleanup we can pass back an exception indicating that cleanup failed + the underl

[GitHub] spark pull request: [SPARK-8406] [SQL] Adding UUID to output file ...

2015-06-20 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/6864#issuecomment-113729847 With the help from @yhuai, finally found the root cause of the `OrcSourceSuite` failures showed in previous Jenkins builds. [SPARK-8501] [1] is opened to track that is

[GitHub] spark pull request: Expose regionName setting in Kinesis receiver ...

2015-06-20 Thread kopiczko
Github user kopiczko commented on the pull request: https://github.com/apache/spark/pull/5375#issuecomment-113729967 Sorry guys, I currently have no time to work on it. @tdas: Would you mind give a reference how this is solved? --- If your project is set up for it, you can reply to t

[GitHub] spark pull request: Expose regionName setting in Kinesis receiver ...

2015-06-20 Thread kopiczko
Github user kopiczko closed the pull request at: https://github.com/apache/spark/pull/5375 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] spark pull request: Expose regionName setting in Kinesis receiver ...

2015-06-20 Thread kopiczko
Github user kopiczko commented on the pull request: https://github.com/apache/spark/pull/5375#issuecomment-113730010 Sorry guys, I currently have no time to work on it. @tdas: Would you mind giving a reference how this is solved? --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-8406] [SQL] Adding UUID to output file ...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6864#issuecomment-113730019 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8406] [SQL] Adding UUID to output file ...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6864#issuecomment-113730026 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8406] [SQL] Adding UUID to output file ...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6864#issuecomment-113730049 [Test build #35361 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35361/consoleFull) for PR 6864 at commit [`d412de7`](https://gith

[GitHub] spark pull request: [SQL] SPARK-6489: Optimize lateral view with e...

2015-06-20 Thread dreamquster
Github user dreamquster commented on a diff in the pull request: https://github.com/apache/spark/pull/5358#discussion_r32883400 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -171,6 +172,10 @@ object ColumnPruning extends Rule[

[GitHub] spark pull request: [SPARK-7633] [MLlib] [PySpark] Python bindings...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6849#issuecomment-113732611 [Test build #35358 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35358/console) for PR 6849 at commit [`5a94db0`](https://github.

[GitHub] spark pull request: [SPARK-7633] [MLlib] [PySpark] Python bindings...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6849#issuecomment-113732682 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SQL] SPARK-6489: Optimize lateral view with e...

2015-06-20 Thread dreamquster
Github user dreamquster commented on a diff in the pull request: https://github.com/apache/spark/pull/5358#discussion_r32883442 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala --- @@ -56,7 +56,8 @@ case class Generate( val boundGenerator = Bin

[GitHub] spark pull request: [SPARK-8492] [SQL] support binaryType in Unsaf...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6911#issuecomment-113733710 [Test build #35359 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35359/console) for PR 6911 at commit [`180b49d`](https://github.

[GitHub] spark pull request: [SPARK-8492] [SQL] support binaryType in Unsaf...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6911#issuecomment-113733769 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8498][TUNGSTEN] fix npe in errorhandlin...

2015-06-20 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/6918#issuecomment-113734145 I think that my concern was that wrapping a Throwable with a cause and re-throwing it might not be safe in general because catchers higher up the stack would then rece

[GitHub] spark pull request: [SPARK-8406] [SQL] Adding UUID to output file ...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6864#issuecomment-113735514 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8406] [SQL] Adding UUID to output file ...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6864#issuecomment-113735490 [Test build #35361 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35361/console) for PR 6864 at commit [`d412de7`](https://github.

[GitHub] spark pull request: [SPARK-8498][TUNGSTEN] fix npe in errorhandlin...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6918#issuecomment-113737386 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8498][TUNGSTEN] fix npe in errorhandlin...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6918#issuecomment-113737379 [Test build #35360 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35360/console) for PR 6918 at commit [`e503b8c`](https://github.

[GitHub] spark pull request: [SPARK-8492] [SQL] support binaryType in Unsaf...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6911#issuecomment-113737426 [Test build #943 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/943/console) for PR 6911 at commit [`180b49d`](https://github.c

[GitHub] spark pull request: [SPARK-8399][Streaming][Web UI] Overlap betwee...

2015-06-20 Thread BenFradet
Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/6845#issuecomment-113746495 @tdas I'll see what I can do. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-4176] Support decimal types with precis...

2015-06-20 Thread rtreffer
Github user rtreffer commented on the pull request: https://github.com/apache/spark/pull/6796#issuecomment-113762279 Ok, I think I'm slowly getting down to the cause strictTypeChecking on https://github.com/Parquet/parquet-mr/blob/master/parquet-column/src/main/java/parquet/io/

[GitHub] spark pull request: [SPARK-8399][Streaming][Web UI] Overlap betwee...

2015-06-20 Thread BenFradet
Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/6845#issuecomment-113768928 @tdas Here is the before: ![before](http://i.imgur.com/afqtSWP.png) And, here is the after: ![after](http://i.imgur.com/Dk8NKMM.png) --- If

[GitHub] spark pull request: [SPARK-8407][SQL]complex type constructors: st...

2015-06-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/6874#discussion_r32884753 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala --- @@ -79,3 +80,60 @@ case class CreateStruct(children:

[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...

2015-06-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/6876#discussion_r32884758 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateProjection.scala --- @@ -127,6 +127,7 @@ object GeneratePro

[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...

2015-06-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/6876#discussion_r32884828 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala --- @@ -26,7 +26,67 @@ import org.apache.spark.sql.catalyst.expressio

[GitHub] spark pull request: [SPARK-8186] [SPARK-8187] [SQL] datetime funct...

2015-06-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/6782#discussion_r32884906 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed to t

[GitHub] spark pull request: [SPARK-8186] [SPARK-8187] [SQL] datetime funct...

2015-06-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/6782#discussion_r32884919 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed to t

[GitHub] spark pull request: [SPARK-8186] [SPARK-8187] [SQL] datetime funct...

2015-06-20 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/6782#issuecomment-113775652 `DateAdd` and `DateSub` are very similar , can we abstract some common pattern to reduce code size? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: Spark 7998 freq item api

2015-06-20 Thread dwmclary
GitHub user dwmclary opened a pull request: https://github.com/apache/spark/pull/6919 Spark 7998 freq item api Here's "a better frequent item API" which provides a DataFrame with each ArrayBuffer expanded into a column. There's surely some improvement that could be done here, but

[GitHub] spark pull request: Spark 7998 freq item api

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6919#issuecomment-113775941 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-8186] [SPARK-8187] [SQL] datetime funct...

2015-06-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/6782#discussion_r32884986 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed to t

[GitHub] spark pull request: [SPARK-8359][SQL] Fix incorrect decimal precis...

2015-06-20 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/6814#discussion_r32885075 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -286,6 +288,9 @@ object Decimal { /** Maximum number of decimal di

[GitHub] spark pull request: [SPARK-8407][SQL]complex type constructors: st...

2015-06-20 Thread yijieshen
Github user yijieshen commented on a diff in the pull request: https://github.com/apache/spark/pull/6874#discussion_r32885149 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala --- @@ -79,3 +80,60 @@ case class CreateStruct(children:

[GitHub] spark pull request: [SPARK-8359][SQL] Fix incorrect decimal precis...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6814#issuecomment-113777827 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8359][SQL] Fix incorrect decimal precis...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6814#issuecomment-113777818 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8359][SQL] Fix incorrect decimal precis...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6814#issuecomment-113777922 [Test build #35362 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35362/consoleFull) for PR 6814 at commit [`071a757`](https://gith

[GitHub] spark pull request: [SPARK-8399][Streaming][Web UI] Overlap betwee...

2015-06-20 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/6845#issuecomment-113783361 Looks a lot of space on the right. Could you just move `#batches` above the blue bar? --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark pull request: [SPARK-7633] [MLlib] [PySpark] Python bindings...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6849#issuecomment-113783546 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7633] [MLlib] [PySpark] Python bindings...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6849#issuecomment-113783549 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8399][Streaming][Web UI] Overlap betwee...

2015-06-20 Thread BenFradet
Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/6845#issuecomment-113783603 Do you mean above the axis? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-7633] [MLlib] [PySpark] Python bindings...

2015-06-20 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/6849#issuecomment-113783694 @mengxr Could you review this? This should be the next one to go as I have refactored the code. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-7633] [MLlib] [PySpark] Python bindings...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6849#issuecomment-113784078 [Test build #35363 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35363/consoleFull) for PR 6849 at commit [`19c0f25`](https://gith

[GitHub] spark pull request: [SPARK-8399][Streaming][Web UI] Overlap betwee...

2015-06-20 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/6845#issuecomment-113785985 > Do you mean above the axis? No. Still overlap. But `#batches` is on the top. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] spark pull request: [SPARK-8478][SQL] Harmonize UDF-related code t...

2015-06-20 Thread BenFradet
GitHub user BenFradet opened a pull request: https://github.com/apache/spark/pull/6920 [SPARK-8478][SQL] Harmonize UDF-related code to use uniformly UDF instead of Udf Follow-up of #6902 for being coherent between ```Udf``` and ```UDF``` You can merge this pull request into a Git r

[GitHub] spark pull request: [SPARK-8378][Streaming]Add the Python API for ...

2015-06-20 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/6830#issuecomment-113786084 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-8478][SQL] Harmonize UDF-related code t...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6920#issuecomment-113786269 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8478][SQL] Harmonize UDF-related code t...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6920#issuecomment-113786271 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8378][Streaming]Add the Python API for ...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6830#issuecomment-113786270 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8378][Streaming]Add the Python API for ...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6830#issuecomment-113786276 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8378][Streaming]Add the Python API for ...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6830#issuecomment-113786330 [Test build #35365 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35365/consoleFull) for PR 6830 at commit [`01cbb3d`](https://gith

[GitHub] spark pull request: [SPARK-8478][SQL] Harmonize UDF-related code t...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6920#issuecomment-113786412 [Test build #35364 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35364/consoleFull) for PR 6920 at commit [`660b669`](https://gith

[GitHub] spark pull request: [SPARK-8399][Streaming][Web UI] Overlap betwee...

2015-06-20 Thread BenFradet
Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/6845#issuecomment-113786509 Mmh, in this case I think we won't be able to see ```#batches``` written since the contrast won't be high enough between gray and dark blue. --- If your project is se

[GitHub] spark pull request: [SPARK-8399][Streaming][Web UI] Overlap betwee...

2015-06-20 Thread BenFradet
Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/6845#issuecomment-113786756 Maybe we should put the axis on the bottom and ```#batches``` under the axis. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] spark pull request: [SPARK-8407][SQL]complex type constructors: st...

2015-06-20 Thread yijieshen
Github user yijieshen commented on a diff in the pull request: https://github.com/apache/spark/pull/6874#discussion_r32885914 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala --- @@ -79,3 +80,59 @@ case class CreateStruct(children:

[GitHub] spark pull request: SPARK-8398 hadoop input/output format advanced...

2015-06-20 Thread koertkuipers
Github user koertkuipers commented on the pull request: https://github.com/apache/spark/pull/6848#issuecomment-113789091 i see MiMa failed. what binary compatibility promise does spark make? all minor versions are binary compatible? --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-8359][SQL] Fix incorrect decimal precis...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6814#issuecomment-113789829 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8359][SQL] Fix incorrect decimal precis...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6814#issuecomment-113789820 [Test build #35362 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35362/console) for PR 6814 at commit [`071a757`](https://github.

[GitHub] spark pull request: [SPARK-8407][SQL]complex type constructors: st...

2015-06-20 Thread yijieshen
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6874#issuecomment-113790186 @cloud-fan @chenghao-intel, thanks for reviewing this. I've moved the incorrect input test into `ExpressionTypeCheckingSuite` and also remove unnecessary assertion fro

[GitHub] spark pull request: [SPARK-7626][SQL] Consider the columns in Hive...

2015-06-20 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/6146#issuecomment-113790943 @marmbrus Although the code looks problematic, I mentioned on the JIRA that I can't reproduce the problem. By more testing, I found that in your PR #5876 (https://github.

[GitHub] spark pull request: [SPARK-7626][SQL] Consider the columns in Hive...

2015-06-20 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/6146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-6259][MLlib] Python API for LDA

2015-06-20 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/6791#discussion_r32886340 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala --- @@ -465,6 +465,36 @@ private[python] class PythonMLLibAPI extends

[GitHub] spark pull request: [SPARK-7633] [MLlib] [PySpark] Python bindings...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6849#issuecomment-113792708 [Test build #35363 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35363/console) for PR 6849 at commit [`19c0f25`](https://github.

[GitHub] spark pull request: [SPARK-7633] [MLlib] [PySpark] Python bindings...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6849#issuecomment-113792716 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8378][Streaming]Add the Python API for ...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6830#issuecomment-113792976 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8378][Streaming]Add the Python API for ...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6830#issuecomment-113792966 [Test build #35365 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35365/console) for PR 6830 at commit [`01cbb3d`](https://github.

[GitHub] spark pull request: [SPARK-6259][MLlib] Python API for LDA

2015-06-20 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/6791#discussion_r32886481 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala --- @@ -465,6 +465,36 @@ private[python] class PythonMLLibAPI extends S

[GitHub] spark pull request: [SPARK-6910] [SQL] [WIP] Support for pushing p...

2015-06-20 Thread piaozhexiu
GitHub user piaozhexiu opened a pull request: https://github.com/apache/spark/pull/6921 [SPARK-6910] [SQL] [WIP] Support for pushing predicates down to metastore for partition pruning @marmbrus per our email conversation, I am sending a PR that implements the idea that I outlined i

[GitHub] spark pull request: [SPARK-8478][SQL] Harmonize UDF-related code t...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6920#issuecomment-113796491 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6910] [SQL] [WIP] Support for pushing p...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6921#issuecomment-113796132 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-8478][SQL] Harmonize UDF-related code t...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6920#issuecomment-113796348 [Test build #35364 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35364/console) for PR 6920 at commit [`660b669`](https://github.

[GitHub] spark pull request: [SPARK-8495][SparkR] Add a `.lintr` file to va...

2015-06-20 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/6922 [SPARK-8495][SparkR] Add a `.lintr` file to validate the SparkR files and the `lint-r` script Thank Shivaram Venkataraman for your support. This is a prototype script to validate the R files. You

[GitHub] spark pull request: [SPARK-8495][SparkR] Add a `.lintr` file to va...

2015-06-20 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/6922#issuecomment-113798277 @shivaram Could you review it when you have time? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-8495][SparkR] Add a `.lintr` file to va...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6922#issuecomment-113798530 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8495][SparkR] Add a `.lintr` file to va...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6922#issuecomment-113798471 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8495][SparkR] Add a `.lintr` file to va...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6922#issuecomment-113799275 [Test build #35366 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35366/consoleFull) for PR 6922 at commit [`8f94680`](https://gith

[GitHub] spark pull request: [SPARK-8495][SparkR] Add a `.lintr` file to va...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6922#issuecomment-113799298 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8495][SparkR] Add a `.lintr` file to va...

2015-06-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6922#issuecomment-113799295 [Test build #35366 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35366/console) for PR 6922 at commit [`8f94680`](https://github.

[GitHub] spark pull request: [SPARK-7712] [SQL] Move Window Functions from ...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6278#issuecomment-113799722 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

  1   2   3   >