Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10060#discussion_r47000161
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -73,7 +73,25 @@ class TypedColumn[-T, U](
/**
* :: Experimental :
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10170#discussion_r47000196
--- Diff:
core/src/main/scala/org/apache/spark/memory/UnifiedMemoryManager.scala ---
@@ -110,6 +110,12 @@ private[spark] class UnifiedMemoryManager
priva
Github user jbonofre commented on the pull request:
https://github.com/apache/spark/pull/10203#issuecomment-162987492
There are two things:
- as you said, we could use a ConcurrentHashMap in KinesisReceiver
- but it still means that users can't use Kryo serializer with
Synchron
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6502#issuecomment-162987332
**[Test build #47355 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47355/consoleFull)**
for PR 6502 at commit
[`ce52797`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10199#issuecomment-162986919
**[Test build #47352 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47352/consoleFull)**
for PR 10199 at commit
[`faef98d`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10204#issuecomment-162986697
**[Test build #47353 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47353/consoleFull)**
for PR 10204 at commit
[`207895b`](https://gi
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46999417
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala ---
@@ -281,6 +296,202 @@ class HistoryServerSuite extends SparkFunSuite
Github user EugenCepoi commented on the pull request:
https://github.com/apache/spark/pull/10203#issuecomment-162985706
Why don't you just replace the use of SynchronizedMap in KinesisReceiver
with a ConcurrentHashMap instead?
---
If your project is set up for it, you can reply to th
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/6502#issuecomment-162985841
not that it should matter, but retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10181#issuecomment-162984975
For Unsafe.getInt, what's the difference between ON_HEAP or OFF_HEAP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/10199#issuecomment-162984950
Isn't this the same as #9824?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46998222
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -146,22 +136,51 @@ class HistoryServer(
override def stop() {
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10204#issuecomment-162984299
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10170#discussion_r46997970
--- Diff:
core/src/main/scala/org/apache/spark/memory/UnifiedMemoryManager.scala ---
@@ -100,7 +100,7 @@ private[spark] class UnifiedMemoryManager
privat
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46997833
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -678,6 +827,54 @@ private[history] class FsHistoryProvider(conf:
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46997864
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -678,6 +827,54 @@ private[history] class FsHistoryProvider(conf:
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r46997422
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -17,6 +17,8 @@
package org.apache.spark.sql.c
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r46997515
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -56,12 +55,16 @@ abstract class RuleExecutor[TreeType <
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10170#discussion_r46997361
--- Diff:
core/src/main/scala/org/apache/spark/memory/StorageMemoryPool.scala ---
@@ -128,9 +132,11 @@ class StorageMemoryPool(lock: Object) extends
Memo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10204#issuecomment-162983041
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/10181#issuecomment-162982916
@rxin @zsxwing
FYI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10204#issuecomment-162983043
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10199#issuecomment-162982937
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9923#issuecomment-162982557
> IIUC, http server is useless once we remove akka?
There's the http-based broadcast server, which IIRC is not the default.
Does anyone even use that these days?
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9613#issuecomment-162982218
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9613#issuecomment-162982220
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10205#issuecomment-162981891
**[Test build #47350 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47350/consoleFull)**
for PR 10205 at commit
[`8b00d76`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9613#issuecomment-162981999
**[Test build #47349 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47349/consoleFull)**
for PR 9613 at commit
[`8140e20`](https://git
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10202
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user olarayej commented on a diff in the pull request:
https://github.com/apache/spark/pull/9613#discussion_r46995766
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2151,3 +2151,97 @@ setMethod("coltypes",
rTypes
})
+
+#' Display the struc
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10202#issuecomment-162979118
LGTM. Thank you for the fix! I am merging it to master and branch 1.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46995495
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala ---
@@ -0,0 +1,579 @@
+/*
+ * Licensed to the Apache Softwa
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9923#discussion_r46995428
--- Diff:
core/src/main/scala/org/apache/spark/rpc/netty/NettyStreamManager.scala ---
@@ -41,7 +42,10 @@ private[netty] class NettyStreamManager(rpcEnv:
Netty
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46995405
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala
---
@@ -33,7 +33,35 @@ private[spark] case class ApplicationAtt
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46995458
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala
---
@@ -73,4 +101,17 @@ private[history] abstract class
Applic
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10102#issuecomment-162977622
**[Test build #2185 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2185/consoleFull)**
for PR 10102 at commit
[`5ef6ff8`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10166#issuecomment-162977371
**[Test build #2184 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2184/consoleFull)**
for PR 10166 at commit
[`cb33653`](https://
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46995257
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala ---
@@ -0,0 +1,648 @@
+/*
+ * Licensed to the Apache Software Foun
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10166#issuecomment-162978022
```dev/lint-python``` should catch these issues
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46995031
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala ---
@@ -0,0 +1,648 @@
+/*
+ * Licensed to the Apache Softwa
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/10205#issuecomment-162977465
I'm leaving this as an RFC to start with; if people like it, I'll probably
just attach this to SPARK-529 (after reopening it).
/cc @andrewor14 @rxin @srowen
-
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10166#issuecomment-162976307
That was a spurious test failure; I asked it to retest
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/10205
[RFC] Add type-safe config keys to SparkConf.
This is, in a way, the basics to enable SPARK-529 (which was closed as
won't fix but I think is still valuable). In fact, Spark SQL created
somet
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10166#issuecomment-162976755
**[Test build #2184 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2184/consoleFull)**
for PR 10166 at commit
[`cb33653`](https://g
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10204#issuecomment-162976343
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user aray commented on the pull request:
https://github.com/apache/spark/pull/10202#issuecomment-162975930
@yhuai can you take a look at this small patch to pivot?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10204#issuecomment-162975883
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10204#issuecomment-162975881
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10202#issuecomment-162975379
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10202#issuecomment-162975377
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-162975357
Overall, I'd say it's unclear whether we need to modify our implementation.
How about we look for use cases and see if people have reported differences
between follo
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10170#discussion_r46994235
--- Diff:
core/src/main/scala/org/apache/spark/memory/StorageMemoryPool.scala ---
@@ -73,27 +73,31 @@ class StorageMemoryPool(lock: Object) extends
Memor
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/8103#issuecomment-162974987
LGTM. ping @tdas to take a final look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9613#issuecomment-162975173
**[Test build #47349 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47349/consoleFull)**
for PR 9613 at commit
[`8140e20`](https://gith
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10170#discussion_r46994074
--- Diff:
core/src/main/scala/org/apache/spark/memory/StorageMemoryPool.scala ---
@@ -73,27 +73,31 @@ class StorageMemoryPool(lock: Object) extends
Memor
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10202#issuecomment-162975139
**[Test build #47343 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47343/consoleFull)**
for PR 10202 at commit
[`8a3f555`](https://g
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-162974386
@MLnick Oops, you're right; we are completely ignoring sentence boundaries.
I didn't look carefully enough at the code. I'll correct my comment above too.
>
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46993661
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala ---
@@ -0,0 +1,648 @@
+/*
+ * Licensed to the Apache Softwa
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/8512#issuecomment-162974033
Has anyone looked at the performance of this versus S3a in Hadoop 2.7+?
Because while I do agree this will dramatically improve s3n: and s3: perf, all
ongoing Hado
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r46992991
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -469,7 +469,32 @@ class Word2VecModel private[spark] (
this(Wo
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8551
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user jkbradley closed the pull request at:
https://github.com/apache/spark/pull/10183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8551#issuecomment-162970671
LGTM. Merging with master and branch-1.6
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/8512#discussion_r46992376
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkS3Util.scala ---
@@ -0,0 +1,336 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10166#issuecomment-162970048
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user piaozhexiu commented on a diff in the pull request:
https://github.com/apache/spark/pull/8512#discussion_r46992201
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkS3Util.scala ---
@@ -0,0 +1,336 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user zsxwing closed the pull request at:
https://github.com/apache/spark/pull/10076
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10166#issuecomment-162970052
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10052#issuecomment-162970002
We'll have to note the change in the release notes, but since its a no-op
to sort by a constant I think we can safely change behavior here.
---
If your project is set
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10076#discussion_r46992341
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -253,7 +253,7 @@ private[spark] class Executor(
val directRes
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10184#discussion_r46991908
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -67,15 +67,21 @@ class Dataset[T] private[sql](
tEncoder: Encoder[T]) ex
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10184#discussion_r46992054
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -429,18 +432,18 @@ class Dataset[T] private[sql](
/**
* (Jav
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10184#issuecomment-162969383
Thanks, I'm going to merge this to master and 1.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
GitHub user yhuai opened a pull request:
https://github.com/apache/spark/pull/10204
[SQL] Try to run execution hive's derby in memory.
This PR tries to make execution hive's derby run in memory since it is a
fake metastore and every time we create a HiveContext, we will switch to a
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10102#issuecomment-162968904
Thank you for updating! LGTM pending tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/8512#discussion_r46991325
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkS3Util.scala ---
@@ -0,0 +1,336 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10163#issuecomment-162967445
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10163#issuecomment-162967443
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10163#issuecomment-162967261
**[Test build #47342 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47342/consoleFull)**
for PR 10163 at commit
[`c81aa46`](https://g
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10193#issuecomment-162967326
@yinxusen Could you fix conflicts? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10188
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10188#issuecomment-162966881
Thanks, merging to master and 1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10196#issuecomment-162965801
Thanks, merging to master and 1.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/7786#issuecomment-162965678
Jerry: do you know when YARN visits this decisions about having things
pre-emptible? That is: if you are given a warning dos that mean the container
will go any ti
Github user bomeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10185#discussion_r46990153
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -892,12 +892,14 @@ object StreamingContext extends Logging {
Github user xguo27 commented on the pull request:
https://github.com/apache/spark/pull/9553#issuecomment-162964945
Hi @yhuai, do you think this is good to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10177
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/10177#issuecomment-162963794
Thanks @tedyu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5423#issuecomment-162963733
**[Test build #47346 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47346/consoleFull)**
for PR 5423 at commit
[`b0e25bd`](https://gith
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46989032
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala ---
@@ -0,0 +1,648 @@
+/*
+ * Licensed to the Apache Software Foun
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/8744#issuecomment-162963641
Now that it's dependency PR is in, I welcome comments and reviews on this.
The latest change just adds a version counter to every entity publishing, so
that when c
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/10177#issuecomment-162963319
LGTM. Merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/6935#issuecomment-162962369
FWIW, I've got the SPARK-1537 Yarn history provider hooked up to this in [a
branch](https://github.com/steveloughran/spark/tree/history/SPARK-7889%2BSPARK-1537-prov
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46988309
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala ---
@@ -0,0 +1,648 @@
+/*
+ * Licensed to the Apache Software Foun
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46988368
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala ---
@@ -0,0 +1,648 @@
+/*
+ * Licensed to the Apache Software Foun
Github user keypointt commented on the pull request:
https://github.com/apache/spark/pull/10107#issuecomment-162961226
@squito yeah! my first code change, and I've learnt a lot from you :+1:
Thank you so much Imran!
---
If your project is set up for it, you can reply to this ema
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8744#issuecomment-162960692
**[Test build #47345 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47345/consoleFull)**
for PR 8744 at commit
[`5acaebb`](https://gith
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/10107#issuecomment-162960042
merged to master (I made some very tiny style changes). Thanks for working
on this @keypointt!
---
If your project is set up for it, you can reply to this email and ha
501 - 600 of 769 matches
Mail list logo
