Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-162974386
@MLnick Oops, you're right; we are completely ignoring sentence boundaries.
I didn't look carefully enough at the code. I'll correct my comment above too.
> it's an open question whether this approach, or keeping sentence
structure / boundaries, is better
Same here; I haven't looked at the follow-up literature sufficiently to
say. If anyone watching has references, that'd be useful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
