[GitHub] spark pull request: [SPARK-11815] [ML] [PySpark] PySpark DecisionT...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9807#issuecomment-169209718 **[Test build #48819 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48819/consoleFull)** for PR 9807 at commit [`e6ef361`](https://gith

[GitHub] spark pull request: [SPARK-11815] [ML] [PySpark] PySpark DecisionT...

2016-01-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9807#discussion_r48924285 --- Diff: python/pyspark/ml/classification.py --- @@ -287,7 +287,7 @@ class DecisionTreeClassifier(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPred

[GitHub] spark pull request: [SPARK-2750][WEB UI] Add https support to the ...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10238#issuecomment-169209703 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-2750][WEB UI] Add https support to the ...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10238#issuecomment-169209702 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12645] [SparkR] SparkR support hash fun...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10597#issuecomment-169209593 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12645] [SparkR] SparkR support hash fun...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10597#issuecomment-169209592 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12539][SQL] support writing bucketed ta...

2016-01-05 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10498#discussion_r48924160 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/bucket.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-3873] [build] Enable import ordering er...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10612#issuecomment-169209019 **[Test build #48816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48816/consoleFull)** for PR 10612 at commit [`1f08d6e`](https://gi

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10583#issuecomment-169208476 BTW given the size of the pull request, I think we can also merge it provided that it has no structural problems, and then review feedback in follow-up prs. --- If your

[GitHub] spark pull request: [SPARK-6363][BUILD] Make Scala 2.11 the defaul...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10608#issuecomment-169208308 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-6363][BUILD] Make Scala 2.11 the defaul...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10608#issuecomment-169208309 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-6363][BUILD] Make Scala 2.11 the defaul...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10608#issuecomment-169208080 **[Test build #48796 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48796/consoleFull)** for PR 10608 at commit [`623a929`](https://g

[GitHub] spark pull request: [SPARK-2750][WEB UI] Add https support to the ...

2016-01-05 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10238#issuecomment-169207941 Yeah, my own fault most probably. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-3873] [build] Enable import ordering er...

2016-01-05 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10612#issuecomment-169207716 I'll let this simmer for a few days to wait for new PRs that might have violations to go in, and fix those... but at some point I'll get bored of fixing things and proba

[GitHub] spark pull request: [SPARK-3873] [build] Enable import ordering er...

2016-01-05 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/10612 [SPARK-3873] [build] Enable import ordering error checking. Turn import ordering violations into build errors, plus a few adjustments to account for how the checker behaves. I'm a little on the f

[GitHub] spark pull request: [SPARK-2750][WEB UI] Add https support to the ...

2016-01-05 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/10238#issuecomment-169207523 It seems conflicted :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-12637 Print stage info of finished stage...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10585#issuecomment-169206547 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-3873] [tests] Import ordering fixes.

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10582 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: SPARK-12637 Print stage info of finished stage...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10585#issuecomment-169206545 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: SPARK-12637 Print stage info of finished stage...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10585#issuecomment-169206444 **[Test build #48803 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48803/consoleFull)** for PR 10585 at commit [`696f884`](https://g

[GitHub] spark pull request: [SPARK-3873] [tests] Import ordering fixes.

2016-01-05 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10582#issuecomment-169206265 Yay. Merging to avoid further conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-3873] [tests] Import ordering fixes.

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10582#issuecomment-169206038 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-3873] [tests] Import ordering fixes.

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10582#issuecomment-169206036 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-3873] [core] Import ordering fixes.

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10578 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-3873] [tests] Import ordering fixes.

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10582#issuecomment-169205865 **[Test build #48800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48800/consoleFull)** for PR 10582 at commit [`d589315`](https://g

[GitHub] spark pull request: [SPARK-12393] [SparkR] Add read.text and write...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10348#issuecomment-169205857 **[Test build #48813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48813/consoleFull)** for PR 10348 at commit [`5063f5f`](https://gi

[GitHub] spark pull request: [SPARK-3873] [core] Import ordering fixes.

2016-01-05 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10578#issuecomment-169205658 Yay. I'm gonna merge this before I have to fix more conflicts... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10583#discussion_r48923378 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala --- @@ -0,0 +1,969 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11531] [ML] : SparseVector error Msg

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9525#issuecomment-169205402 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11531] [ML] : SparseVector error Msg

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9525#issuecomment-169205403 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10583#discussion_r48923332 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala --- @@ -0,0 +1,969 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11531] [ML] : SparseVector error Msg

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9525#issuecomment-169205356 **[Test build #48811 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48811/consoleFull)** for PR 9525 at commit [`922028b`](https://git

[GitHub] spark pull request: [SPARK-8410][SPARK-8475] remove previous ivy r...

2016-01-05 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7089#discussion_r48923007 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -922,6 +922,15 @@ private[spark] object SparkSubmitUtils {

[GitHub] spark pull request: [SPARK-12659] fix NPE in UnsafeExternalSorter ...

2016-01-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10606#issuecomment-169204251 More comments would also be appreciated, since this is pretty confusing. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-12295] [SQL] external spilling for wind...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10605#issuecomment-169204200 **[Test build #48812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48812/consoleFull)** for PR 10605 at commit [`60edf13`](https://gi

[GitHub] spark pull request: [SPARK-12659] fix NPE in UnsafeExternalSorter ...

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10606 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10583#issuecomment-169204037 Does case-sensitivity config still work with the new parser? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12659] fix NPE in UnsafeExternalSorter ...

2016-01-05 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10606#issuecomment-169203949 @JoshRosen I'm merging this into master and 1.6 branch to unblock another PR, will add @Nullable in that PR. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-12659] fix NPE in UnsafeExternalSorter ...

2016-01-05 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10606#discussion_r48922730 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java --- @@ -223,14 +227,9 @@ public void loadNext() {

[GitHub] spark pull request: [SPARK-12295] [SQL] external spilling for wind...

2016-01-05 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10605#issuecomment-169203354 @hvanhovell Here is the result after having a fast path for small partition: ``` +-++--+---+-+ | Size|Name

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10583#discussion_r48922609 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala --- @@ -451,6 +452,19 @@ private[spark] object SQLConf { doc = "When true, we

[GitHub] spark pull request: [SPARK-11531] [ML] : SparseVector error Msg

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9525#issuecomment-169202932 **[Test build #48811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48811/consoleFull)** for PR 9525 at commit [`922028b`](https://gith

[GitHub] spark pull request: [SPARK-11531] [ML] : SparseVector error Msg

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9525#issuecomment-169202224 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11531] [ML] : SparseVector error Msg

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9525#issuecomment-169202223 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explaination...

2016-01-05 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169202207 Thanks, @srowen I will try to add parameter explain to fold. But for treeAggregate, it has comments like below to refer to Aggregate function. I thought it's enough

[GitHub] spark pull request: [SPARK-12640][SQL] Add simple benchmarking uti...

2016-01-05 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/10589#discussion_r48922143 --- Diff: core/src/test/scala/org/apache/spark/Benchmark.scala --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: [SPARK-12400][Shuffle] Avoid generating temp s...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10376#issuecomment-169200095 **[Test build #48809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48809/consoleFull)** for PR 10376 at commit [`7837b06`](https://gi

[GitHub] spark pull request: [SPARK-12539][SQL] support writing bucketed ta...

2016-01-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10498#discussion_r48921611 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/bucket.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Soft

[GitHub] spark pull request: [SPARK-12400][Shuffle] Avoid generating temp s...

2016-01-05 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/10376#issuecomment-169198730 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3873] [core] Import ordering fixes.

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10578#issuecomment-169198126 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-3873] [core] Import ordering fixes.

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10578#issuecomment-169198124 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12640][SQL] Add simple benchmarking uti...

2016-01-05 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/10589#discussion_r48921242 --- Diff: core/src/test/scala/org/apache/spark/Benchmark.scala --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: [SPARK-3873] [core] Import ordering fixes.

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10578#issuecomment-169197671 **[Test build #48799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48799/consoleFull)** for PR 10578 at commit [`c7bee0a`](https://g

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10583#discussion_r48921238 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -587,6 +586,13 @@ class Analyzer( case

[GitHub] spark pull request: [SPARK-11531] [ML] : SparseVector error Msg

2016-01-05 Thread rekhajoshm
Github user rekhajoshm commented on the pull request: https://github.com/apache/spark/pull/9525#issuecomment-169196705 Thanks @jkbradley might have missed it or thought it was under discussion.updated.thanks --- If your project is set up for it, you can reply to this email and have y

[GitHub] spark pull request: [SPARK-12591][Streaming]Register OpenHashMapBa...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10609#issuecomment-169196126 **[Test build #48808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48808/consoleFull)** for PR 10609 at commit [`0228eef`](https://gi

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10583#issuecomment-169196055 cc @cloud-fan can you take a look at this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark pull request: [SPARK-12644][SQL] Update parquet reader to be...

2016-01-05 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/10593#discussion_r48920875 --- Diff: core/src/test/scala/org/apache/spark/Benchmark.scala --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: [SPARK-11696] [ML, MLlib] Optimization: Extend...

2016-01-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9667#discussion_r48920477 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala --- @@ -133,7 +133,7 @@ class GradientDescent private[spark] (priv

[GitHub] spark pull request: [SPARK-11696] [ML, MLlib] Optimization: Extend...

2016-01-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9667#discussion_r48920506 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala --- @@ -178,7 +178,7 @@ object GradientDescent extends Logging {

[GitHub] spark pull request: [SPARK-11696] [ML, MLlib] Optimization: Extend...

2016-01-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9667#discussion_r48920464 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala --- @@ -122,8 +122,8 @@ class GradientDescent private[spark] (priv

[GitHub] spark pull request: [SPARK-11696] [ML, MLlib] Optimization: Extend...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9667#issuecomment-169193588 I see. Adding this seems reasonable since some spark.ml algorithms depend on these APIs. However, I want to avoid breaking the public optimization APIs in spark.mlli

[GitHub] spark pull request: [SPARK-12581][SQL] Support case-sensitive tabl...

2016-01-05 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/10523#issuecomment-169193276 @yhuai Yes, quoted tables in postgres are always case-sensitive. We need to support case-insensitive table names? Table names in sparksql (`DataFrame#registerTempTable`)

[GitHub] spark pull request: [SPARK-12504][SQL] Masking credentials in the ...

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10452 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10573 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12504][SQL] Masking credentials in the ...

2016-01-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10452#issuecomment-169192724 Thanks, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-12591][Streaming]Register OpenHashMapBa...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10609#issuecomment-169191999 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12591][Streaming]Register OpenHashMapBa...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10609#issuecomment-169192001 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12591][Streaming]Register OpenHashMapBa...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10609#issuecomment-169191880 **[Test build #48798 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48798/consoleFull)** for PR 10609 at commit [`7466a50`](https://g

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10583#discussion_r48919495 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -129,23 +129,39 @@ object UnresolvedAttribute { n

[GitHub] spark pull request: [SPARK-12659] fix NPE in UnsafeExternalSorter ...

2016-01-05 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10606#discussion_r48919509 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java --- @@ -223,14 +227,9 @@ public void loadNext() {

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10583#discussion_r48919450 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -587,6 +586,13 @@ class Analyzer( case

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10583#discussion_r48919389 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/parser/ParseUtils.java --- @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Softwar

[GitHub] spark pull request: [SPARK-11579] [ML] avoid creating new optimize...

2016-01-05 Thread hhbyyh
Github user hhbyyh closed the pull request at: https://github.com/apache/spark/pull/9614 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-05 Thread QiangCai
Github user QiangCai commented on the pull request: https://github.com/apache/spark/pull/10562#issuecomment-169191091 I think I have resolved this problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10583#discussion_r48919353 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/parser/ParseUtils.java --- @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Softwar

[GitHub] spark pull request: [SPARK-11579] [ML] avoid creating new optimize...

2016-01-05 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/9614#issuecomment-169191098 OK. I'll close this. Thanks for helping review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-12663] [MLlib] More informative error m...

2016-01-05 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/10611#issuecomment-169190994 @robert-dodier thanks for your PR. Can you please fix the style issue? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-12663] [MLlib] More informative error m...

2016-01-05 Thread thunterdb
Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/10611#discussion_r48919311 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala --- @@ -86,7 +86,7 @@ object MLUtils { val indicesLength = indices.len

[GitHub] spark pull request: [SPARK-12663] [MLlib] More informative error m...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10611#issuecomment-169190664 **[Test build #2332 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2332/consoleFull)** for PR 10611 at commit [`8ae7d35`](https://

[GitHub] spark pull request: [SPARK-12663] [MLlib] More informative error m...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10611#issuecomment-169190431 **[Test build #2332 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2332/consoleFull)** for PR 10611 at commit [`8ae7d35`](https://g

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r48919100 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -221,3 +224,147 @@ case class Murmur3Hash(children: Seq[

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r48918992 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -221,3 +224,147 @@ case class Murmur3Hash(children: Seq[

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r48918891 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -221,3 +224,147 @@ case class Murmur3Hash(children: Seq[

[GitHub] spark pull request: [SPARK-7675][ML][PYSpark] sparkml params type ...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9581#issuecomment-169189182 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-7675][ML][PYSpark] sparkml params type ...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9581#issuecomment-169189178 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12659] fix NPE in UnsafeExternalSorter ...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10606#issuecomment-169187517 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12659] fix NPE in UnsafeExternalSorter ...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10606#issuecomment-169187512 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12631] [PYSPARK] [DOC] PySpark clusteri...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10610#issuecomment-169187255 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12659] fix NPE in UnsafeExternalSorter ...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10606#issuecomment-169187237 **[Test build #48793 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48793/consoleFull)** for PR 10606 at commit [`ea9f019`](https://g

[GitHub] spark pull request: [SPARK-12631] [PYSPARK] [DOC] PySpark clusteri...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10610#issuecomment-169187257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12631] [PYSPARK] [DOC] PySpark clusteri...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10610#issuecomment-169187125 **[Test build #48802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48802/consoleFull)** for PR 10610 at commit [`1f85561`](https://g

[GitHub] spark pull request: [SPARK-12593][SQL][WIP] Converts resolved logi...

2016-01-05 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10541#issuecomment-169186628 Tests finally pass! (The last build failure was actually triggered by an older commit.) --- If your project is set up for it, you can reply to this email and have yo

[GitHub] spark pull request: [SPARK-12295] [SQL] external spilling for wind...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10605#issuecomment-169186092 **[Test build #48806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48806/consoleFull)** for PR 10605 at commit [`f464cf6`](https://gi

[GitHub] spark pull request: [SPARK-12663] [MLlib] More informative error m...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10611#issuecomment-169185779 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-12632][Python][Make Parameter Descripti...

2016-01-05 Thread BryanCutler
Github user BryanCutler commented on the pull request: https://github.com/apache/spark/pull/10602#issuecomment-16918 Thanks @somideshmukh! Could you please look the corrections from @vijaykiran and me, extend the descriptions to the 100 character limit, and add the parameter desc

[GitHub] spark pull request: [SPARK-12663] [MLlib] More informative error m...

2016-01-05 Thread robert-dodier
GitHub user robert-dodier opened a pull request: https://github.com/apache/spark/pull/10611 [SPARK-12663] [MLlib] More informative error message in MLUtils.loadLibSVMFile This PR contains 1 commit which resolves [SPARK-12663](https://issues.apache.org/jira/browse/SPARK-12663).

[GitHub] spark pull request: [SPARK-12632][Python][Make Parameter Descripti...

2016-01-05 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10602#discussion_r48917505 --- Diff: python/pyspark/mllib/fpm.py --- @@ -68,11 +68,14 @@ def train(cls, data, minSupport=0.3, numPartitions=-1): """ Comput

[GitHub] spark pull request: [SPARK-7675][ML][PYSpark] sparkml params type ...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9581#issuecomment-169183939 **[Test build #48805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48805/consoleFull)** for PR 9581 at commit [`526d64f`](https://git

[GitHub] spark pull request: [SPARK-7675][ML][PYSpark] sparkml params type ...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9581#issuecomment-169183941 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

<    1   2   3   4   5   6   7   8   9   >