Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12138#issuecomment-209262219
@cloud-fan The obvious wrong case is Expand's constraints. I've modified
the test in `ConstraintPropagationSuite`. Basically the previous usage works
except for constrai
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12138#discussion_r59500928
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -512,24 +512,35 @@ private[sql] object Expand {
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/12334#issuecomment-209258675
Overall looks ok, just have a few minor questions:
- now there's a single, unversioned "spark-parent" regardless of which
Scala version you're using; did you mak
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11015#issuecomment-209256122
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11015#issuecomment-209256119
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11015#issuecomment-209255907
**[Test build #55694 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55694/consoleFull)**
for PR 11015 at commit
[`e27fe71`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12269#issuecomment-209254529
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12271#issuecomment-209254390
**[Test build #55696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55696/consoleFull)**
for PR 12271 at commit
[`02738fe`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12269#issuecomment-209254535
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12351#issuecomment-209254371
**[Test build #55695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55695/consoleFull)**
for PR 12351 at commit
[`ccc72e1`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12269#issuecomment-209254162
**[Test build #55691 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55691/consoleFull)**
for PR 12269 at commit
[`e58cf23`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11301#issuecomment-209252883
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11301#issuecomment-209252886
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12271#issuecomment-209252514
**[Test build #55693 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55693/consoleFull)**
for PR 12271 at commit
[`a60e66a`](https://gi
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/12351
[SPARK-14593][SQL] Make currentVars work with splitExpressions to enable
whole stage codegen for large input columns
## What changes were proposed in this pull request?
JIRA: https://issues.apac
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11301#issuecomment-209252525
**[Test build #55687 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55687/consoleFull)**
for PR 11301 at commit
[`d22d610`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11015#issuecomment-209252511
**[Test build #55694 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55694/consoleFull)**
for PR 11015 at commit
[`e27fe71`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12342#issuecomment-209249372
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12342#issuecomment-209248699
**[Test build #55688 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55688/consoleFull)**
for PR 12342 at commit
[`21c8482`](https://g
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12157#issuecomment-209247352
I'm wary of giving equals semantics to partitions, since the current
semantics in this commit seem incorrect: partition 13 from one RDD is not equal
to partition 13 from
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12271#issuecomment-209247087
**[Test build #55692 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55692/consoleFull)**
for PR 12271 at commit
[`59edce3`](https://gi
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-209247018
Can you summarize the list of database systems that support this syntax?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59497215
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -435,13 +480,15 @@ class HiveSqlAstBuilder extends SparkSqlAs
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-209244788
I am not nessecarily against this but I find these quite confusing. Why not
just write `>=` or `<=`?
The PR itself looks pretty solid.
---
If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12126#issuecomment-209243986
Merging in master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12126#issuecomment-209240472
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12126#issuecomment-209240468
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12126#issuecomment-209240279
**[Test build #55684 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55684/consoleFull)**
for PR 12126 at commit
[`273c0aa`](https://g
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/12336#issuecomment-209238027
`?=` seems to do the trick, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12342#issuecomment-209233666
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12342#issuecomment-209233668
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12342#issuecomment-209233403
**[Test build #55686 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55686/consoleFull)**
for PR 12342 at commit
[`099b668`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12269#issuecomment-209232767
**[Test build #55691 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55691/consoleFull)**
for PR 12269 at commit
[`e58cf23`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12342#issuecomment-209232569
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12342#issuecomment-209232566
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12342#issuecomment-209232491
**[Test build #55685 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55685/consoleFull)**
for PR 12342 at commit
[`3c11e4c`](https://g
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/12126#issuecomment-209232413
LGTM pending Jenkins. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12349#issuecomment-209232165
btw https://spark-prs.appspot.com/ already does this for you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12349#issuecomment-209232172
**[Test build #55689 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55689/consoleFull)**
for PR 12349 at commit
[`9a8b509`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12348#issuecomment-209232158
**[Test build #55690 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55690/consoleFull)**
for PR 12348 at commit
[`7250fce`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12349#issuecomment-209229451
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12349#issuecomment-209229455
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12349#issuecomment-209229345
**[Test build #55682 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55682/consoleFull)**
for PR 12349 at commit
[`d927d13`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12342#issuecomment-209228701
**[Test build #55688 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55688/consoleFull)**
for PR 12342 at commit
[`21c8482`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12348#issuecomment-209228513
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12348#issuecomment-209228510
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12348#issuecomment-209228412
**[Test build #55681 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55681/consoleFull)**
for PR 12348 at commit
[`1f9d6fe`](https://g
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12342#issuecomment-209228199
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12350#issuecomment-209227366
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12350#issuecomment-209227367
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12342#discussion_r59492783
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -975,6 +940,68 @@ object PushPredicateThroughAggregat
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12350#issuecomment-209227265
**[Test build #55683 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55683/consoleFull)**
for PR 12350 at commit
[`f282a8d`](https://g
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59492629
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -121,84 +123,115 @@ class HiveSqlAstBuilder extends SparkSqlA
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12342#discussion_r59492551
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala
---
@@ -681,4 +679,67 @@ class FilterPushdownSuite
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59492242
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -121,84 +123,115 @@ class HiveSqlAstBuilder extends SparkSqlA
Github user lresende commented on the pull request:
https://github.com/apache/spark/pull/12349#issuecomment-209225537
ok, I will leave it open for a day in case anyone else has interest on the
change, otherwise close it.
---
If your project is set up for it, you can reply to this ema
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11301#issuecomment-209224318
**[Test build #55687 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55687/consoleFull)**
for PR 11301 at commit
[`d22d610`](https://gi
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12349#issuecomment-209222504
I'm not sure if we want this. People are already complaining the template
is too long. This creates more work to create a pr, and does not add any extra
information.
--
Github user lresende commented on the pull request:
https://github.com/apache/spark/pull/12349#issuecomment-209221983
@rxin It is, but you then have to search for the jira. This makes it much
more easy to just access the jira, from the link, similar to how the jira has
the link to the
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59491556
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -790,14 +821,13 @@ class HiveCompatibi
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59491359
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -490,15 +538,13 @@ class HiveCompatibi
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59491266
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -509,7 +555,7 @@ class HiveCompatibili
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12342#issuecomment-209219838
**[Test build #55686 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55686/consoleFull)**
for PR 12342 at commit
[`099b668`](https://gi
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59491102
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -509,7 +555,7 @@ class HiveCompatibili
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12342#issuecomment-209218940
**[Test build #55685 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55685/consoleFull)**
for PR 12342 at commit
[`3c11e4c`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12126#issuecomment-209217681
**[Test build #55684 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55684/consoleFull)**
for PR 12126 at commit
[`273c0aa`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12347#issuecomment-209217404
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12349#issuecomment-209217502
Isn't this obvious from the JIRA title?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12347#issuecomment-209217405
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12347#issuecomment-209217278
**[Test build #55680 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55680/consoleFull)**
for PR 12347 at commit
[`06c8948`](https://g
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/12342#issuecomment-209217192
@cloud-fan Most of the predicates are determistic, so I'd like to not push
down non-determistic predicate aggresively in this PR.
---
If your project is set up for it,
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/12126#issuecomment-209217089
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12342#discussion_r59490343
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -975,6 +939,73 @@ object PushPredicateThroughAggregate
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/12126#issuecomment-209216092
@rxin would you mind taking a look, or should I close this PR? Thank you!
:-)
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12350#issuecomment-209215778
**[Test build #55683 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55683/consoleFull)**
for PR 12350 at commit
[`f282a8d`](https://gi
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12324#issuecomment-209215575
cc @yhuai @andrewor14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/12350
[SPARK-14499] [SQL] [TEST] Drop Partition Does Not Delete Data of External
Tables
What changes were proposed in this pull request?
This PR is to add a test to ensure drop partitions of
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12346
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12346#issuecomment-209213072
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12346#issuecomment-209213073
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12346#issuecomment-209212967
**[Test build #55679 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55679/consoleFull)**
for PR 12346 at commit
[`00180bd`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12349#issuecomment-209212144
**[Test build #55682 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55682/consoleFull)**
for PR 12349 at commit
[`d927d13`](https://gi
GitHub user lresende opened a pull request:
https://github.com/apache/spark/pull/12349
[SPARK-14590] Update pull request template with JIRA link
## What changes were proposed in this pull request?
Update pull request template to have direct link to jira issue
You can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12345#issuecomment-209210452
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12342#discussion_r59488521
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -975,6 +939,73 @@ object PushPredicateThroughAggregat
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12345#issuecomment-209210454
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12345#issuecomment-209210278
**[Test build #55678 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55678/consoleFull)**
for PR 12345 at commit
[`c2fc385`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12348#issuecomment-209209961
**[Test build #55681 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55681/consoleFull)**
for PR 12348 at commit
[`1f9d6fe`](https://gi
GitHub user lresende opened a pull request:
https://github.com/apache/spark/pull/12348
[SPARK-14589][SQL] Enhance DB2 JDBC Dialect docker tests
## What changes were proposed in this pull request?
Enhance the DB2 JDBC Dialect docker tests as they seemed to have had some
issu
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12342#issuecomment-209209559
My general thoughts about filter push down: If the filter's condition is
non-deterministic, we shouldn't push it down through some operators that will
change the numb
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12345#issuecomment-209209164
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12345#issuecomment-209209159
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12345#issuecomment-209208765
**[Test build #55677 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55677/consoleFull)**
for PR 12345 at commit
[`4ee5687`](https://g
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12342#discussion_r59487855
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -975,6 +939,73 @@ object PushPredicateThroughAggregate e
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12342#discussion_r59487786
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -975,6 +939,73 @@ object PushPredicateThroughAggregate e
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12342#discussion_r59487680
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -975,6 +939,73 @@ object PushPredicateThroughAggregat
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11925#discussion_r59487598
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -196,4 +195,148 @@ class HDFSMetadataLog[T: ClassTa
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12342#discussion_r59487580
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -975,6 +939,73 @@ object PushPredicateThroughAggregat
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12194#issuecomment-209205949
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
1 - 100 of 729 matches
Mail list logo
