[GitHub] spark pull request: [SPARK-13992][Core][PySpark][FollowUp] Update ...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12126#issuecomment-209240468 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13992][Core][PySpark][FollowUp] Update ...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12126#issuecomment-209240472 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13992][Core][PySpark][FollowUp] Update ...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12126#issuecomment-209240279 **[Test build #55684 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55684/consoleFull)** for PR 12126 at commit

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

2016-04-12 Thread BryanCutler
Github user BryanCutler commented on the pull request: https://github.com/apache/spark/pull/12336#issuecomment-209238027 `?=` seems to do the trick, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12342#issuecomment-209233666 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12342#issuecomment-209233668 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12342#issuecomment-209233403 **[Test build #55686 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55686/consoleFull)** for PR 12342 at commit

[GitHub] spark pull request: [SPARK-13419] Update SubquerySuite to use chec...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12269#issuecomment-209232767 **[Test build #55691 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55691/consoleFull)** for PR 12269 at commit

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12342#issuecomment-209232569 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12342#issuecomment-209232566 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12342#issuecomment-209232491 **[Test build #55685 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55685/consoleFull)** for PR 12342 at commit

[GitHub] spark pull request: [SPARK-13992][Core][PySpark][FollowUp] Update ...

2016-04-12 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12126#issuecomment-209232413 LGTM pending Jenkins. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...

2016-04-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209232165 btw https://spark-prs.appspot.com/ already does this for you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209232172 **[Test build #55689 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55689/consoleFull)** for PR 12349 at commit

[GitHub] spark pull request: [SPARK-14589][SQL] Enhance DB2 JDBC Dialect do...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12348#issuecomment-209232158 **[Test build #55690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55690/consoleFull)** for PR 12348 at commit

[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209229451 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209229455 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209229345 **[Test build #55682 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55682/consoleFull)** for PR 12349 at commit

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12342#issuecomment-209228701 **[Test build #55688 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55688/consoleFull)** for PR 12342 at commit

[GitHub] spark pull request: [SPARK-14589][SQL] Enhance DB2 JDBC Dialect do...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12348#issuecomment-209228513 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14589][SQL] Enhance DB2 JDBC Dialect do...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12348#issuecomment-209228510 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14589][SQL] Enhance DB2 JDBC Dialect do...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12348#issuecomment-209228412 **[Test build #55681 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55681/consoleFull)** for PR 12348 at commit

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12342#issuecomment-209228199 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-14499] [SQL] [TEST] Drop Partition Does...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12350#issuecomment-209227366 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14499] [SQL] [TEST] Drop Partition Does...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12350#issuecomment-209227367 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12342#discussion_r59492783 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -975,6 +940,68 @@ object

[GitHub] spark pull request: [SPARK-14499] [SQL] [TEST] Drop Partition Does...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12350#issuecomment-209227265 **[Test build #55683 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55683/consoleFull)** for PR 12350 at commit

[GitHub] spark pull request: [SPARK-14388][SQL] Implement CREATE TABLE

2016-04-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12271#discussion_r59492629 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala --- @@ -121,84 +123,115 @@ class HiveSqlAstBuilder extends

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12342#discussion_r59492551 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala --- @@ -681,4 +679,67 @@ class

[GitHub] spark pull request: [SPARK-14388][SQL] Implement CREATE TABLE

2016-04-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12271#discussion_r59492242 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala --- @@ -121,84 +123,115 @@ class HiveSqlAstBuilder extends

[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...

2016-04-12 Thread lresende
Github user lresende commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209225537 ok, I will leave it open for a day in case anyone else has interest on the change, otherwise close it. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-209224318 **[Test build #55687 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55687/consoleFull)** for PR 11301 at commit

[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...

2016-04-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209222504 I'm not sure if we want this. People are already complaining the template is too long. This creates more work to create a pr, and does not add any extra information.

[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...

2016-04-12 Thread lresende
Github user lresende commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209221983 @rxin It is, but you then have to search for the jira. This makes it much more easy to just access the jira, from the link, similar to how the jira has the link to

[GitHub] spark pull request: [SPARK-14388][SQL] Implement CREATE TABLE

2016-04-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12271#discussion_r59491556 --- Diff: sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala --- @@ -790,14 +821,13 @@ class

[GitHub] spark pull request: [SPARK-14388][SQL] Implement CREATE TABLE

2016-04-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12271#discussion_r59491359 --- Diff: sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala --- @@ -490,15 +538,13 @@ class

[GitHub] spark pull request: [SPARK-14388][SQL] Implement CREATE TABLE

2016-04-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12271#discussion_r59491266 --- Diff: sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala --- @@ -509,7 +555,7 @@ class

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12342#issuecomment-209219838 **[Test build #55686 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55686/consoleFull)** for PR 12342 at commit

[GitHub] spark pull request: [SPARK-14388][SQL] Implement CREATE TABLE

2016-04-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12271#discussion_r59491102 --- Diff: sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala --- @@ -509,7 +555,7 @@ class

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12342#issuecomment-209218940 **[Test build #55685 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55685/consoleFull)** for PR 12342 at commit

[GitHub] spark pull request: [SPARK-13992][Core][PySpark][FollowUp] Update ...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12126#issuecomment-209217681 **[Test build #55684 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55684/consoleFull)** for PR 12126 at commit

[GitHub] spark pull request: [SPARK-14441] [SQL] Consolidate DDL tests

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12347#issuecomment-209217404 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...

2016-04-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209217502 Isn't this obvious from the JIRA title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14441] [SQL] Consolidate DDL tests

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12347#issuecomment-209217405 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14441] [SQL] Consolidate DDL tests

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12347#issuecomment-209217278 **[Test build #55680 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55680/consoleFull)** for PR 12347 at commit

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12342#issuecomment-209217192 @cloud-fan Most of the predicates are determistic, so I'd like to not push down non-determistic predicate aggresively in this PR. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-13992][Core][PySpark][FollowUp] Update ...

2016-04-12 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12126#issuecomment-209217089 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12342#discussion_r59490343 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -975,6 +939,73 @@ object

[GitHub] spark pull request: [SPARK-13992][Core][PySpark][FollowUp] Update ...

2016-04-12 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12126#issuecomment-209216092 @rxin would you mind taking a look, or should I close this PR? Thank you! :-) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-14499] [SQL] [TEST] Drop Partition Does...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12350#issuecomment-209215778 **[Test build #55683 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55683/consoleFull)** for PR 12350 at commit

[GitHub] spark pull request: [SPARK-14125] [SQL] Native DDL Support: Alter ...

2016-04-12 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12324#issuecomment-209215575 cc @yhuai @andrewor14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14499] [SQL] [TEST] Drop Partition Does...

2016-04-12 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/12350 [SPARK-14499] [SQL] [TEST] Drop Partition Does Not Delete Data of External Tables What changes were proposed in this pull request? This PR is to add a test to ensure drop partitions of

[GitHub] spark pull request: [SPARK-14554][SQL][follow-up] use checkDataset...

2016-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12346 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14554][SQL][follow-up] use checkDataset...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12346#issuecomment-209213072 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14554][SQL][follow-up] use checkDataset...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12346#issuecomment-209213073 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14554][SQL][follow-up] use checkDataset...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12346#issuecomment-209212967 **[Test build #55679 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55679/consoleFull)** for PR 12346 at commit

[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209212144 **[Test build #55682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55682/consoleFull)** for PR 12349 at commit

[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...

2016-04-12 Thread lresende
GitHub user lresende opened a pull request: https://github.com/apache/spark/pull/12349 [SPARK-14590] Update pull request template with JIRA link ## What changes were proposed in this pull request? Update pull request template to have direct link to jira issue You can

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12342#discussion_r59488521 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -975,6 +939,73 @@ object

[GitHub] spark pull request: [SPARK-14447][SQL] Speed up TungstenAggregate ...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12345#issuecomment-209210452 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14447][SQL] Speed up TungstenAggregate ...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12345#issuecomment-209210454 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14447][SQL] Speed up TungstenAggregate ...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12345#issuecomment-209210278 **[Test build #55678 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55678/consoleFull)** for PR 12345 at commit

[GitHub] spark pull request: [SPARK-14589][SQL] Enhance DB2 JDBC Dialect do...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12348#issuecomment-209209961 **[Test build #55681 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55681/consoleFull)** for PR 12348 at commit

[GitHub] spark pull request: [SPARK-14589][SQL] Enhance DB2 JDBC Dialect do...

2016-04-12 Thread lresende
GitHub user lresende opened a pull request: https://github.com/apache/spark/pull/12348 [SPARK-14589][SQL] Enhance DB2 JDBC Dialect docker tests ## What changes were proposed in this pull request? Enhance the DB2 JDBC Dialect docker tests as they seemed to have had some

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12342#issuecomment-209209559 My general thoughts about filter push down: If the filter's condition is non-deterministic, we shouldn't push it down through some operators that will change the

[GitHub] spark pull request: [SPARK-14447][SQL] Speed up TungstenAggregate ...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12345#issuecomment-209209164 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14447][SQL] Speed up TungstenAggregate ...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12345#issuecomment-209209159 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14447][SQL] Speed up TungstenAggregate ...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12345#issuecomment-209208765 **[Test build #55677 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55677/consoleFull)** for PR 12345 at commit

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12342#discussion_r59487855 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -975,6 +939,73 @@ object PushPredicateThroughAggregate

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12342#discussion_r59487786 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -975,6 +939,73 @@ object PushPredicateThroughAggregate

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12342#discussion_r59487680 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -975,6 +939,73 @@ object

[GitHub] spark pull request: [SPARK-14109][SQL] Fix HDFSMetadataLog to fall...

2016-04-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/11925#discussion_r59487598 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala --- @@ -196,4 +195,148 @@ class HDFSMetadataLog[T:

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12342#discussion_r59487580 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -975,6 +939,73 @@ object

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-209205949 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-209205945 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-209205565 **[Test build #55676 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55676/consoleFull)** for PR 12194 at commit

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12342#discussion_r59486877 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -975,6 +939,73 @@ object PushPredicateThroughAggregate

[GitHub] spark pull request: [SPARK-14581] [SQL] push predicatese through m...

2016-04-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12342#discussion_r59486756 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -975,6 +939,73 @@ object

[GitHub] spark pull request: [TEST] Test cherry-pick of a commit into branc...

2016-04-12 Thread ericl
Github user ericl closed the pull request at: https://github.com/apache/spark/pull/12343 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [WIP][SPARK-14447] Experiments: AggregateHashM...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12224#issuecomment-209203350 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [WIP][SPARK-14447] Experiments: AggregateHashM...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12224#issuecomment-209203348 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [WIP][SPARK-14447] Experiments: AggregateHashM...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12224#issuecomment-209203224 **[Test build #55675 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55675/consoleFull)** for PR 12224 at commit

[GitHub] spark pull request: [TEST] Test cherry-pick of a commit into branc...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12343#issuecomment-209202161 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [TEST] Test cherry-pick of a commit into branc...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12343#issuecomment-209202157 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [TEST] Test cherry-pick of a commit into branc...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12343#issuecomment-209201893 **[Test build #55673 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55673/consoleFull)** for PR 12343 at commit

[GitHub] spark pull request: [SPARK-14556][SQL] Code clean-ups for package ...

2016-04-12 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12323#issuecomment-209201130 @zsxwing thank you for the review & merging ! :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-14441] [SQL] Consolidate DDL tests

2016-04-12 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12347#issuecomment-209200845 To be honest, I do not know why we need to merge these test case files. Their purposes are different. One is to verify the functionalities of parsers; another is to

[GitHub] spark pull request: [SPARK-14574][BUILD][test-maven] Stop cross-bu...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12334#issuecomment-209200571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14574][BUILD][test-maven] Stop cross-bu...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12334#issuecomment-209200573 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14574][BUILD][test-maven] Stop cross-bu...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12334#issuecomment-209200262 **[Test build #55668 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55668/consoleFull)** for PR 12334 at commit

[GitHub] spark pull request: [SPARK-14441] [SQL] Consolidate DDL tests

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12347#issuecomment-209200120 **[Test build #55680 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55680/consoleFull)** for PR 12347 at commit

[GitHub] spark pull request: [SPARK-14441] [SQL] Consolidate DDL tests

2016-04-12 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12347#issuecomment-209200210 ```Use .contains(...) instead == Some(...) for Options, this method is introduced in Scala 2.11 and it is recommended method to use for this purpose;``` This

[GitHub] spark pull request: [SPARK-14441] [SQL] Consolidate DDL tests

2016-04-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12347#discussion_r59485621 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala --- @@ -113,10 +244,10 @@ class HiveDDLCommandSuite extends

[GitHub] spark pull request: [SPARK-13681][SPARK-14458][SPARK-14566][SQL] A...

2016-04-12 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12179#issuecomment-209199922 LGTM (assume the tests are just copy-pasted from original code) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-14441] [SQL] Consolidate DDL tests

2016-04-12 Thread bomeng
GitHub user bomeng opened a pull request: https://github.com/apache/spark/pull/12347 [SPARK-14441] [SQL] Consolidate DDL tests ## What changes were proposed in this pull request? Today we have `DDLSuite`, `DDLCommandSuite`, `HiveDDLCommandSuite` and `HiveDDLSuite`. In this

[GitHub] spark pull request: [MINOR][SQL] Remove some unused imports in dat...

2016-04-12 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12326#issuecomment-209197528 @HyukjinKwon could you open another PR to remove the `SqlNewHadoopRDD`? I think it's not needed anymore. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [MINOR][SQL] Remove some unused imports in dat...

2016-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12326 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [MINOR][SQL] Remove some unused imports in dat...

2016-04-12 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12326#issuecomment-209197308 Thanks ! merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14554][SQL][follow-up] use checkDataset...

2016-04-12 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/12346#issuecomment-209196952 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [MINOR][SQL] Remove some unused imports in dat...

2016-04-12 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12326#issuecomment-209196372 LGTM, cc @liancheng @yhuai should we remove `SqlNewHadoopRDD`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

  1   2   3   4   5   6   7   8   >