[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r70882380 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -509,6 +512,23 @@ class AstBuilder extends SqlBaseBase

[GitHub] spark issue #14176: [SPARK-16525][SQL] Enable Row Based HashMap in HashAggre...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14176 **[Test build #62349 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62349/consoleFull)** for PR 14176 at commit [`225b661`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14167 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14167 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62341/ Test FAILed. ---

[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14167 **[Test build #62341 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62341/consoleFull)** for PR 14167 at commit [`1bfee1d`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14173: [SPARKR][SPARK-16507] Add a CRAN checker, fix Rd aliases

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14173 **[Test build #62348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62348/consoleFull)** for PR 14173 at commit [`bc9305d`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #14173: [SPARKR][SPARK-16507] Add a CRAN checker, fix Rd aliases

2016-07-14 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14173 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r70881062 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -945,8 +955,12 @@ SIMPLE_COMMENT : '--' ~[\r\n]* '\

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14132 **[Test build #62347 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62347/consoleFull)** for PR 14132 at commit [`142f5ef`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14132 Now, both the code and description of this PR is updated. Locally, it passed `sql/catalyst` and `sql/core`. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] spark issue #13670: [SPARK-15951] Change Executors Page to use datatables to...

2016-07-14 Thread kishorvpatil
Github user kishorvpatil commented on the issue: https://github.com/apache/spark/pull/13670 @tgravescs , moved `formatBytes` to `utils.js`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark issue #13670: [SPARK-15951] Change Executors Page to use datatables to...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13670 **[Test build #62346 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62346/consoleFull)** for PR 13670 at commit [`66df19f`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuilder for ...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14201 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62334/ Test PASSed. ---

[GitHub] spark issue #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuilder for ...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14201 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuilder for ...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14201 **[Test build #62334 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62334/consoleFull)** for PR 14201 at commit [`deca998`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r70876188 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -399,7 +402,16 @@ class AstBuilder extends SqlBaseB

[GitHub] spark issue #14173: [SPARKR][SPARK-16507] Add a CRAN checker, fix Rd aliases

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14173 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62335/ Test FAILed. ---

[GitHub] spark issue #14173: [SPARKR][SPARK-16507] Add a CRAN checker, fix Rd aliases

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14173 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14173: [SPARKR][SPARK-16507] Add a CRAN checker, fix Rd aliases

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14173 **[Test build #62335 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62335/consoleFull)** for PR 14173 at commit [`e4ad2ec`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r70874930 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -399,7 +402,16 @@ class AstBuilder extends SqlBaseBase

[GitHub] spark issue #14207: [SPARK-16552] [SQL] [WIP] Store the Inferred Schemas int...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14207 **[Test build #62344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62344/consoleFull)** for PR 14207 at commit [`3be0dc0`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #14189: [SPARK-16535][Build] In pom.xml, remove groupId which is...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14189 **[Test build #62345 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62345/consoleFull)** for PR 14189 at commit [`b0decb1`](https://github.com/apache/spark/commit/b

[GitHub] spark pull request #14207: [SPARK-16552] [SQL] [WIP] Store the Inferred Sche...

2016-07-14 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/14207 [SPARK-16552] [SQL] [WIP] Store the Inferred Schemas into External Catalog Tables when Creating Tables What changes were proposed in this pull request? Currently, in Spark SQL, the

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14132 Thank you for confirming! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14189: [SPARK-16535][Build] In pom.xml, remove groupId which is...

2016-07-14 Thread keypointt
Github user keypointt commented on the issue: https://github.com/apache/spark/pull/14189 Get below error from Jenkins, but I tried again and it's working ok on my laptop when running the tests. ``` [info] DirectKafkaStreamSuite: [info] - basic stream receiving wit

[GitHub] spark issue #14101: [SPARK-16431] [ML] Add a unified method that accepts sin...

2016-07-14 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14101 I don't know ML that well. cc @jkbradley @thunterdb @dbtsai @yanboliang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14132 Yup - and "broadcast". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #14173: [SPARKR][SPARK-16507] Add a CRAN checker, fix Rd aliases

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14173 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14173: [SPARKR][SPARK-16507] Add a CRAN checker, fix Rd aliases

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14173 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62336/ Test FAILed. ---

[GitHub] spark issue #14173: [SPARKR][SPARK-16507] Add a CRAN checker, fix Rd aliases

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14173 **[Test build #62336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62336/consoleFull)** for PR 14173 at commit [`bc9305d`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14112: [SPARK-16240][ML] Model loading backward compatibility f...

2016-07-14 Thread GayathriMurali
Github user GayathriMurali commented on the issue: https://github.com/apache/spark/pull/14112 @jkbradley I implemented model loading logic for DistributedLDA as well. I am using a versionRegex for robustness in version checking. Using `as[Data].head()` is producing a scala match erro

[GitHub] spark pull request #14196: [SPARK-16540][YARN][CORE] Avoid adding jars twice...

2016-07-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14196#discussion_r70871820 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2409,9 +2409,9 @@ private[spark] object Utils extends Logging { * "spark.yarn.dis

[GitHub] spark issue #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuilder for ...

2016-07-14 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14201 Also, can you update the javadoc for `startApplication` to mention that output redirection is only done if it hasn't been configured by the user? --- If your project is set up for it, you can reply

[GitHub] spark issue #13670: [SPARK-15951] Change Executors Page to use datatables to...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13670 **[Test build #62343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62343/consoleFull)** for PR 13670 at commit [`bc132b1`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #14206: [SPARK-16538][SPARKR] Add more tests for namespace call ...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14206 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14132 I see. Sorry for misunderstanding. Let me summary again. The following is the final decision, right? ``` SELECT /*+ MAPJOIN(t) */ * FROM t JOIN u ON t.id = u.id SELECT /*+ MAPJOIN(u

[GitHub] spark issue #14206: [SPARK-16538][SPARKR] Add more tests for namespace call ...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14206 **[Test build #62342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62342/consoleFull)** for PR 14206 at commit [`2303a2c`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r70872438 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -399,7 +402,16 @@ class AstBuilder extends SqlBaseB

[GitHub] spark issue #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuilder for ...

2016-07-14 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14201 @andreweduffy can you change the title of the PR? The title of your commit (https://github.com/apache/spark/pull/14201/commits/deca998b725eeb7df2f12999c8bbac3c1ffc5161) is a better one. A fe

[GitHub] spark issue #13670: [SPARK-15951] Change Executors Page to use datatables to...

2016-07-14 Thread kishorvpatil
Github user kishorvpatil commented on the issue: https://github.com/apache/spark/pull/13670 @ajbozarth , I fixed the code for standalone mode as well. Sorry for not being fully aware of possible UI invocations. I will keep this in mind for future patches. --- If your project is set

[GitHub] spark issue #13670: [SPARK-15951] Change Executors Page to use datatables to...

2016-07-14 Thread kishorvpatil
Github user kishorvpatil commented on the issue: https://github.com/apache/spark/pull/13670 @tgravescs, fixed documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark issue #14206: [SPARK-16538][SPARKR] Add more tests for namespace call ...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14206 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62342/ Test PASSed. ---

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70871119 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -359,6 +364,82 @@ public SparkLauncher setVerbose(boolean verbose) {

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70870990 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -455,6 +542,36 @@ private ProcessBuilder createBuilder() { for (

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14132 OK what I meant was "supporting /*+ BROADCASTJOIN */", not the Impala style .. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70870422 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -82,8 +83,12 @@ /** Used internally to create unique logger names.

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14132 Thank you for all comments, @hvanhovell and @rxin . I'll update soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70870174 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -359,6 +364,82 @@ public SparkLauncher setVerbose(boolean verbose) {

[GitHub] spark issue #14189: [SPARK-16535][Build] In pom.xml, remove groupId which is...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14189 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62333/ Test FAILed. ---

[GitHub] spark issue #14189: [SPARK-16535][Build] In pom.xml, remove groupId which is...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14189 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70870046 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -359,6 +364,82 @@ public SparkLauncher setVerbose(boolean verbose) {

[GitHub] spark issue #14189: [SPARK-16535][Build] In pom.xml, remove groupId which is...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14189 **[Test build #62333 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62333/consoleFull)** for PR 14189 at commit [`e4e7270`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14132 Oh, I see. No problem. Thank you for guide. Then, could you update the JIRA too? I added this for the following comments. > For more information, please see the attached document. One note

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70869756 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -82,8 +83,12 @@ /** Used internally to create unique logger names.

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70869464 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -455,6 +542,36 @@ private ProcessBuilder createBuilder() { for (

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r70869241 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1774,6 +1775,39 @@ class Analyzer( }

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70869233 --- Diff: launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java --- @@ -52,6 +52,11 @@ final List pyFiles; final Map chil

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14132 @dongjoon-hyun please only support the Hive style mapjoin hint, and don't add the "LEFT OUTER JOIN BROADCAST" way. It'd mean queries written in Spark 2.1 would not work with earlier versions of Spark.

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r70867113 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -399,7 +402,16 @@ class AstBuilder extends SqlBaseB

[GitHub] spark issue #14202: [SPARK-16230] [CORE] CoarseGrainedExecutorBackend to sel...

2016-07-14 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/14202 Hi @zsxwing , can you please review this diff ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r70866390 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -399,7 +402,16 @@ class AstBuilder extends SqlBaseBase

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r70867118 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -374,8 +383,8 @@ setQuantifier relation

[GitHub] spark issue #14206: [SPARK-16538][SPARKR] Add more tests for namespace call ...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14206 **[Test build #62342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62342/consoleFull)** for PR 14206 at commit [`2303a2c`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #14195: [SPARK-16538][SPARKR] fix R call with namespace operator...

2016-07-14 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14195 Adding more tests in new PR. I'm hoping to remove deprecated functions and this routing mechanism as soon as 2.0.0 is released... --- If your project is set up for it, you can reply to this ema

[GitHub] spark issue #14206: [SPARK-16538][SPARKR] Add more tests for namespace call ...

2016-07-14 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14206 #14195 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #14206: [SPARK-16538][SPARKR] Add more tests for namespac...

2016-07-14 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/14206 [SPARK-16538][SPARKR] Add more tests for namespace call to SparkSession functions ## What changes were proposed in this pull request? More tests I don't think this is critical for

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r70866586 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1774,6 +1775,39 @@ class Analyzer( }

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-14 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r70866492 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -399,7 +402,16 @@ class AstBuilder extends SqlBaseBase

[GitHub] spark issue #14181: [SPARK-15382][SQL] Fix a rule to push down projects bene...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14181 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14181: [SPARK-15382][SQL] Fix a rule to push down projects bene...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14181 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62331/ Test PASSed. ---

[GitHub] spark issue #14181: [SPARK-15382][SQL] Fix a rule to push down projects bene...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14181 **[Test build #62331 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62331/consoleFull)** for PR 14181 at commit [`a868e09`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14167 **[Test build #62341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62341/consoleFull)** for PR 14167 at commit [`1bfee1d`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14167 **[Test build #62340 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62340/consoleFull)** for PR 14167 at commit [`9f7b151`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars

2016-07-14 Thread mgummelt
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/14167 Note that I'll add docs once the code is :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars

2016-07-14 Thread mgummelt
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/14167 @skonto comments addressed. Please re-review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark issue #14112: [SPARK-16240][ML] Model loading backward compatibility f...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14112 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62337/ Test PASSed. ---

[GitHub] spark issue #14112: [SPARK-16240][ML] Model loading backward compatibility f...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14112 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14112: [SPARK-16240][ML] Model loading backward compatibility f...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14112 **[Test build #62337 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62337/consoleFull)** for PR 14112 at commit [`8848f0e`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14139: [SPARK-16313][SQL][BRANCH-1.6] Spark should not s...

2016-07-14 Thread yhuai
Github user yhuai closed the pull request at: https://github.com/apache/spark/pull/14139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark issue #14139: [SPARK-16313][SQL][BRANCH-1.6] Spark should not silently...

2016-07-14 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/14139 Thank you! I am merging this PR to branch 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark issue #14022: [SPARK-16272][core] Allow config values to reference con...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14022 **[Test build #62339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62339/consoleFull)** for PR 14022 at commit [`cca8314`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #14179: [SPARK-16055][SPARKR] warning added while using sparkPac...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14179 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62338/ Test FAILed. ---

[GitHub] spark issue #14139: [SPARK-16313][SQL][BRANCH-1.6] Spark should not silently...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14139 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62330/ Test PASSed. ---

[GitHub] spark issue #14139: [SPARK-16313][SQL][BRANCH-1.6] Spark should not silently...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14139 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14139: [SPARK-16313][SQL][BRANCH-1.6] Spark should not silently...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14139 **[Test build #62330 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62330/consoleFull)** for PR 14139 at commit [`072aa3f`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14179: [SPARK-16055][SPARKR] warning added while using sparkPac...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14179 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14179: [SPARK-16055][SPARKR] warning added while using sparkPac...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14179 **[Test build #62338 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62338/consoleFull)** for PR 14179 at commit [`259c4af`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14205: [SPARK-16547] [CORE] EventLoggingListener to auto create...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14205 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62328/ Test FAILed. ---

[GitHub] spark issue #14205: [SPARK-16547] [CORE] EventLoggingListener to auto create...

2016-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14205 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14170: [SPARK-16531][SQL][TEST] Remove timezone setting from Da...

2016-07-14 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14170 Agree. I'd rather fix a timezone for all tests. Some tests don't happen to set one; I know some use GMT elsewhere. Well, it's an issue for another day, to standardize it if it causes enough pain at s

[GitHub] spark issue #14205: [SPARK-16547] [CORE] EventLoggingListener to auto create...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14205 **[Test build #62328 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62328/consoleFull)** for PR 14205 at commit [`b583552`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14179: [SPARK-16055][SPARKR] warning added while using s...

2016-07-14 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/14179#discussion_r70855973 --- Diff: R/pkg/R/sparkR.R --- @@ -155,6 +155,9 @@ sparkR.sparkContext <- function( existingPort <- Sys.getenv("EXISTING_SPARKR_BACKEND_PORT", "

[GitHub] spark issue #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuilder for ...

2016-07-14 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14201 > not clear why it can't find Guava on the classpath however This module does not depend on Guava (nor should it). --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #14170: [SPARK-16531][SQL][TEST] Remove timezone setting from Da...

2016-07-14 Thread marmbrus
Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/14170 Oh, I see what you are saying, although I'm not sure I agree with the conclusion. Given that tests can run in parallel I don't think you actually want to toggle back and forth between timezones.

[GitHub] spark issue #14193: [Minor][Build] Remove empty tags in parent pom.xml

2016-07-14 Thread keypointt
Github user keypointt commented on the issue: https://github.com/apache/spark/pull/14193 I get it now, thank you Sean for explaining this 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #14179: [SPARK-16055][SPARKR] warning added while using sparkPac...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14179 **[Test build #62338 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62338/consoleFull)** for PR 14179 at commit [`259c4af`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #14112: [SPARK-16240][ML] Model loading backward compatibility f...

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14112 **[Test build #62337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62337/consoleFull)** for PR 14112 at commit [`8848f0e`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #14173: [SPARKR][SPARK-16507] Add a CRAN checker, fix Rd aliases

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14173 **[Test build #62336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62336/consoleFull)** for PR 14173 at commit [`bc9305d`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #14193: [Minor][Build] Remove empty tags in parent pom.xml

2016-07-14 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14193 The first one sets a property with an empty value. I think this is necessary to refer to it in the Maven build even if it doesn't have a default value. The rest -- refer to the plugin docs for that t

[GitHub] spark issue #14173: [SPARKR][SPARK-16507] Add a CRAN checker, fix Rd aliases

2016-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14173 **[Test build #62335 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62335/consoleFull)** for PR 14173 at commit [`e4ad2ec`](https://github.com/apache/spark/commit/e

<    1   2   3   4   5   6   >