[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r74166832 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala --- @@ -18,21 +18,32 @@ package

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r74166431 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -689,4 +689,38 @@ class HiveDDLSuite ))

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r74166239 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -229,10 +230,8 @@ case class AlterTableSetPropertiesCommand(

[GitHub] spark pull request #14258: [Spark-16579][SparkR] add install.spark function

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14258#discussion_r74166055 --- Diff: R/pkg/R/install.R --- @@ -0,0 +1,230 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark issue #14433: [SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work

2016-08-09 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/14433 @felixcheung I have an idea of creating an Enum object in scala, like the example below: object WeekDay { sealed trait EnumVal case object Mon extends EnumVal case object

[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-08-09 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/11157 @mgummelt ready for review, I think now it is really simple... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-08-09 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r74165477 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -358,6 +376,119 @@ private[mesos] trait

[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11157 **[Test build #63480 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63480/consoleFull)** for PR 11157 at commit

[GitHub] spark pull request #14258: [Spark-16579][SparkR] add install.spark function

2016-08-09 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/14258#discussion_r74164995 --- Diff: R/pkg/R/install.R --- @@ -0,0 +1,230 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request #14258: [Spark-16579][SparkR] add install.spark function

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14258#discussion_r74164731 --- Diff: R/pkg/R/install.R --- @@ -0,0 +1,230 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark issue #14537: [SPARK-16948][SQL] Querying empty partitioned orc tables...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14537 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63474/ Test PASSed. ---

[GitHub] spark issue #14537: [SPARK-16948][SQL] Querying empty partitioned orc tables...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14537 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14537: [SPARK-16948][SQL] Querying empty partitioned orc tables...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14537 **[Test build #63474 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63474/consoleFull)** for PR 14537 at commit

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14568 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14568 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63473/ Test FAILed. ---

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14568 **[Test build #63473 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63473/consoleFull)** for PR 14568 at commit

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14472 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14472 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63471/ Test PASSed. ---

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14472 **[Test build #63471 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63471/consoleFull)** for PR 14472 at commit

[GitHub] spark issue #13152: [SPARK-15353] [CORE] Making peer selection for block rep...

2016-08-09 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/13152 LGTM. Just style comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #13152: [SPARK-15353] [CORE] Making peer selection for bl...

2016-08-09 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/13152#discussion_r74161999 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1088,109 +1108,88 @@ private[spark] class BlockManager( }

[GitHub] spark pull request #13152: [SPARK-15353] [CORE] Making peer selection for bl...

2016-08-09 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/13152#discussion_r74161937 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1088,109 +1108,88 @@ private[spark] class BlockManager( }

[GitHub] spark pull request #13152: [SPARK-15353] [CORE] Making peer selection for bl...

2016-08-09 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/13152#discussion_r74161980 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1088,109 +1108,88 @@ private[spark] class BlockManager( }

[GitHub] spark pull request #13152: [SPARK-15353] [CORE] Making peer selection for bl...

2016-08-09 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/13152#discussion_r74161947 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1088,109 +1108,88 @@ private[spark] class BlockManager( }

[GitHub] spark pull request #13152: [SPARK-15353] [CORE] Making peer selection for bl...

2016-08-09 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/13152#discussion_r74161892 --- Diff: core/src/main/scala/org/apache/spark/storage/TopologyMapper.scala --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #13152: [SPARK-15353] [CORE] Making peer selection for bl...

2016-08-09 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/13152#discussion_r74161782 --- Diff: core/src/main/scala/org/apache/spark/storage/TopologyMapper.scala --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #13152: [SPARK-15353] [CORE] Making peer selection for bl...

2016-08-09 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/13152#discussion_r74161774 --- Diff: core/src/main/scala/org/apache/spark/storage/TopologyMapper.scala --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13680 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13680 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63467/ Test PASSed. ---

[GitHub] spark pull request #13152: [SPARK-15353] [CORE] Making peer selection for bl...

2016-08-09 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/13152#discussion_r74161515 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockReplicationPrioritization.scala --- @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13680 **[Test build #63467 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63467/consoleFull)** for PR 13680 at commit

[GitHub] spark issue #14572: [SPARK-16552] [FOLLOW-UP] [SQL] Store the Inferred Schem...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14572 **[Test build #63479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63479/consoleFull)** for PR 14572 at commit

[GitHub] spark pull request #13152: [SPARK-15353] [CORE] Making peer selection for bl...

2016-08-09 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/13152#discussion_r74161348 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala --- @@ -126,6 +138,10 @@ class BlockManagerMasterEndpoint(

[GitHub] spark issue #14475: [SPARK-16862] Configurable buffer size in `UnsafeSorterS...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14475 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63465/ Test PASSed. ---

[GitHub] spark pull request #14572: [SPARK-16552] [FOLLOW-UP] [SQL] Store the Inferre...

2016-08-09 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/14572 [SPARK-16552] [FOLLOW-UP] [SQL] Store the Inferred Schemas into External Catalog Tables when Creating Tables ### What changes were proposed in this pull request? Address the comments by

[GitHub] spark issue #14475: [SPARK-16862] Configurable buffer size in `UnsafeSorterS...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14475 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14475: [SPARK-16862] Configurable buffer size in `UnsafeSorterS...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14475 **[Test build #63465 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63465/consoleFull)** for PR 14475 at commit

[GitHub] spark issue #14512: [WIP] Add SSL support to dispatcher and spark-submit

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14512 **[Test build #63478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63478/consoleFull)** for PR 14512 at commit

[GitHub] spark issue #14511: [SPARK-16927] [SPARK-16923] Override task properties at ...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14511 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63464/ Test PASSed. ---

[GitHub] spark issue #14511: [SPARK-16927] [SPARK-16923] Override task properties at ...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14511 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14511: [SPARK-16927] [SPARK-16923] Override task properties at ...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14511 **[Test build #63464 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63464/consoleFull)** for PR 14511 at commit

[GitHub] spark issue #14527: [SPARK-16938][SQL] `dropDuplicate` should not raise exce...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14527 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63468/ Test PASSed. ---

[GitHub] spark issue #14527: [SPARK-16938][SQL] `dropDuplicate` should not raise exce...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14527 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14527: [SPARK-16938][SQL] `dropDuplicate` should not raise exce...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14527 **[Test build #63468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63468/consoleFull)** for PR 14527 at commit

[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63477 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63477/consoleFull)** for PR 14571 at commit

[GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...

2016-08-09 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/14571 [SPARK-16983][SQL] Add `prettyName` for row_number, dense_rank, percent_rank, cume_dist ## What changes were proposed in this pull request? Currently, two-word window functions like

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14568 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63470/ Test FAILed. ---

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14568 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14568 **[Test build #63470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63470/consoleFull)** for PR 14568 at commit

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-08-09 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r74159170 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -358,6 +376,119 @@ private[mesos] trait

[GitHub] spark issue #14570: [SPARK-10601][SQL] Support `MINUS` set operator

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14570 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14570: [SPARK-10601][SQL] Support `MINUS` set operator

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14570 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63463/ Test PASSed. ---

[GitHub] spark pull request #14524: [SPARK-16832] [ML] [WIP] CrossValidator and Train...

2016-08-09 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/14524#discussion_r74159065 --- Diff: python/pyspark/ml/param/shared.py --- @@ -311,7 +311,7 @@ class HasSeed(Params): def __init__(self): super(HasSeed,

[GitHub] spark issue #14570: [SPARK-10601][SQL] Support `MINUS` set operator

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14570 **[Test build #63463 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63463/consoleFull)** for PR 14570 at commit

[GitHub] spark issue #14560: [SPARK-16971][SQL] Strip trailing zeros for decimal's st...

2016-08-09 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14560 (BTW, it seems this is what hive does) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14472 **[Test build #63476 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63476/consoleFull)** for PR 14472 at commit

[GitHub] spark issue #14569: Fixed typo

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14569 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63461/ Test PASSed. ---

[GitHub] spark issue #14569: Fixed typo

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14569 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14569: Fixed typo

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14569 **[Test build #63461 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63461/consoleFull)** for PR 14569 at commit

[GitHub] spark issue #14552: [SPARK-16952] don't lookup spark home directory when exe...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14552 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63460/ Test PASSed. ---

[GitHub] spark issue #14552: [SPARK-16952] don't lookup spark home directory when exe...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14552 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14552: [SPARK-16952] don't lookup spark home directory when exe...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14552 **[Test build #63460 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63460/consoleFull)** for PR 14552 at commit

[GitHub] spark issue #14524: [SPARK-16832] [ML] [WIP] CrossValidator and TrainValidat...

2016-08-09 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/14524 +1 for changing this. If left as is, JIRAs like this one will be a recurring theme. A lot of users would probably not even notice, then wind up getting degraded results and not know why.

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14568 **[Test build #63475 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63475/consoleFull)** for PR 14568 at commit

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-08-09 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r74158089 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -358,6 +376,119 @@ private[mesos] trait

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-08-09 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r74158079 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -358,6 +376,119 @@ private[mesos] trait

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-08-09 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r74157953 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -358,6 +376,119 @@ private[mesos] trait

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14568 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14568 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63469/ Test FAILed. ---

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14568 **[Test build #63469 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63469/consoleFull)** for PR 14568 at commit

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-08-09 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r74156824 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -358,6 +376,119 @@ private[mesos] trait

[GitHub] spark issue #14547: [SPARK-16718][MLlib] gbm-style treeboost [WIP]

2016-08-09 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/14547 CC: @hhbyyh Would you mind taking a look at this since you're familiar with GBTs? Thanks in advance! This should be one of the most important improvements in terms of accuracy, especially once

[GitHub] spark issue #14547: [SPARK-16718][MLlib] gbm-style treeboost [WIP]

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14547 **[Test build #3210 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3210/consoleFull)** for PR 14547 at commit

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-08-09 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r74156582 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -358,6 +376,119 @@ private[mesos] trait

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-08-09 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r74156410 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -358,6 +376,119 @@ private[mesos] trait

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14568 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63466/ Test FAILed. ---

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14568 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14568 **[Test build #63466 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63466/consoleFull)** for PR 14568 at commit

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-08-09 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r74155413 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -358,6 +376,119 @@ private[mesos] trait

[GitHub] spark issue #14547: [SPARK-16718][MLlib] gbm-style treeboost [WIP]

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14547 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63447/ Test FAILed. ---

[GitHub] spark issue #14547: [SPARK-16718][MLlib] gbm-style treeboost [WIP]

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14547 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14547: [SPARK-16718][MLlib] gbm-style treeboost [WIP]

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14547 **[Test build #63447 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63447/consoleFull)** for PR 14547 at commit

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-08-09 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r74155283 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -358,6 +376,119 @@ private[mesos] trait

[GitHub] spark issue #14537: [SPARK-16948][SQL] Querying empty partitioned orc tables...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14537 **[Test build #63474 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63474/consoleFull)** for PR 14537 at commit

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14568 **[Test build #63473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63473/consoleFull)** for PR 14568 at commit

[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...

2016-08-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Thank you so much! Then, see you later. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14537: [SPARK-16948][SQL] Querying empty partitioned orc tables...

2016-08-09 Thread rajeshbalamohan
Github user rajeshbalamohan commented on the issue: https://github.com/apache/spark/pull/14537 Thanks @mallman . Fixed review comments in latest commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...

2016-08-09 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14397 @dongjoon-hyun I'll take a look in the morning (CET) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14531 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63457/ Test PASSed. ---

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14531 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14531 **[Test build #63457 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63457/consoleFull)** for PR 14531 at commit

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14568 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14568 **[Test build #63472 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63472/consoleFull)** for PR 14568 at commit

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14568 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63472/ Test FAILed. ---

[GitHub] spark pull request #14397: [SPARK-16771][SQL] WITH clause should not fall in...

2016-08-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14397#discussion_r74153582 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -125,21 +125,23 @@ class Analyzer( object

[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...

2016-08-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Could you review this PR again, @hvanhovell ? Last time, I did a huge mistake, but now I think I fixed correct according to your advice. --- If your project is set up for it, you can

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14568 **[Test build #63472 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63472/consoleFull)** for PR 14568 at commit

[GitHub] spark pull request #14258: [Spark-16579][SparkR] add install.spark function

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14258#discussion_r74152794 --- Diff: R/pkg/R/install.R --- @@ -0,0 +1,230 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request #12990: [SPARK-15083] [Web UI] Limit total tasks displaye...

2016-08-09 Thread ajbozarth
Github user ajbozarth commented on a diff in the pull request: https://github.com/apache/spark/pull/12990#discussion_r74151754 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -137,6 +138,17 @@ class JobProgressListener(conf: SparkConf)

[GitHub] spark issue #14527: [SPARK-16938][SQL] `dropDuplicate` should not raise exce...

2016-08-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14527 Hi, @cloud-fan . Could you review this PR when you have some time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

<    1   2   3   4   5   6   7   8   >