[GitHub] spark pull request #14359: [SPARK-16719][ML] Random Forests should communica...

2016-08-18 Thread jodersky
Github user jodersky commented on a diff in the pull request: https://github.com/apache/spark/pull/14359#discussion_r75361458 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala --- @@ -161,31 +161,43 @@ private[spark] object RandomForest extends

[GitHub] spark pull request #14703: [SparkR][Example]change example APP name

2016-08-18 Thread wangmiao1981
GitHub user wangmiao1981 opened a pull request: https://github.com/apache/spark/pull/14703 [SparkR][Example]change example APP name ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) For R SQL example, appname is

[GitHub] spark issue #14623: [SPARK-17044][SQL] Make test files for window functions ...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14623 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63994/ Test PASSed. ---

[GitHub] spark issue #14623: [SPARK-17044][SQL] Make test files for window functions ...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14623 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13796: [SPARK-7159][ML] Add multiclass logistic regression to S...

2016-08-18 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/13796 I also created an umbrella JIRA for tracking follup items - [SPARK-17133](https://issues.apache.org/jira/browse/SPARK-17133) --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #14623: [SPARK-17044][SQL] Make test files for window functions ...

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14623 **[Test build #63994 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63994/consoleFull)** for PR 14623 at commit

[GitHub] spark issue #13796: [SPARK-7159][ML] Add multiclass logistic regression to S...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13796 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13796: [SPARK-7159][ML] Add multiclass logistic regression to S...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13796 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63996/ Test PASSed. ---

[GitHub] spark issue #13796: [SPARK-7159][ML] Add multiclass logistic regression to S...

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13796 **[Test build #63996 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63996/consoleFull)** for PR 13796 at commit

[GitHub] spark issue #14690: [SPARK-16980][SQL] Load only catalog table partition met...

2016-08-18 Thread mallman
Github user mallman commented on the issue: https://github.com/apache/spark/pull/14690 I've been thinking some more about the metastore/file schema reconciliation. As I mentioned in the PR description, this patch omits this reconciliation. This causes failures when the parquet files

[GitHub] spark issue #14674: [SPARK-17002][CORE]: Document that spark.ssl.protocol. i...

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14674 **[Test build #63997 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63997/consoleFull)** for PR 14674 at commit

[GitHub] spark issue #14674: [SPARK-17002][CORE]: Document that spark.ssl.protocol. i...

2016-08-18 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/14674 @srowen Thanks for your explanation. I misunderstood your previous comment. Now, I addressed your comments. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #14613: [SPARK-16883][SparkR]:SQL decimal type is not properly c...

2016-08-18 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/14613 @felixcheung Let me think about your comments and I will get back soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14697: [SPARK-17124][SQL] RelationalGroupedDataset.agg should p...

2016-08-18 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/14697 @hvanhovell have time to take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14452: [SPARK-16849][SQL] Improve subquery execution by dedupli...

2016-08-18 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/14452 @viirya Had a quick look on this one, It seems that we are trying to make the logical plans looks better, but does not help much for actual physical plan or runtime. For example, for self join, the

[GitHub] spark issue #14690: [SPARK-16980][SQL] Load only catalog table partition met...

2016-08-18 Thread mallman
Github user mallman commented on the issue: https://github.com/apache/spark/pull/14690 @cloud-fan Actually, all hive table partition metadata are retrieved for every query analysis. This is then used to compare the new metadata with the cached metadata. If they're the same, then we

[GitHub] spark issue #14690: [SPARK-16980][SQL] Load only catalog table partition met...

2016-08-18 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/14690 @cloud-fan if an external catalog supports pruning, we shouldn't try to materialize it in memory, since the catalog can probably do a better job of caching and pruning than we can. Currently you can

[GitHub] spark issue #13796: [SPARK-7159][ML] Add multiclass logistic regression to S...

2016-08-18 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/13796 Thanks @dbtsai for the detailed review! I addressed most comments. We still need to: * Decide whether to handle numClasses being specified in metadata * Decide what happens when

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14079 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75352968 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14079 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63993/ Test FAILed. ---

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14079 **[Test build #63993 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63993/consoleFull)** for PR 14079 at commit

[GitHub] spark issue #12790: [SPARK-15018][PYSPARK][ML] Fixed bug causing error if Py...

2016-08-18 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/12790 Yeah, there is no default value in the Scala side. So I guess the thing to do here is to just give a better error message in Python when the param is not set and document the behavior a little

[GitHub] spark issue #14693: [SPARK-17113][Shuffle] Job failure due to Executor OOM i...

2016-08-18 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/14693 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14079 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63992/ Test FAILed. ---

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14079 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14693: [SPARK-17113][Shuffle] Job failure due to Executor OOM i...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14693 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14693: [SPARK-17113][Shuffle] Job failure due to Executor OOM i...

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14693 **[Test build #63991 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63991/consoleFull)** for PR 14693 at commit

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75350270 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75350253 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75350213 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14079 **[Test build #63992 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63992/consoleFull)** for PR 14079 at commit

[GitHub] spark issue #14558: [SPARK-16508][SparkR] Fix warnings on undocumented/dupli...

2016-08-18 Thread junyangq
Github user junyangq commented on the issue: https://github.com/apache/spark/pull/14558 Yes, I see. I was thinking about the case where the generic function has but the corresponding method doesn't. In that case, if we add a dummy `...` at the end of the argument list, its meaning is

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75351207 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -952,13 +963,160 @@ private class LogisticAggregator(

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75351025 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75350717 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75350650 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75350481 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark issue #13796: [SPARK-7159][ML] Add multiclass logistic regression to S...

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13796 **[Test build #63996 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63996/consoleFull)** for PR 13796 at commit

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75350406 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,622 @@ +/* + * Licensed to the

[GitHub] spark issue #14693: [SPARK-17113][Shuffle] Job failure due to Executor OOM i...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14693 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63991/ Test FAILed. ---

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75350300 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75350200 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75350142 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75350108 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75350099 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75350080 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75349959 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75349924 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75349907 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75349892 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75349872 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75349819 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75349849 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r75349832 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,611 @@ +/* + * Licensed to the

[GitHub] spark issue #14680: [SPARK-17101][SQL] Provide consistent format identifiers...

2016-08-18 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/14680 @rxin @HyukjinKwon Mind reviewing it again and letting me know what you think? I know it's minor but would greatly appreciate having it merged at your earliest convenience. Thanks. --- If

[GitHub] spark issue #14702: [SPARK-15694] Implement ScriptTransformation in sql/core

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14702 **[Test build #63995 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63995/consoleFull)** for PR 14702 at commit

[GitHub] spark pull request #14639: [SPARK-17054][SPARKR] SparkR can not run in yarn-...

2016-08-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14639#discussion_r75347400 --- Diff: R/pkg/R/sparkR.R --- @@ -344,6 +344,7 @@ sparkRHive.init <- function(jsc = NULL) { #' @note sparkR.session since 2.0.0 sparkR.session

[GitHub] spark pull request #14702: [SPARK-15694] Implement ScriptTransformation in s...

2016-08-18 Thread tejasapatil
GitHub user tejasapatil opened a pull request: https://github.com/apache/spark/pull/14702 [SPARK-15694] Implement ScriptTransformation in sql/core ## What changes were proposed in this pull request? Added `ScriptTransformationExec` which would run script operator in SQL

[GitHub] spark issue #14701: update-test

2016-08-18 Thread taiyangdixia
Github user taiyangdixia commented on the issue: https://github.com/apache/spark/pull/14701 ok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #14701: update-test

2016-08-18 Thread taiyangdixia
Github user taiyangdixia closed the pull request at: https://github.com/apache/spark/pull/14701 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #14701: update-test

2016-08-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14701 Close this PR please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #14701: update-test

2016-08-18 Thread taiyangdixia
Github user taiyangdixia commented on the issue: https://github.com/apache/spark/pull/14701 wq --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14701: update-test

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14701 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14701: update-test

2016-08-18 Thread taiyangdixia
GitHub user taiyangdixia opened a pull request: https://github.com/apache/spark/pull/14701 update-test ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain how

[GitHub] spark issue #14558: [SPARK-16508][SparkR] Fix warnings on undocumented/dupli...

2016-08-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14558 Does having ... in setGeneric forces CRAN checks to require @param there? I think @mengxr point is that so long as the function definition also has ... we could have one @param at the

[GitHub] spark issue #14583: [SPARK-16994][SQL] PushDownPredicate should not ignore l...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14583 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14583: [SPARK-16994][SQL] PushDownPredicate should not ignore l...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14583 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63986/ Test PASSed. ---

[GitHub] spark issue #14583: [SPARK-16994][SQL] PushDownPredicate should not ignore l...

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14583 **[Test build #63986 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63986/consoleFull)** for PR 14583 at commit

[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63987/ Test PASSed. ---

[GitHub] spark pull request #14639: [SPARK-17054][SPARKR] SparkR can not run in yarn-...

2016-08-18 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/14639#discussion_r75344423 --- Diff: R/pkg/R/sparkR.R --- @@ -344,6 +344,7 @@ sparkRHive.init <- function(jsc = NULL) { #' @note sparkR.session since 2.0.0 sparkR.session <-

[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63987 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63987/consoleFull)** for PR 14571 at commit

[GitHub] spark issue #14527: [SPARK-16938][SQL] `drop/dropDuplicate` should handle th...

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14527 **[Test build #63988 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63988/consoleFull)** for PR 14527 at commit

[GitHub] spark issue #14689: [SPARK-17098][SQL] Fix `NullPropagation` optimizer to ha...

2016-08-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14689 Hi, @hvanhovell . Could you review this PR when you have some time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14639: [SPARK-17054][SPARKR] SparkR can not run in yarn-cluster...

2016-08-18 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14639 @zjffdu Thanks for clarifying -- I now remember that in the YARN cluster mode there is no `SPARK_HOME` set. However in this case the JVM comes up first and the R process then connects to it. So in

[GitHub] spark issue #14689: [SPARK-17098][SQL] Fix `NullPropagation` optimizer to ha...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14689 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14689: [SPARK-17098][SQL] Fix `NullPropagation` optimizer to ha...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14689 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63985/ Test PASSed. ---

[GitHub] spark issue #14689: [SPARK-17098][SQL] Fix `NullPropagation` optimizer to ha...

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14689 **[Test build #63985 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63985/consoleFull)** for PR 14689 at commit

[GitHub] spark issue #14527: [SPARK-16938][SQL] `drop/dropDuplicate` should handle th...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14527 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63988/ Test PASSed. ---

[GitHub] spark issue #14527: [SPARK-16938][SQL] `drop/dropDuplicate` should handle th...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14527 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14623: [SPARK-17044][SQL] Make test files for window functions ...

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14623 **[Test build #63994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63994/consoleFull)** for PR 14623 at commit

[GitHub] spark issue #14623: [SPARK-17044][SQL] Make test files for window functions ...

2016-08-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14623 Hi, @rxin . Could you review this second try for `window_function.sql`? I simplified the test for our eyeballs. --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #14558: [SPARK-16508][SparkR] Fix warnings on undocumented/dupli...

2016-08-18 Thread junyangq
Github user junyangq commented on the issue: https://github.com/apache/spark/pull/14558 Yes, because the generic function and the method are grouped in the same doc and we can only give one description for both of the `...`, we want the actual meaning of them to be same. --- If

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r75339230 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -144,16 +163,172 @@ private[spark] class

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-08-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13680 for 1, currently we only store offsets for var-length element, we should store offset and length as the element content will be word-aligned. --- If your project is set up for it, you can reply

[GitHub] spark issue #12004: [SPARK-7481][build] [WIP] Add Hadoop 2.6+ spark-cloud mo...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12004 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #12004: [SPARK-7481][build] [WIP] Add Hadoop 2.6+ spark-cloud mo...

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12004 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63984/ Test PASSed. ---

[GitHub] spark issue #12004: [SPARK-7481][build] [WIP] Add Hadoop 2.6+ spark-cloud mo...

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12004 **[Test build #63984 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63984/consoleFull)** for PR 12004 at commit

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14079 **[Test build #63993 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63993/consoleFull)** for PR 14079 at commit

[GitHub] spark issue #12790: [SPARK-15018][PYSPARK][ML] Fixed bug causing error if Py...

2016-08-18 Thread MechCoder
Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/12790 If that's the case then the piece of documentation that promises the Pipeline to behave as an identity transformer when no stages are used, has to be changed (removed). --- If your project is

[GitHub] spark issue #14693: [SPARK-17113][Shuffle] Job failure due to Executor OOM i...

2016-08-18 Thread sitalkedia
Github user sitalkedia commented on the issue: https://github.com/apache/spark/pull/14693 @rxin - I am not sure if there is an easy way to unit test this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-08-18 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/14079 @kayousterhout @tgravescs Sorry for the long-delay on my end, I have finally updated this. I think I have addressed all the naming / commenting issues -- I'm going to do a bit more testing on it

[GitHub] spark issue #14693: [SPARK-17113][Shuffle] Job failure due to Executor OOM i...

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14693 **[Test build #63991 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63991/consoleFull)** for PR 14693 at commit

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14079 **[Test build #63992 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63992/consoleFull)** for PR 14079 at commit

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14079 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63990/ Test FAILed. ---

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-08-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14079 **[Test build #63990 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63990/consoleFull)** for PR 14079 at commit

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14079 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14693: [SPARK-17113][Shuffle] Job failure due to Executo...

2016-08-18 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/14693#discussion_r75333091 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -522,7 +522,7 @@ public long spill() throws

[GitHub] spark issue #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14079 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

<    1   2   3   4   5   6   7   >