[GitHub] spark issue #16119: [SPARK-18687][Pyspark][SQL]Backward compatibility - crea...

2016-12-24 Thread vijoshi
Github user vijoshi commented on the issue: https://github.com/apache/spark/pull/16119 @cloud-fan sure, i'll push an update soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93824925 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/simple-in.sql --- @@ -0,0 +1,92 @@ +-- A test suite for simple IN predica

[GitHub] spark pull request #16296: [SPARK-18885][SQL] unify CREATE TABLE syntax for ...

2016-12-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16296#discussion_r93824911 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -342,42 +342,46 @@ class SparkSqlAstBuilder(conf: SQLConf) ex

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93823456 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -56,33 +58,130 @@ case class CreateArray(child

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93823424 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql --- @@ -0,0 +1,117 @@ +-- A test suite for GROUP BY in par

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93823423 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql --- @@ -0,0 +1,117 @@ +-- A test suite for GROUP BY in par

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93823420 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/simple-in.sql --- @@ -0,0 +1,92 @@ +-- A test suite for simple IN predicat

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93823418 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/simple-in.sql --- @@ -0,0 +1,92 @@ +-- A test suite for simple IN predicat

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93823421 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql --- @@ -0,0 +1,117 @@ +-- A test suite for GROUP BY in par

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93823414 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql --- @@ -0,0 +1,117 @@ +-- A test suite for GROUP BY in par

[GitHub] spark issue #15496: [SPARK-17950] [Python] Match SparseVector behavior with ...

2016-12-24 Thread itg-abby
Github user itg-abby commented on the issue: https://github.com/apache/spark/pull/15496 @holdenk Thanks for the review and your availability, I really appreciate the work you are doing too by mentoring me! I didn't realize np.append was making copies, though it made a lot of sens

[GitHub] spark issue #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage policies tes...

2016-12-24 Thread erenavsarogullari
Github user erenavsarogullari commented on the issue: https://github.com/apache/spark/pull/15604 Hi @kayousterhout @markhamstra @squito, This PR aims to extend Pool usage policies unit test coverage and is also ready for review. Thanks and all feedbacks are welcome in advance ;

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93821052 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/simple-in.sql --- @@ -0,0 +1,92 @@ +-- A test suite for simple IN predicate su

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93821009 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql --- @@ -0,0 +1,117 @@ +-- A test suite for GROUP BY in parent

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93820846 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql --- @@ -0,0 +1,117 @@ +-- A test suite for GROUP BY in

[GitHub] spark issue #15237: [SPARK-17663] [CORE] SchedulableBuilder should handle in...

2016-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15237 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15237: [SPARK-17663] [CORE] SchedulableBuilder should handle in...

2016-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15237 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70571/ Test PASSed. ---

[GitHub] spark issue #15237: [SPARK-17663] [CORE] SchedulableBuilder should handle in...

2016-12-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15237 **[Test build #70571 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70571/testReport)** for PR 15237 at commit [`a4e06b2`](https://github.com/apache/spark/commit/a

[GitHub] spark pull request #16388: [SPARK-18989][SQL] DESC TABLE should not fail wit...

2016-12-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16388#discussion_r93819750 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -408,8 +408,8 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93819586 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql --- @@ -0,0 +1,117 @@ +-- A test suite for GROUP BY in pa

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93819526 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/simple-in.sql --- @@ -0,0 +1,92 @@ +-- A test suite for simple IN predica

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93819517 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql --- @@ -0,0 +1,117 @@ +-- A test suite for GROUP BY in pa

[GitHub] spark issue #16392: [SPARK-18992] [SQL] Move spark.sql.hive.thriftServer.sin...

2016-12-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16392 cc @yhuai @cloud-fan @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #15237: [SPARK-17663] [CORE] SchedulableBuilder should ha...

2016-12-24 Thread erenavsarogullari
Github user erenavsarogullari commented on a diff in the pull request: https://github.com/apache/spark/pull/15237#discussion_r93819357 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala --- @@ -102,38 +105,55 @@ private[spark] class FairSchedulableBui

[GitHub] spark pull request #15237: [SPARK-17663] [CORE] SchedulableBuilder should ha...

2016-12-24 Thread erenavsarogullari
Github user erenavsarogullari commented on a diff in the pull request: https://github.com/apache/spark/pull/15237#discussion_r93819365 --- Diff: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala --- @@ -178,4 +177,36 @@ class PoolSuite extends SparkFunSuite with LocalS

[GitHub] spark issue #15237: [SPARK-17663] [CORE] SchedulableBuilder should handle in...

2016-12-24 Thread erenavsarogullari
Github user erenavsarogullari commented on the issue: https://github.com/apache/spark/pull/15237 Hi @squito, Many thanks again for review. All comments have just been addressed via new commit. Also It is ready to rereview / merge ;) --- If your project is set up for it, you c

[GitHub] spark issue #14452: [SPARK-16849][SQL] Improve subquery execution by dedupli...

2016-12-24 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/14452 @viirya For duplicated CTE, without some optimization (pushing down different predicates in different positions), the physical plan should be identical. So I'm wondering some aggressive pushing down

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13909 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13909 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70570/ Test PASSed. ---

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-12-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13909 **[Test build #70570 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70570/testReport)** for PR 13909 at commit [`28df09f`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #16308: [SPARK-18936][SQL] Infrastructure for session local time...

2016-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16308 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70569/ Test PASSed. ---

[GitHub] spark issue #16308: [SPARK-18936][SQL] Infrastructure for session local time...

2016-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16308 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16308: [SPARK-18936][SQL] Infrastructure for session local time...

2016-12-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16308 **[Test build #70569 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70569/testReport)** for PR 16308 at commit [`a00d52f`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #15237: [SPARK-17663] [CORE] SchedulableBuilder should handle in...

2016-12-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15237 **[Test build #70571 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70571/testReport)** for PR 15237 at commit [`a4e06b2`](https://github.com/apache/spark/commit/a4

[GitHub] spark issue #16389: [SPARK-18981][Core]The job hang problem when speculation...

2016-12-24 Thread zhaorongsheng
Github user zhaorongsheng commented on the issue: https://github.com/apache/spark/pull/16389 Yes, I have checked it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] spark pull request #16391: [SPARK-18990][SQL] make DatasetBenchmark fairer f...

2016-12-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16391#discussion_r93818360 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala --- @@ -170,36 +176,39 @@ object DatasetBenchmark { val benchmark3 =

[GitHub] spark issue #16351: [SPARK-18943][SQL] Avoid per-record type dispatch in CSV...

2016-12-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16351 @cloud-fan Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] spark pull request #16351: [SPARK-18943][SQL] Avoid per-record type dispatch...

2016-12-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16351 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #16351: [SPARK-18943][SQL] Avoid per-record type dispatch in CSV...

2016-12-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16351 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93817737 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -56,33 +58,130 @@ case class CreateArray(chil

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-12-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13909 **[Test build #70570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70570/testReport)** for PR 13909 at commit [`28df09f`](https://github.com/apache/spark/commit/28

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93817572 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -56,33 +58,130 @@ case class CreateArray(chil

[GitHub] spark issue #16308: [SPARK-18936][SQL] Infrastructure for session local time...

2016-12-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16308 **[Test build #70569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70569/testReport)** for PR 16308 at commit [`a00d52f`](https://github.com/apache/spark/commit/a0

[GitHub] spark issue #16232: [SPARK-18800][SQL] Correct the assert in UnsafeKVExterna...

2016-12-24 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16232 Thanks @davies @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93817299 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql --- @@ -0,0 +1,117 @@ +-- A test suite for GROUP BY in parent

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93817255 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -58,77 +58,126 @@ case class CreateArray(child

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93817238 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql --- @@ -0,0 +1,117 @@ +-- A test suite for GROUP BY in parent

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93817231 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -56,33 +58,130 @@ case class CreateArray(chil

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93817216 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -56,33 +58,130 @@ case class CreateArray(child

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93817218 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/simple-in.sql --- @@ -0,0 +1,92 @@ +-- A test suite for simple IN predicate su

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2016-12-24 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r93817165 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql --- @@ -0,0 +1,117 @@ +-- A test suite for GROUP BY in parent

[GitHub] spark pull request #16338: [SPARK-18837][WEBUI] Very long stage descriptions...

2016-12-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16338 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #16338: [SPARK-18837][WEBUI] Very long stage descriptions do not...

2016-12-24 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16338 Merged to master/2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #16240: [SPARK-16792][SQL] Dataset containing a Case Clas...

2016-12-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16240#discussion_r93816848 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetPrimitiveSuite.scala --- @@ -130,6 +130,30 @@ class DatasetPrimitiveSuite extends QueryTest w

[GitHub] spark issue #16393: [SPARK-18993] [Build] Revert Split test-tags into test-J...

2016-12-24 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16393 I can reproduce this now on a clean build. I don't think the whole change needs to be reverted; I think it's narrower than that. test-tags no longer has any dependency on Scala libs but does referenc

[GitHub] spark pull request #16232: [SPARK-18800][SQL] Correct the assert in UnsafeKV...

2016-12-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #16232: [SPARK-18800][SQL] Correct the assert in UnsafeKVExterna...

2016-12-24 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16232 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark pull request #16240: [SPARK-16792][SQL] Dataset containing a Case Clas...

2016-12-24 Thread michalsenkyr
Github user michalsenkyr commented on a diff in the pull request: https://github.com/apache/spark/pull/16240#discussion_r93816269 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLImplicits.scala --- @@ -100,31 +97,36 @@ abstract class SQLImplicits { // Seqs

[GitHub] spark issue #16392: [SPARK-18992] [SQL] Move spark.sql.hive.thriftServer.sin...

2016-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16392 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70567/ Test PASSed. ---

[GitHub] spark issue #16392: [SPARK-18992] [SQL] Move spark.sql.hive.thriftServer.sin...

2016-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16392 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16392: [SPARK-18992] [SQL] Move spark.sql.hive.thriftServer.sin...

2016-12-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16392 **[Test build #70567 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70567/testReport)** for PR 16392 at commit [`5221494`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13909 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13909 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70568/ Test FAILed. ---

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-12-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13909 **[Test build #70568 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70568/testReport)** for PR 13909 at commit [`327c8ac`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #16351: [SPARK-18943][SQL] Avoid per-record type dispatch in CSV...

2016-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16351 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16351: [SPARK-18943][SQL] Avoid per-record type dispatch in CSV...

2016-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16351 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70566/ Test PASSed. ---

[GitHub] spark issue #16351: [SPARK-18943][SQL] Avoid per-record type dispatch in CSV...

2016-12-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16351 **[Test build #70566 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70566/testReport)** for PR 16351 at commit [`a036b7f`](https://github.com/apache/spark/commit/a

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93815064 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -58,77 +58,126 @@ case class CreateArray(child

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93815041 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -56,33 +58,130 @@ case class CreateArray(chil

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93815032 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -56,33 +58,130 @@ case class CreateArray(child

[GitHub] spark issue #13758: [SPARK-16043][SQL] Prepare GenericArrayData implementati...

2016-12-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13758 shall we close it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93814957 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -56,33 +58,130 @@ case class CreateArray(c

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93814866 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -58,77 +58,126 @@ case class CreateArray(chil

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93814845 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -58,77 +58,126 @@ case class CreateArray(child

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93814832 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -58,77 +58,126 @@ case class CreateArray(child

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93814790 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -58,77 +58,126 @@ case class CreateArray(chil

[GitHub] spark pull request #16391: [SPARK-18990][SQL] make DatasetBenchmark fairer f...

2016-12-24 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/16391#discussion_r93814766 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala --- @@ -170,36 +176,39 @@ object DatasetBenchmark { val benchmark3 = agg

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93814750 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -58,77 +58,126 @@ case class CreateArray(chil

[GitHub] spark pull request #16391: [SPARK-18990][SQL] make DatasetBenchmark fairer f...

2016-12-24 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/16391#discussion_r93814744 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala --- @@ -133,24 +134,29 @@ object DatasetBenchmark { def aggregate(spark: S

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93814713 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -56,33 +58,81 @@ case class CreateArray(ch

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-12-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13909 **[Test build #70568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70568/testReport)** for PR 13909 at commit [`327c8ac`](https://github.com/apache/spark/commit/32

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93814699 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -56,33 +58,81 @@ case class CreateArray(childr

[GitHub] spark issue #16233: [SPARK-18801][SQL] Add `View` operator to help resolve a...

2016-12-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16233 I also like the last option that is based on local states/variables, especially when we supporting `spark.sql.hive.thriftServer.singleSession`. Here, the disadvantages of session/analyzer-scoped

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93814696 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -56,33 +58,81 @@ case class CreateArray(childr

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-24 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r93814681 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -56,33 +58,81 @@ case class CreateArray(childr

[GitHub] spark issue #16392: [SPARK-18992] [SQL] Move spark.sql.hive.thriftServer.sin...

2016-12-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16392 **[Test build #70567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70567/testReport)** for PR 16392 at commit [`5221494`](https://github.com/apache/spark/commit/52

[GitHub] spark issue #16392: [SPARK-18992] [SQL] Move spark.sql.hive.thriftServer.sin...

2016-12-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16392 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #16351: [SPARK-18943][SQL] Avoid per-record type dispatch in CSV...

2016-12-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16351 **[Test build #70566 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70566/testReport)** for PR 16351 at commit [`a036b7f`](https://github.com/apache/spark/commit/a0

[GitHub] spark pull request #16351: [SPARK-18943][SQL] Avoid per-record type dispatch...

2016-12-24 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16351#discussion_r93814412 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVTypeCastSuite.scala --- @@ -66,144 +66,138 @@ class CSVTypeCastSuite

[GitHub] spark issue #16383: [SPARK-18980][SQL] implement Aggregator with TypedImpera...

2016-12-24 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16383 LGTM. This is a cool improvement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request #16383: [SPARK-18980][SQL] implement Aggregator with Type...

2016-12-24 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16383#discussion_r93814369 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala --- @@ -143,15 +197,96 @@ case class TypedAggregate