[GitHub] spark issue #16841: [SPARK-18871][SQL][TESTS] New test cases for IN/NOT IN s...

2017-02-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16841 **[Test build #72984 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72984/testReport)** for PR 16841 at commit

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-02-15 Thread budde
Github user budde commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r101461535 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -161,23 +161,49 @@ private[hive] class

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-02-15 Thread budde
Github user budde commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r101461357 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSchemaInferenceSuite.scala --- @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-02-15 Thread budde
Github user budde commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r101461155 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSchemaInferenceSuite.scala --- @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-02-15 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16620 @kayousterhout @squito @markhamstra Thanks for all of your work for this patch. Really appreciate your help : ) --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-02-15 Thread budde
Github user budde commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r101460842 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -161,23 +161,49 @@ private[hive] class

[GitHub] spark pull request #16386: [SPARK-18352][SQL] Support parsing multiline json...

2017-02-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16386#discussion_r101460558 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1802,4 +1806,118 @@ class JsonSuite extends

[GitHub] spark issue #16776: [SPARK-19436][SQL] Add missing tests for approxQuantile

2017-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16776 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16776: [SPARK-19436][SQL] Add missing tests for approxQuantile

2017-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16776 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72983/ Test PASSed. ---

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-02-15 Thread budde
Github user budde commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r101460565 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -296,6 +296,17 @@ object SQLConf { .longConf

[GitHub] spark issue #16776: [SPARK-19436][SQL] Add missing tests for approxQuantile

2017-02-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16776 **[Test build #72983 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72983/testReport)** for PR 16776 at commit

[GitHub] spark pull request #16386: [SPARK-18352][SQL] Support parsing multiline json...

2017-02-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16386#discussion_r101460391 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1764,4 +1769,117 @@ class JsonSuite extends

[GitHub] spark pull request #16895: [SPARK-15615][SQL] Add an API to load DataFrame f...

2017-02-15 Thread pjfanning
Github user pjfanning commented on a diff in the pull request: https://github.com/apache/spark/pull/16895#discussion_r101460138 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1364,10 +1364,11 @@ class JsonSuite extends

[GitHub] spark issue #16947: [SPARK-19617][SS][WIP]Don't interrupt 'mkdirs' to workar...

2017-02-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16947 **[Test build #72988 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72988/testReport)** for PR 16947 at commit

[GitHub] spark issue #16953: [SPARK-19622][WebUI]Fix a http error in a paged table wh...

2017-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16953 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #16953: [SPARK-19622][WebUI]Fix a http error in a paged t...

2017-02-15 Thread stanzhai
GitHub user stanzhai opened a pull request: https://github.com/apache/spark/pull/16953 [SPARK-19622][WebUI]Fix a http error in a paged table when using a `Go` button to search. ## What changes were proposed in this pull request? The search function of paged table is not

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-02-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r101457828 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSchemaInferenceSuite.scala --- @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-02-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r101457755 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSchemaInferenceSuite.scala --- @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-02-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r101457348 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSchemaInferenceSuite.scala --- @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #16895: [SPARK-15615][SQL] Add an API to load DataFrame f...

2017-02-15 Thread pjfanning
Github user pjfanning commented on a diff in the pull request: https://github.com/apache/spark/pull/16895#discussion_r101456955 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1364,10 +1364,11 @@ class JsonSuite extends

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-02-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r101456952 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -161,23 +161,49 @@ private[hive] class

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-02-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r101456890 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -161,23 +161,49 @@ private[hive] class

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-02-15 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16729 @felixcheung Thanks for the discussions. Will work on this in two weeks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-02-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r101456600 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -161,23 +161,49 @@ private[hive] class

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-02-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r101456277 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -186,8 +212,7 @@ private[hive] class

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-02-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r101454895 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -296,6 +296,17 @@ object SQLConf { .longConf

[GitHub] spark pull request #16895: [SPARK-15615][SQL] Add an API to load DataFrame f...

2017-02-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16895#discussion_r101454773 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1364,10 +1364,11 @@ class JsonSuite extends

[GitHub] spark pull request #16948: [SPARK-19618][SQL] Inconsistency wrt max. buckets...

2017-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16948 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15125: [SPARK-5484][GraphX] Periodically do checkpoint in Prege...

2017-02-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15125 I think @mallman is saying he would merge changes to @dding3 branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #16951: [SPARK-19619][SPARKR] SparkR approxQuantile suppo...

2017-02-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16951#discussion_r101454231 --- Diff: R/pkg/R/stats.R --- @@ -149,15 +149,18 @@ setMethod("freqItems", signature(x = "SparkDataFrame", cols = "character"), #' This method

[GitHub] spark pull request #16951: [SPARK-19619][SPARKR] SparkR approxQuantile suppo...

2017-02-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16951#discussion_r101454291 --- Diff: R/pkg/R/stats.R --- @@ -149,15 +149,18 @@ setMethod("freqItems", signature(x = "SparkDataFrame", cols = "character"), #' This method

[GitHub] spark issue #16948: [SPARK-19618][SQL] Inconsistency wrt max. buckets allowe...

2017-02-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16948 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #16951: [SPARK-19619][SPARKR] SparkR approxQuantile suppo...

2017-02-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16951#discussion_r101454138 --- Diff: R/pkg/R/stats.R --- @@ -149,15 +149,18 @@ setMethod("freqItems", signature(x = "SparkDataFrame", cols = "character"), #' This method

[GitHub] spark issue #16386: [SPARK-18352][SQL] Support parsing multiline json files

2017-02-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16386 LGTM if the test can pass. It will be good if you can also address https://github.com/apache/spark/pull/16386#discussion_r100679183 --- If your project is set up for it, you can reply to this

[GitHub] spark pull request #16909: [SPARK-13450] Introduce ExternalAppendOnlyUnsafeR...

2017-02-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16909#discussion_r101454158 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArray.scala --- @@ -0,0 +1,218 @@ +/* + * Licensed to

[GitHub] spark issue #16951: [SPARK-19619][SPARKR] SparkR approxQuantile supports inp...

2017-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16951 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72985/ Test PASSed. ---

[GitHub] spark pull request #16951: [SPARK-19619][SPARKR] SparkR approxQuantile suppo...

2017-02-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16951#discussion_r101453993 --- Diff: R/pkg/R/stats.R --- @@ -149,15 +149,18 @@ setMethod("freqItems", signature(x = "SparkDataFrame", cols = "character"), #' This method

[GitHub] spark issue #16952: [SPARK-19620][SQL]Fix incorrect exchange coordinator id ...

2017-02-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16952 **[Test build #72987 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72987/testReport)** for PR 16952 at commit

[GitHub] spark pull request #16386: [SPARK-18352][SQL] Support parsing multiline json...

2017-02-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16386#discussion_r101453945 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala --- @@ -151,6 +153,8 @@ final class DataStreamReader

[GitHub] spark issue #16951: [SPARK-19619][SPARKR] SparkR approxQuantile supports inp...

2017-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16951 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16951: [SPARK-19619][SPARKR] SparkR approxQuantile supports inp...

2017-02-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16951 **[Test build #72985 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72985/testReport)** for PR 16951 at commit

[GitHub] spark pull request #16952: [SPARK-19620][SQL]Fix incorrect exchange coordina...

2017-02-15 Thread carsonwang
GitHub user carsonwang opened a pull request: https://github.com/apache/spark/pull/16952 [SPARK-19620][SQL]Fix incorrect exchange coordinator id in the physical plan ## What changes were proposed in this pull request? When adaptive execution is enabled, an exchange coordinator

[GitHub] spark pull request #16386: [SPARK-18352][SQL] Support parsing multiline json...

2017-02-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16386#discussion_r101453441 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -332,20 +336,21 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark pull request #16386: [SPARK-18352][SQL] Support parsing multiline json...

2017-02-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16386#discussion_r101453350 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -261,14 +261,18 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark issue #16949: [SPARK-16122][CORE] Add rest api for job environment

2017-02-15 Thread uncleGen
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/16949 cc @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #16948: [SPARK-19618][SQL] Inconsistency wrt max. buckets allowe...

2017-02-15 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/16948 @cloud-fan : this is as per our discussion in https://github.com/apache/spark/pull/16931#discussion_r101170361 --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #16915: [SPARK-18871][SQL][TESTS] New test cases for IN/NOT IN s...

2017-02-15 Thread kevinyu98
Github user kevinyu98 commented on the issue: https://github.com/apache/spark/pull/16915 @gatorsmile thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #16386: [SPARK-18352][SQL] Support parsing multiline json...

2017-02-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16386#discussion_r101451711 --- Diff: python/pyspark/sql/streaming.py --- @@ -442,6 +444,8 @@ def json(self, path, schema=None, primitivesAsString=None, prefersDecimal=None,

[GitHub] spark pull request #16386: [SPARK-18352][SQL] Support parsing multiline json...

2017-02-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16386#discussion_r101451677 --- Diff: python/pyspark/sql/readwriter.py --- @@ -159,18 +159,21 @@ def json(self, path, schema=None, primitivesAsString=None, prefersDecimal=None,

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-02-15 Thread kayousterhout
Github user kayousterhout commented on the issue: https://github.com/apache/spark/pull/16620 LGTM! Thanks for finding this subtle bug and all of the hard work to fix it @jinxing64. I'll wait until tomorrow to merge this to give Mark and Imran a chance for any last comments. --- If

[GitHub] spark issue #16949: [SPARK-16122][CORE] Add rest api for job environment

2017-02-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16949 **[Test build #72986 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72986/testReport)** for PR 16949 at commit

[GitHub] spark pull request #16818: [SPARK-19451][SQL][Core] Underlying integer overf...

2017-02-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16818#discussion_r101451202 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/WindowSpec.scala --- @@ -180,16 +180,20 @@ class WindowSpec private[sql](

[GitHub] spark issue #16949: [SPARK-16122][CORE] Add rest api for job environment

2017-02-15 Thread uncleGen
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/16949 jenkins crushed. retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16951: [SPARK-19619][SPARKR] SparkR approxQuantile supports inp...

2017-02-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16951 **[Test build #72985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72985/testReport)** for PR 16951 at commit

[GitHub] spark pull request #16951: [SPARK-19619][SPARKR] SparkR approxQuantile suppo...

2017-02-15 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/16951 [SPARK-19619][SPARKR] SparkR approxQuantile supports input multiple columns ## What changes were proposed in this pull request? SparkR ```approxQuantile``` supports input multiple columns.

[GitHub] spark issue #16949: [SPARK-16122][CORE] Add rest api for job environment

2017-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16949 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72979/ Test FAILed. ---

[GitHub] spark issue #16949: [SPARK-16122][CORE] Add rest api for job environment

2017-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16949 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16949: [SPARK-16122][CORE] Add rest api for job environment

2017-02-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16949 **[Test build #72979 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72979/testReport)** for PR 16949 at commit

[GitHub] spark issue #16944: [SPARK-19611][SQL] Introduce configurable table schema i...

2017-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16944 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72978/ Test PASSed. ---

[GitHub] spark issue #16944: [SPARK-19611][SQL] Introduce configurable table schema i...

2017-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16944 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16722: [SPARK-19591][ML][MLlib] Add sample weights to de...

2017-02-15 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16722#discussion_r101449037 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/BaggedPoint.scala --- @@ -60,12 +68,14 @@ private[spark] object BaggedPoint {

[GitHub] spark issue #16944: [SPARK-19611][SQL] Introduce configurable table schema i...

2017-02-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16944 **[Test build #72978 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72978/testReport)** for PR 16944 at commit

[GitHub] spark pull request #16722: [SPARK-19591][ML][MLlib] Add sample weights to de...

2017-02-15 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16722#discussion_r101448976 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/BaggedPoint.scala --- @@ -82,16 +92,16 @@ private[spark] object BaggedPoint { val

[GitHub] spark pull request #16722: [SPARK-19591][ML][MLlib] Add sample weights to de...

2017-02-15 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16722#discussion_r101448658 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala --- @@ -351,6 +370,36 @@ class

[GitHub] spark pull request #16722: [SPARK-19591][ML][MLlib] Add sample weights to de...

2017-02-15 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16722#discussion_r101448626 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/DecisionTreeMetadata.scala --- @@ -115,7 +122,10 @@ private[spark] object DecisionTreeMetadata

[GitHub] spark issue #16844: [SPARK-19500] [SQL] Fix off-by-one bug in BytesToBytesMa...

2017-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16844 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16844: [SPARK-19500] [SQL] Fix off-by-one bug in BytesToBytesMa...

2017-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16844 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72977/ Test PASSed. ---

[GitHub] spark issue #16844: [SPARK-19500] [SQL] Fix off-by-one bug in BytesToBytesMa...

2017-02-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16844 **[Test build #72977 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72977/testReport)** for PR 16844 at commit

[GitHub] spark pull request #14412: [SPARK-15355] [CORE] Proactive block replication

2017-02-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14412#discussion_r101447842 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala --- @@ -65,6 +66,8 @@ class BlockManagerMasterEndpoint(

[GitHub] spark pull request #16499: [SPARK-17204][CORE] Fix replicated off heap stora...

2017-02-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16499#discussion_r101448019 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -813,7 +813,14 @@ private[spark] class BlockManager(

[GitHub] spark pull request #14412: [SPARK-15355] [CORE] Proactive block replication

2017-02-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14412#discussion_r101447797 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala --- @@ -195,17 +198,39 @@ class BlockManagerMasterEndpoint(

[GitHub] spark pull request #14412: [SPARK-15355] [CORE] Proactive block replication

2017-02-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14412#discussion_r101447703 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala --- @@ -195,17 +198,39 @@ class BlockManagerMasterEndpoint(

[GitHub] spark pull request #14412: [SPARK-15355] [CORE] Proactive block replication

2017-02-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14412#discussion_r101446619 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1131,14 +1131,43 @@ private[spark] class BlockManager( }

[GitHub] spark issue #16950: [SPARK-19399][SPARKR][BACKPORT-2.1] fix tests broken by ...

2017-02-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16950 merged to branch-2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #14412: [SPARK-15355] [CORE] Proactive block replication

2017-02-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14412#discussion_r101447299 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1131,14 +1131,43 @@ private[spark] class BlockManager( }

[GitHub] spark pull request #16950: [SPARK-19399][SPARKR][BACKPORT-2.1] fix tests bro...

2017-02-15 Thread felixcheung
Github user felixcheung closed the pull request at: https://github.com/apache/spark/pull/16950 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #14412: [SPARK-15355] [CORE] Proactive block replication

2017-02-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14412#discussion_r101447394 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1131,14 +1131,43 @@ private[spark] class BlockManager( }

[GitHub] spark pull request #14412: [SPARK-15355] [CORE] Proactive block replication

2017-02-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14412#discussion_r101446632 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1131,14 +1131,43 @@ private[spark] class BlockManager( }

[GitHub] spark pull request #14412: [SPARK-15355] [CORE] Proactive block replication

2017-02-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14412#discussion_r101446759 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala --- @@ -195,17 +198,39 @@ class BlockManagerMasterEndpoint(

[GitHub] spark pull request #14412: [SPARK-15355] [CORE] Proactive block replication

2017-02-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14412#discussion_r101446961 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1131,14 +1131,43 @@ private[spark] class BlockManager( }

[GitHub] spark pull request #14412: [SPARK-15355] [CORE] Proactive block replication

2017-02-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14412#discussion_r101447547 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala --- @@ -195,17 +198,39 @@ class BlockManagerMasterEndpoint(

[GitHub] spark pull request #16915: [SPARK-18871][SQL][TESTS] New test cases for IN/N...

2017-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16915 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14412: [SPARK-15355] [CORE] Proactive block replication

2017-02-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14412#discussion_r101447632 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala --- @@ -195,17 +198,39 @@ class BlockManagerMasterEndpoint(

[GitHub] spark issue #16950: [SPARK-19399][SPARKR][BACKPORT-2.1] fix tests broken by ...

2017-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16950 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72982/ Test PASSed. ---

[GitHub] spark issue #16950: [SPARK-19399][SPARKR][BACKPORT-2.1] fix tests broken by ...

2017-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16950 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16915: [SPARK-18871][SQL][TESTS] New test cases for IN/NOT IN s...

2017-02-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16915 LGTM. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16950: [SPARK-19399][SPARKR][BACKPORT-2.1] fix tests broken by ...

2017-02-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16950 **[Test build #72982 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72982/testReport)** for PR 16950 at commit

[GitHub] spark issue #16841: [SPARK-18871][SQL][TESTS] New test cases for IN/NOT IN s...

2017-02-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16841 **[Test build #72984 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72984/testReport)** for PR 16841 at commit

[GitHub] spark pull request #16499: [SPARK-17204][CORE] Fix replicated off heap stora...

2017-02-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16499#discussion_r101447383 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1018,7 +1025,9 @@ private[spark] class BlockManager( try {

[GitHub] spark issue #16841: [SPARK-18871][SQL][TESTS] New test cases for IN/NOT IN s...

2017-02-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16841 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #16776: [SPARK-19436][SQL] Add missing tests for approxQuantile

2017-02-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16776 **[Test build #72983 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72983/testReport)** for PR 16776 at commit

[GitHub] spark issue #15468: [SPARK-17915][SQL] Prepare a new ColumnVector implementa...

2017-02-15 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/15468 @sameeragarwal would it be possible to review this since I resolved a conflict? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #16945: [SPARK-19616][SparkR]:weightCol and aggregationDepth sho...

2017-02-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16945 could you add some tests (I don't think we need one for each) that the weight col is set properly? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16620 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72974/ Test PASSed. ---

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16620 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-02-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16620 **[Test build #72974 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72974/testReport)** for PR 16620 at commit

[GitHub] spark pull request #16934: [SPARK-19603][SS]Fix StreamingQuery explain comma...

2017-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16934 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16934: [SPARK-19603][SS]Fix StreamingQuery explain command

2017-02-15 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/16934 Thanks! Merging to master and 2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16950: [SPARK-19399][SPARKR][BACKPORT-2.1] fix tests broken by ...

2017-02-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16950 **[Test build #72982 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72982/testReport)** for PR 16950 at commit

[GitHub] spark issue #16512: [SPARK-18335][SPARKR] createDataFrame to support numPart...

2017-02-15 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/16512 At least from the R code perspective this is source code compatible with existing 2.1, as adding an optional parameter at the end should not break any existing code. Also I am not sure I would

  1   2   3   4   5   6   >