[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...

2017-03-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17340 **[Test build #74779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74779/testReport)** for PR 17340 at commit [`7c8d92b`](https://github.com/apache/spark/commit/7c

[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...

2017-03-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17340 **[Test build #74778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74778/testReport)** for PR 17340 at commit [`8d287d3`](https://github.com/apache/spark/commit/8d

[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...

2017-03-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17340 **[Test build #74777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74777/testReport)** for PR 17340 at commit [`26c6c7b`](https://github.com/apache/spark/commit/26

[GitHub] spark pull request #17340: [SPARK-20013][SQL] merge renameTable to alterTabl...

2017-03-18 Thread windpiger
GitHub user windpiger opened a pull request: https://github.com/apache/spark/pull/17340 [SPARK-20013][SQL] merge renameTable to alterTable in ExternCatalog ## What changes were proposed in this pull request? ## How was this patch tested? delete some tests in Externa

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106063310 --- Diff: core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala --- @@ -48,12 +50,30 @@ private[spark] object CryptoStreamUtils extends Logg

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106779317 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -73,55 +86,219 @@ private[spark] class DiskStore(conf: SparkConf, diskManager:

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106778005 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -56,6 +57,43 @@ private[spark] class BlockResult( val bytes: Long)

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106778650 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala --- @@ -79,6 +81,11 @@ private[spark] class DiskBlockManager(conf: SparkConf,

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106778688 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -17,48 +17,61 @@ package org.apache.spark.storage -import

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106778760 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -73,55 +86,219 @@ private[spark] class DiskStore(conf: SparkConf, diskManager:

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106268712 --- Diff: core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala --- @@ -63,12 +83,40 @@ private[spark] object CryptoStreamUtils extends Logg

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106264689 --- Diff: core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala --- @@ -63,12 +83,40 @@ private[spark] object CryptoStreamUtils extends Logg

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106778914 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -17,48 +17,61 @@ package org.apache.spark.storage -import

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106778932 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -73,55 +86,219 @@ private[spark] class DiskStore(conf: SparkConf, diskManager:

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106779457 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -73,55 +86,219 @@ private[spark] class DiskStore(conf: SparkConf, diskManager:

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106778813 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -73,55 +86,219 @@ private[spark] class DiskStore(conf: SparkConf, diskManager:

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106779213 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -17,48 +17,61 @@ package org.apache.spark.storage -import

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106779546 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -73,55 +86,219 @@ private[spark] class DiskStore(conf: SparkConf, diskManager:

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106779004 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala --- @@ -34,6 +34,8 @@ import org.apache.spark.util.{ShutdownHookManager, Utils

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106269093 --- Diff: core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala --- @@ -102,4 +150,34 @@ private[spark] object CryptoStreamUtils extends Lo

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r10677 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala --- @@ -94,7 +101,11 @@ private[spark] class DiskBlockManager(conf: SparkConf,

[GitHub] spark issue #17338: [SPARK-19990][SQL][test-maven]create a temp file for fil...

2017-03-18 Thread windpiger
Github user windpiger commented on the issue: https://github.com/apache/spark/pull/17338 According to the jenkins' log, the test case ` test("create temporary view using")` in `DDLSuite` passed the test. This pr resolved the test failed reported in [SPARK-19990](https://issues.a

[GitHub] spark issue #17338: [SPARK-19990][SQL][test-maven]create a temp file for fil...

2017-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17338 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17338: [SPARK-19990][SQL][test-maven]create a temp file for fil...

2017-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17338 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74776/ Test FAILed. ---

[GitHub] spark issue #17338: [SPARK-19990][SQL][test-maven]create a temp file for fil...

2017-03-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17338 **[Test build #74776 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74776/testReport)** for PR 17338 at commit [`a02d3d6`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #17330: [SPARK-19993][SQL][WIP] Caching logical plans containing...

2017-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17330 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74775/ Test PASSed. ---

[GitHub] spark issue #17330: [SPARK-19993][SQL][WIP] Caching logical plans containing...

2017-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17330 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17330: [SPARK-19993][SQL][WIP] Caching logical plans containing...

2017-03-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17330 **[Test build #74775 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74775/testReport)** for PR 17330 at commit [`2b9d717`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #16626: [SPARK-19261][SQL] Alter add columns for Hive serde and ...

2017-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16626 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16626: [SPARK-19261][SQL] Alter add columns for Hive serde and ...

2017-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16626 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74774/ Test PASSed. ---

[GitHub] spark issue #16626: [SPARK-19261][SQL] Alter add columns for Hive serde and ...

2017-03-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16626 **[Test build #74774 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74774/testReport)** for PR 16626 at commit [`ae324d3`](https://github.com/apache/spark/commit/a

[GitHub] spark pull request #17338: [SPARK-19990][SQL][test-maven]create a temp file ...

2017-03-18 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/17338#discussion_r106778719 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -700,20 +701,33 @@ abstract class DDLSuite extends QueryTe

[GitHub] spark issue #17338: [SPARK-19990][SQL][test-maven]create a temp file for fil...

2017-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17338 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17338: [SPARK-19990][SQL][test-maven]create a temp file for fil...

2017-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17338 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74773/ Test PASSed. ---

[GitHub] spark issue #17338: [SPARK-19990][SQL][test-maven]create a temp file for fil...

2017-03-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17338 **[Test build #74773 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74773/testReport)** for PR 17338 at commit [`a02d3d6`](https://github.com/apache/spark/commit/a

[GitHub] spark pull request #17329: [SPARK-19991]FileSegmentManagedBuffer performance...

2017-03-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17329#discussion_r106778634 --- Diff: common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java --- @@ -37,13 +37,24 @@ * A {@link Managed

[GitHub] spark pull request #17334: [SPARK-19998][Block Manager]BlockRDD block not fo...

2017-03-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17334#discussion_r106778471 --- Diff: core/src/main/scala/org/apache/spark/rdd/BlockRDD.scala --- @@ -47,7 +47,9 @@ class BlockRDD[T: ClassTag](sc: SparkContext, @transient val blockIds

[GitHub] spark issue #17088: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17088 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17088: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17088 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74771/ Test PASSed. ---

[GitHub] spark issue #17088: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-03-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17088 **[Test build #74771 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74771/testReport)** for PR 17088 at commit [`9f64e29`](https://github.com/apache/spark/commit/9

[GitHub] spark pull request #17338: [SPARK-19990][SQL][test-maven]create a temp file ...

2017-03-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17338#discussion_r10696 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -700,20 +701,33 @@ abstract class DDLSuite extends QueryTest

[GitHub] spark issue #17338: [SPARK-19990][SQL][test-maven]create a temp file for fil...

2017-03-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17338 **[Test build #74776 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74776/testReport)** for PR 17338 at commit [`a02d3d6`](https://github.com/apache/spark/commit/a0

[GitHub] spark issue #17338: [SPARK-19990][SQL][test-maven]create a temp file for fil...

2017-03-18 Thread windpiger
Github user windpiger commented on the issue: https://github.com/apache/spark/pull/17338 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #17330: [SPARK-19993][SQL][WIP] Caching logical plans containing...

2017-03-18 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/17330 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] spark issue #17330: [SPARK-19993][SQL][WIP] Caching logical plans containing...

2017-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17330 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74772/ Test FAILed. ---

[GitHub] spark issue #17330: [SPARK-19993][SQL][WIP] Caching logical plans containing...

2017-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17330 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #17338: [SPARK-19990][SQL][maven]create a temp file for f...

2017-03-18 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/17338#discussion_r106777091 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -700,20 +701,33 @@ abstract class DDLSuite extends QueryTe

[GitHub] spark issue #16626: [SPARK-19261][SQL] Alter add columns for Hive serde and ...

2017-03-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16626 **[Test build #74774 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74774/testReport)** for PR 16626 at commit [`ae324d3`](https://github.com/apache/spark/commit/ae

[GitHub] spark issue #17338: [SPARK-19990][SQL]create a temp file for file in test.ja...

2017-03-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17338 **[Test build #74773 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74773/testReport)** for PR 17338 at commit [`a02d3d6`](https://github.com/apache/spark/commit/a0

[GitHub] spark pull request #17338: [SPARK-19990][SQL]create a temp file for file in ...

2017-03-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17338#discussion_r106776627 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -700,20 +701,33 @@ abstract class DDLSuite extends QueryTest

[GitHub] spark issue #17330: [SPARK-19993][SQL][WIP] Caching logical plans containing...

2017-03-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17330 **[Test build #74772 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74772/testReport)** for PR 17330 at commit [`2b9d717`](https://github.com/apache/spark/commit/2b

[GitHub] spark issue #17088: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-03-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17088 **[Test build #74771 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74771/testReport)** for PR 17088 at commit [`9f64e29`](https://github.com/apache/spark/commit/9f

[GitHub] spark issue #17088: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-03-18 Thread sitalkedia
Github user sitalkedia commented on the issue: https://github.com/apache/spark/pull/17088 jenkins retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17286: [SPARK-19915][SQL] Exclude cartesian product cand...

2017-03-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17286#discussion_r106775334 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -19,31 +19,33 @@ package org.apache.spar

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

2017-03-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r106775288 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -0,0 +1,297 @@ +/* + * Licensed

[GitHub] spark issue #17339: [SPARK-20010][SQL] Sort information is lost after sort m...

2017-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17339 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74770/ Test FAILed. ---

[GitHub] spark issue #17339: [SPARK-20010][SQL] Sort information is lost after sort m...

2017-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17339 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #17331: [SPARK-19994][SQL] Wrong outputOrdering for right...

2017-03-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17331#discussion_r106775256 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala --- @@ -557,6 +470,130 @@ class PlannerSuite extends SharedSQLContext

[GitHub] spark issue #17182: [SPARK-19840][SQL] Disallow creating permanent functions...

2017-03-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17182 Thank you for review, @holdenk and @gatorsmile . According to the review comment, I'll close this PR and JIRA issue as WON'T FIX for now. --- If your project is set up for it, you can rep

[GitHub] spark pull request #17182: [SPARK-19840][SQL] Disallow creating permanent fu...

2017-03-18 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/17182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

2017-03-18 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r106775194 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -0,0 +1,297 @@ +/* + * Licensed to th

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

2017-03-18 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r106775177 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -0,0 +1,297 @@ +/* + * Licensed to th

<    1   2   3   4