Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/17295#discussion_r106778932
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -73,55 +86,219 @@ private[spark] class DiskStore(conf: SparkConf,
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/17295#discussion_r106779457
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -73,55 +86,219 @@ private[spark] class DiskStore(conf: SparkConf,
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/17295#discussion_r106779213
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -17,48 +17,61 @@
package org.apache.spark.storage
-import
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/17295#discussion_r106779546
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -73,55 +86,219 @@ private[spark] class DiskStore(conf: SparkConf,
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/17295#discussion_r106779004
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -34,6 +34,8 @@ import org.apache.spark.util.{ShutdownHookManager,
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/17295#discussion_r106269093
--- Diff:
core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala ---
@@ -102,4 +150,34 @@ private[spark] object CryptoStreamUtils extends
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/17295#discussion_r10677
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -94,7 +101,11 @@ private[spark] class DiskBlockManager(conf:
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17338
According to the jenkins' log, the test case ` test("create temporary view
using")` in `DDLSuite` passed the test.
This pr resolved the test failed reported in
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17338
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17338
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74776/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17338
**[Test build #74776 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74776/testReport)**
for PR 17338 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17330
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74775/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17330
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17330
**[Test build #74775 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74775/testReport)**
for PR 17330 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16626
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16626
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74774/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16626
**[Test build #74774 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74774/testReport)**
for PR 16626 at commit
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17338#discussion_r106778719
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -700,20 +701,33 @@ abstract class DDLSuite extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17338
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17338
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74773/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17338
**[Test build #74773 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74773/testReport)**
for PR 17338 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17329#discussion_r106778634
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java
---
@@ -37,13 +37,24 @@
* A {@link
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17334#discussion_r106778471
--- Diff: core/src/main/scala/org/apache/spark/rdd/BlockRDD.scala ---
@@ -47,7 +47,9 @@ class BlockRDD[T: ClassTag](sc: SparkContext, @transient
val
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17088
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17088
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74771/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17088
**[Test build #74771 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74771/testReport)**
for PR 17088 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17338#discussion_r10696
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -700,20 +701,33 @@ abstract class DDLSuite extends QueryTest
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17338
**[Test build #74776 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74776/testReport)**
for PR 17338 at commit
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17338
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17330
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17330
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74772/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17330
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17338#discussion_r106777091
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -700,20 +701,33 @@ abstract class DDLSuite extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16626
**[Test build #74774 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74774/testReport)**
for PR 16626 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17338
**[Test build #74773 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74773/testReport)**
for PR 17338 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17338#discussion_r106776627
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -700,20 +701,33 @@ abstract class DDLSuite extends QueryTest
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17330
**[Test build #74772 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74772/testReport)**
for PR 17330 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17088
**[Test build #74771 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74771/testReport)**
for PR 17088 at commit
Github user sitalkedia commented on the issue:
https://github.com/apache/spark/pull/17088
jenkins retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17286#discussion_r106775334
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
---
@@ -19,31 +19,33 @@ package
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17138#discussion_r106775288
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
---
@@ -0,0 +1,297 @@
+/*
+ * Licensed
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17339
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74770/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17339
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17331#discussion_r106775256
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -557,6 +470,130 @@ class PlannerSuite extends SharedSQLContext
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17182
Thank you for review, @holdenk and @gatorsmile .
According to the review comment, I'll close this PR and JIRA issue as WON'T
FIX for now.
---
If your project is set up for it, you can
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/17182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17138#discussion_r106775194
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
---
@@ -0,0 +1,297 @@
+/*
+ * Licensed to
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17138#discussion_r106775177
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
---
@@ -0,0 +1,297 @@
+/*
+ * Licensed to
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17311
If there is anything to do more, please let me know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sachintyagi22 commented on the issue:
https://github.com/apache/spark/pull/17332
cc @jkbradley Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/17286
@ioana-delaney How can we get disconnected parts before reordering? They
can not only be leaf tables (this case is easier to deal with), but also
subplans (tables can be joined internally but among
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17286#discussion_r106775016
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
---
@@ -19,31 +19,33 @@ package
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17318
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17339
**[Test build #74770 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74770/testReport)**
for PR 17339 at commit
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/17240
Since [the other pr](https://github.com/apache/spark/pull/17286) for the
same jira has been merged, I'm closing this. Thanks for reviews and
discussions! If you have any more comments, I'll fix them
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/17339
cc @cloud-fan @hvanhovell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user wzhfy closed the pull request at:
https://github.com/apache/spark/pull/17240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17138#discussion_r106774778
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
---
@@ -0,0 +1,297 @@
+/*
+ * Licensed
GitHub user wzhfy opened a pull request:
https://github.com/apache/spark/pull/17339
[SPARK-20010][SQL] Sort information is lost after sort merge join
## What changes were proposed in this pull request?
After sort merge join for inner join, now we only keep left key
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17338
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74769/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17338
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17338
**[Test build #74769 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74769/testReport)**
for PR 17338 at commit
Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/17297#discussion_r106774683
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -193,13 +193,6 @@ private[spark] class TaskSchedulerImpl
Github user sitalkedia commented on the issue:
https://github.com/apache/spark/pull/17297
Thanks a lot @squito for taking a look at it and for your feedback.
>> this is already true. when there is a fetch failure, the TaskSetManager
is marked as zombie, and the DAGScheduler
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17219
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74767/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17219
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17219
**[Test build #74767 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74767/testReport)**
for PR 17219 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17286
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17088
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17088
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74768/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17088
**[Test build #74768 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74768/testReport)**
for PR 17088 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17286
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17219
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17219
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74766/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17219
**[Test build #74766 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74766/testReport)**
for PR 17219 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15363#discussion_r106774363
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/StarJoinSuite.scala
---
@@ -0,0 +1,488 @@
+/*
+ * Licensed to the Apache
301 - 377 of 377 matches
Mail list logo
